test(svelte-query): replace inline props types with 'type Props', remove 'any', and add explicit generics by sukvvon · Pull Request #10448 · TanStack/query

sukvvon · 2026-04-11T07:36:49Z

🎯 Changes

Replace inline props types with type Props across 16 Svelte test components
Remove any types:
- OnSuccessExample: onSuccessMock: any → (data: number) => void, onSettledMock: any → (data: number | undefined) => void
- useMutationState/SelectExample: MutationStateOptions<any> → MutationStateOptions<string>
Add explicit generics to CreateMutationOptions:
- mutationOptions/BaseExample, MultiExample: CreateMutationOptions → CreateMutationOptions<string>
- useMutationState/BaseExample, SelectExample: CreateMutationOptions → CreateMutationOptions<string>
Remove unnecessary | undefined from optional prop type in useMutationState/BaseExample

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Refactor
- Reorganized and consolidated internal component type definitions across the test suite for improved code clarity and better maintainability.
- Refined and enhanced type specifications for mutation and query operations in test examples, providing clearer and more accurate type information.
- Updated generic type parameters in options objects to improve type safety and precision in test component implementations.

…ove 'any', and add explicit generics

coderabbitai · 2026-04-11T07:37:04Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a9f2adf-dac8-48c5-9497-988032cfe3d0

📥 Commits

Reviewing files that changed from the base of the PR and between 1881109 and e4254a5.

📒 Files selected for processing (16)

packages/svelte-query/tests/HydrationBoundary/BaseExample.svelte
packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte
packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte
packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte
packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte
packages/svelte-query/tests/createMutation/FailureExample.svelte
packages/svelte-query/tests/createMutation/OnSuccessExample.svelte
packages/svelte-query/tests/createMutation/ResetExample.svelte
packages/svelte-query/tests/createQueries/IsRestoringExample.svelte
packages/svelte-query/tests/createQuery/IsRestoringExample.svelte
packages/svelte-query/tests/mutationOptions/BaseExample.svelte
packages/svelte-query/tests/mutationOptions/MultiExample.svelte
packages/svelte-query/tests/useIsFetching/BaseExample.svelte
packages/svelte-query/tests/useIsMutating/BaseExample.svelte
packages/svelte-query/tests/useMutationState/BaseExample.svelte
packages/svelte-query/tests/useMutationState/SelectExample.svelte

📝 Walkthrough

Walkthrough

Refactored $props() type annotations across 17 test components in svelte-query by replacing inline object types with named Props type aliases. Additionally tightened generic type parameters in mutation options and state components for more explicit typing.

Changes

Cohort / File(s)	Summary
Inline to Named Props Type Refactoring `packages/svelte-query/tests/HydrationBoundary/BaseExample.svelte`, `packages/svelte-query/tests/QueryClientProvider/BaseExample.svelte`, `packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte`, `packages/svelte-query/tests/createInfiniteQuery/ChangeClientExample.svelte`, `packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte`, `packages/svelte-query/tests/createMutation/FailureExample.svelte`, `packages/svelte-query/tests/createMutation/ResetExample.svelte`, `packages/svelte-query/tests/createQueries/IsRestoringExample.svelte`, `packages/svelte-query/tests/createQuery/IsRestoringExample.svelte`, `packages/svelte-query/tests/useIsFetching/BaseExample.svelte`, `packages/svelte-query/tests/useIsMutating/BaseExample.svelte`	Replaced inline `$props()` destructuring type annotations with explicit `type Props` declarations. Destructuring assignments now reference the named type instead of inline object type literals.
Props Type Refactoring with Generic Parameterization `packages/svelte-query/tests/mutationOptions/BaseExample.svelte`, `packages/svelte-query/tests/mutationOptions/MultiExample.svelte`, `packages/svelte-query/tests/useMutationState/BaseExample.svelte`, `packages/svelte-query/tests/useMutationState/SelectExample.svelte`	Introduced named `Props` types and tightened generic type parameters in `CreateMutationOptions` from unparameterized/`any` forms to explicitly `CreateMutationOptions<string>`. Mutation options now have stricter type constraints.
Explicit Function Type Signatures `packages/svelte-query/tests/createMutation/OnSuccessExample.svelte`	Replaced untyped `any` callback parameters with explicit function signatures: `onSuccessMock: (data: number) => void` and `onSettledMock: (data: number \| undefined) => void`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

test(svelte-query): extract 'queryClient' creation from Svelte components to test files #10447: Modifies the same svelte-query test components' $props() destructuring and props typing, moving QueryClient creation and adding explicit prop patterns.

Suggested labels

package: svelte-query

Poem

🐰 Props refactored neat and clean,
Named types shine where inlines had been,
Generic strings now strictly bound,
Type safety all throughout the ground!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: refactoring inline props types to named `type Props` across test components while removing `any` types and adding explicit generics.
Description check	✅ Passed	The description follows the template structure with all required sections: detailed 🎯 Changes, completed ✅ Checklist, and 🚀 Release Impact. All key modifications are documented with specific examples.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/svelte-query-improve-type-clarity

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-11T07:37:20Z

View your CI Pipeline Execution ↗ for commit e4254a5

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	58s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-11 07:38:54 UTC

github-actions · 2026-04-11T07:37:42Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-11T07:38:18Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10448

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10448

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10448

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10448

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10448

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10448

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10448

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10448

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10448

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10448

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10448

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10448

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10448

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10448

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10448

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10448

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10448

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10448

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10448

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10448

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10448

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10448

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10448

commit: e4254a5

github-actions · 2026-04-11T07:38:26Z

size-limit report 📦

Path	Size
react full	11.99 KB (0%)
react minimal	9.02 KB (0%)

test(svelte-query): replace inline props types with 'type Props', rem…

e4254a5

…ove 'any', and add explicit generics

github-actions Bot added the package: svelte-query label Apr 11, 2026

sukvvon self-assigned this Apr 11, 2026

sukvvon merged commit ee5b574 into main Apr 11, 2026
10 checks passed

sukvvon deleted the test/svelte-query-improve-type-clarity branch April 11, 2026 07:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(svelte-query): replace inline props types with 'type Props', remove 'any', and add explicit generics#10448

test(svelte-query): replace inline props types with 'type Props', remove 'any', and add explicit generics#10448
sukvvon merged 1 commit intomainfrom
test/svelte-query-improve-type-clarity

sukvvon commented Apr 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 11, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloud Bot commented Apr 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 11, 2026

Uh oh!

pkg-pr-new Bot commented Apr 11, 2026

Uh oh!

github-actions Bot commented Apr 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloud Bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 11, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Apr 11, 2026

Uh oh!

github-actions Bot commented Apr 11, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 11, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 11, 2026 •

edited

Loading

nx-cloud Bot commented Apr 11, 2026 •

edited

Loading