Skip to content

test(svelte-query/createInfiniteQuery): remove unused 'svelte-ignore state_snapshot_uncloneable' comments#10449

Merged
sukvvon merged 1 commit intomainfrom
test/svelte-query-remove-unused-svelte-ignore
Apr 11, 2026
Merged

test(svelte-query/createInfiniteQuery): remove unused 'svelte-ignore state_snapshot_uncloneable' comments#10449
sukvvon merged 1 commit intomainfrom
test/svelte-query-remove-unused-svelte-ignore

Conversation

@sukvvon
Copy link
Copy Markdown
Collaborator

@sukvvon sukvvon commented Apr 11, 2026 •
edited by coderabbitai Bot
Loading

🎯 Changes

  • Remove unused // svelte-ignore state_snapshot_uncloneable comments from BaseExample.svelte and SelectExample.svelte
    • The warning is no longer triggered, making the svelte-ignore comment unnecessary
    • // @ts-expect-error is retained as the Snapshot type mismatch with QueryObserverResult is a known Svelte limitation

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Removed internal compiler directives from test files to streamline the codebase.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 11, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f20db6c4-2bab-4fee-92a8-032aa910ee7f

📥 Commits

Reviewing files that changed from the base of the PR and between ee5b574 and 60608e3.

📒 Files selected for processing (2)
  • packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte
  • packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte
💤 Files with no reviewable changes (2)
  • packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte
  • packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte
📝 Walkthrough

Walkthrough

Removal of svelte-ignore state_snapshot_uncloneable directives from two Svelte test files. Both files contain $effect blocks that use $state.snapshot(query), with the ignore comments deleted but all functional logic preserved.

Changes

Cohort / File(s) Summary
Svelte Ignore Directive Removal
packages/svelte-query/tests/createInfiniteQuery/BaseExample.svelte, packages/svelte-query/tests/createInfiniteQuery/SelectExample.svelte		 Removed inline svelte-ignore state_snapshot_uncloneable comments from $effect blocks. No functional or control flow changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A comment that whispered, "ignore me, dear friend,"
Has hopped away now—its suppress days at end.
The code's cleaner still, without lint's gentle shush,
Our snapshots snapshot with nary a brush! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing unused svelte-ignore comments from two test files in the svelte-query createInfiniteQuery tests.
Description check ✅ Passed The description includes all required template sections with complete information about changes, testing confirmation, and release impact classification as dev-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/svelte-query-remove-unused-svelte-ignore

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 11, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 60608e3

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 4s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-11 08:22:45 UTC

@sukvvon sukvvon self-assigned this Apr 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 11, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10449

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10449

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10449

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10449

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10449

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10449

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10449

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10449

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10449

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10449

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10449

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10449

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10449

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10449

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10449

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10449

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10449

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10449

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10449

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10449

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10449

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10449

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10449

commit: 60608e3

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

size-limit report 📦

Path Size
react full 11.99 KB (0%)
react minimal 9.02 KB (0%)

@sukvvon sukvvon merged commit 3d95119 into main Apr 11, 2026
10 checks passed
@sukvvon sukvvon deleted the test/svelte-query-remove-unused-svelte-ignore branch April 11, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sukvvon sukvvon

Labels

package: svelte-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon