test(vue-query/mutationOptions): add 'useIsMutating' tests for getter overloads by sukvvon · Pull Request #10469 · TanStack/query

sukvvon · 2026-04-13T01:53:13Z

🎯 Changes

Add 3 runtime tests for mutationOptions getter overloads with useIsMutating:
- should return the number of fetching mutations when used with useIsMutating (getter without mutationKey in mutationOptions)
- should return the number of fetching mutations when used with useIsMutating (getter): multiple mutations with getter
- should return the number of fetching mutations when used with useIsMutating (getter, filter mutationOpts1.mutationKey): filter by mutationKey with getter

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Expanded test coverage for mutation state tracking with getter-based options, including concurrent mutation scenarios.

Note: No user-visible changes in this release.

… overloads

coderabbitai · 2026-04-13T01:53:29Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 514fb799-f4ac-438e-9a53-0399ee2155f5

📥 Commits

Reviewing files that changed from the base of the PR and between 7d3b86c and 04f5e7f.

📒 Files selected for processing (1)

packages/vue-query/src/__tests__/mutationOptions.test.ts

📝 Walkthrough

Walkthrough

Test-only changes adding three new test cases to mutationOptions.test.ts validating useIsMutating behavior when mutationOptions is provided as a getter, covering single mutations, concurrent mutations, and filtered query scenarios.

Changes

Cohort / File(s)	Summary
useIsMutating Getter Tests `packages/vue-query/src/__tests__/mutationOptions.test.ts`	Added three test cases validating `useIsMutating().value` count transitions during mutation in-flight periods with getter-based `mutationOptions`, including scenarios for unfiltered getters, filtered queries, and concurrent mutations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hooray for tests that guard the way,
Where getters dance and counts obey,
From zero to one, then back once more,
Two concurrent tests to even the score!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately describes the main change: adding tests for 'useIsMutating' with getter overloads in mutationOptions.
Description check	✅ Passed	The description is well-structured, follows the template, includes the required sections (Changes, Checklist, Release Impact), clearly lists all three test cases, and properly marks the change as dev-only with no release.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/vue-query-mutationOptions-getter-useIsMutating

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-13T01:53:38Z

View your CI Pipeline Execution ↗ for commit 04f5e7f

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 52s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-13 01:56:08 UTC

github-actions · 2026-04-13T01:54:00Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-13T01:55:11Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10469

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10469

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10469

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10469

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10469

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10469

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10469

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10469

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10469

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10469

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10469

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10469

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10469

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10469

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10469

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10469

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10469

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10469

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10469

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10469

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10469

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10469

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10469

commit: 04f5e7f

github-actions · 2026-04-13T01:55:21Z

size-limit report 📦

Path	Size
react full	11.99 KB (0%)
react minimal	9.02 KB (0%)

test(vue-query/mutationOptions): add 'useIsMutating' tests for getter…

04f5e7f

… overloads

github-actions Bot added the package: vue-query label Apr 13, 2026

sukvvon self-assigned this Apr 13, 2026

sukvvon merged commit 70a216d into main Apr 13, 2026
10 checks passed

sukvvon deleted the test/vue-query-mutationOptions-getter-useIsMutating branch April 13, 2026 01:57

coderabbitai Bot mentioned this pull request Apr 13, 2026

test(vue-query/mutationOptions): add 'queryClient.isMutating' tests for getter overloads #10471

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(vue-query/mutationOptions): add 'useIsMutating' tests for getter overloads#10469

test(vue-query/mutationOptions): add 'useIsMutating' tests for getter overloads#10469
sukvvon merged 1 commit intomainfrom
test/vue-query-mutationOptions-getter-useIsMutating

sukvvon commented Apr 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud Bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

pkg-pr-new Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading

nx-cloud Bot commented Apr 13, 2026 •

edited

Loading