test(vue-query/mutationOptions): add shallow ref test for getter overload by sukvvon · Pull Request #10473 · TanStack/query

sukvvon · 2026-04-13T03:06:06Z

🎯 Changes

Add 1 runtime test for mutationOptions getter overload with shallow: true:
- should return data in a shallow ref when shallow is true (getter): verifies nested data is non-reactive when shallow: true is passed via getter

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added test coverage to verify shallow reference handling in mutation options functionality.

…load

coderabbitai · 2026-04-13T03:06:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d8177964-2611-43e8-8823-6e74643a45b7

📥 Commits

Reviewing files that changed from the base of the PR and between c8de088 and 0700f4c.

📒 Files selected for processing (1)

packages/vue-query/src/__tests__/mutationOptions.test.ts

📝 Walkthrough

Walkthrough

A new test case was added to verify that useMutation correctly wraps mutation data in a shallow ref when shallow: true is provided as a getter form of mutationOptions, ensuring the nested property remains non-reactive.

Changes

Cohort / File(s)	Summary
Shallow Ref Getter Test `packages/vue-query/src/__tests__/mutationOptions.test.ts`	Added test case validating shallow ref behavior when `shallow: true` is passed via getter form of `mutationOptions`. Test confirms mutation data is wrapped shallowly and nested properties are not reactive.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A test so shallow, yet so fine,
Checking refs dance in shallow line,
No nested reactivity here,
Just shallow waters crystal clear! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a shallow ref test for the getter overload of mutationOptions.
Description check	✅ Passed	The PR description follows the template structure, includes clear details about the test added, and properly checks off all applicable checklist items.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/vue-query-mutationOptions-getter-shallow-ref

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-13T03:06:39Z

View your CI Pipeline Execution ↗ for commit 0700f4c

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 24s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-13 03:08:48 UTC

github-actions · 2026-04-13T03:07:10Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-13T03:08:06Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10473

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10473

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10473

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10473

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10473

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10473

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10473

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10473

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10473

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10473

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10473

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10473

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10473

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10473

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10473

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10473

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10473

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10473

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10473

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10473

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10473

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10473

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10473

commit: 0700f4c

github-actions · 2026-04-13T03:08:16Z

size-limit report 📦

Path	Size
react full	11.99 KB (0%)
react minimal	9.02 KB (0%)

test(vue-query/mutationOptions): add shallow ref test for getter over…

0700f4c

…load

github-actions bot added the package: vue-query label Apr 13, 2026

sukvvon merged commit 4c489e4 into main Apr 13, 2026
10 checks passed

sukvvon deleted the test/vue-query-mutationOptions-getter-shallow-ref branch April 13, 2026 03:11

coderabbitai bot mentioned this pull request Apr 13, 2026

test(vue-query/mutationOptions): add reactive 'mutationKey' test for getter overload #10474

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(vue-query/mutationOptions): add shallow ref test for getter overload#10473

test(vue-query/mutationOptions): add shallow ref test for getter overload#10473
sukvvon merged 1 commit intomainfrom
test/vue-query-mutationOptions-getter-shallow-ref

sukvvon commented Apr 13, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 13, 2026

Uh oh!

pkg-pr-new bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 13, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 13, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 13, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 13, 2026 •

edited

Loading

nx-cloud bot commented Apr 13, 2026 •

edited

Loading