test({react,preact}-query): add type tests for 'useMutation'#10482
Merged
test({react,preact}-query): add type tests for 'useMutation'#10482
Conversation
Contributor
📝 WalkthroughWalkthroughAdded two new TypeScript declaration test files that validate compile-time type inference and callback typings for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit eae84f4
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Contributor
size-limit report 📦
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/react-query/src/__tests__/useMutation.test-d.tsx (1)
82-89: Optional cleanup: deduplicateCustomErrortest type.
CustomErroris declared twice; extracting one shared declaration will reduce repetition.♻️ Proposed refactor
describe('useMutation', () => { + class CustomError extends Error { + code: number + constructor(code: number) { + super() + this.code = code + } + } + it('should infer custom TError type', () => { - class CustomError extends Error { - code: number - constructor(code: number) { - super() - this.code = code - } - } - const mutation = useMutation<string, CustomError>({ mutationFn: () => Promise.resolve('data'), }) @@ it('should infer custom TError in onError callback', () => { - class CustomError extends Error { - code: number - constructor(code: number) { - super() - this.code = code - } - } - useMutation<string, CustomError>({ mutationFn: () => Promise.resolve('data'), onError: (error) => {Also applies to: 109-116
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-query/src/__tests__/useMutation.test-d.tsx` around lines 82 - 89, Tests duplicate the CustomError class declaration in two places (lines around the tests starting with "should infer custom TError type"); refactor by extracting a single shared CustomError declaration (class CustomError extends Error { code: number; constructor(code: number) { super(); this.code = code } }) into the shared scope of the test file (e.g., top of the describe or module-level) and remove the duplicated declaration in both test blocks so both tests reuse the same CustomError symbol.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/react-query/src/__tests__/useMutation.test-d.tsx`:
- Around line 82-89: Tests duplicate the CustomError class declaration in two
places (lines around the tests starting with "should infer custom TError type");
refactor by extracting a single shared CustomError declaration (class
CustomError extends Error { code: number; constructor(code: number) { super();
this.code = code } }) into the shared scope of the test file (e.g., top of the
describe or module-level) and remove the duplicated declaration in both test
blocks so both tests reuse the same CustomError symbol.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e9e8ba61-2262-472d-94ad-7e87e4256d52
📒 Files selected for processing (1)
packages/react-query/src/__tests__/useMutation.test-d.tsx
sukvvon
changed the title
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/preact-query/src/__tests__/useMutation.test-d.tsx (1)
83-89: Optional: deduplicateCustomErrorfixture used in two tests.
CustomErroris declared twice (Line 83 and Line 110). Extracting it once atdescribescope reduces duplication/drift.♻️ Proposed refactor
describe('useMutation', () => { + class CustomError extends Error { + code: number + constructor(code: number) { + super() + this.code = code + } + } + it('should infer custom TError type', () => { - class CustomError extends Error { - code: number - constructor(code: number) { - super() - this.code = code - } - } - const mutation = useMutation<string, CustomError>({ mutationFn: () => Promise.resolve('data'), }) @@ it('should infer custom TError in onError callback', () => { - class CustomError extends Error { - code: number - constructor(code: number) { - super() - this.code = code - } - } - useMutation<string, CustomError>({ mutationFn: () => Promise.resolve('data'), onError: (error) => {Also applies to: 110-116
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/preact-query/src/__tests__/useMutation.test-d.tsx` around lines 83 - 89, CustomError is duplicated in two test blocks; hoist the class declaration into the surrounding describe scope so both tests reuse the same fixture: remove the duplicate class at the later location and place a single declaration for class CustomError extends Error { code: number; constructor(code: number) { super(); this.code = code } } at the top of the describe that contains these tests, ensuring both tests reference the same CustomError symbol.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/preact-query/src/__tests__/useMutation.test-d.tsx`:
- Around line 83-89: CustomError is duplicated in two test blocks; hoist the
class declaration into the surrounding describe scope so both tests reuse the
same fixture: remove the duplicate class at the later location and place a
single declaration for class CustomError extends Error { code: number;
constructor(code: number) { super(); this.code = code } } at the top of the
describe that contains these tests, ensuring both tests reference the same
CustomError symbol.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 89f11651-7a93-45bb-872f-9e70c566fd3e
📒 Files selected for processing (1)
packages/preact-query/src/__tests__/useMutation.test-d.tsx
sukvvon
changed the title
sukvvon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
useMutationin bothreact-queryandpreact-query(identical signatures), covering all 4 generic parameters:TData: inference frommutationFnreturn type, explicit genericTError: defaultDefaultError, custom error type,onError/onSettledcallbacksTVariables: inference frommutationFnparameter, defaultvoidTOnMutateResult: inference fromonMutatereturn type,onSuccess/onErrorcallbacksUseMutationResult,mutate,mutateAsyncqueryClientas optional second argument✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit