test(angular-query*): prefix 'it' descriptions with 'should' for consistency#10547
Merged
test(angular-query*): prefix 'it' descriptions with 'should' for consistency#10547
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughTest case descriptions across multiple Angular Query test suites were updated to use consistent "should ..." phrasing conventions. No test logic, assertions, or execution flow was modified—only the human-readable description strings passed to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit a044d0f
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Prefixes
itdescriptions that didn't start withshouldin bothangular-query-experimentalandangular-query-persist-clienttests, matching the BDD convention already followed by the vast majority of tests in this repo.Examples
it('throws NG0203 with descriptive error...')→it('should throw NG0203 with descriptive error...')it('can be used outside injection context...')→it('should be usable outside injection context...')it('Returns number of fetching queries')→it('should return the number of fetching queries')it('reactive options should update mutation')→it('should update mutation when reactive options change')it('supports "in" operator')→it('should support "in" operator')it('allow optional initialData function')→it('should allow optional initialData function')it('restores cache from persister')→it('should restore cache from persister')Scope
Test descriptions where the subject is
TData/data/error(type-level tests) already carryshouldmid-sentence (e.g.'TData should always be defined when initialData is provided as an object'). Those are BDD-valid as-is and intentionally left untouched.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Release Notes