Conversation
…to 'persist' and 'persistance' to 'persistence'
📝 WalkthroughWalkthroughSpelling and capitalization corrections in test case descriptions within the persister test suite. Test titles are updated to fix "persiste" to "persist"/"persistence" and correct capitalization inconsistencies. No test logic or assertions are modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 143aec6
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/query-persist-client-core/src/__tests__/createPersister.test.ts (1)
439-439: Consider aligning capitalization with file convention.These test descriptions use "Should" (capital S), while the rest of the file consistently uses "should" (lowercase). For consistency with the file's existing style, consider changing "Should" to "should" in these descriptions.
📝 Suggested capitalization fixes
- it('Should properly persist basic query', async () => { + it('should properly persist basic query', async () => {- it('Should skip persistence if storage is not provided', async () => { + it('should skip persistence if storage is not provided', async () => {(Apply the same change to line 476 and 503)
Also applies to: 461-461, 476-476, 503-503
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/query-persist-client-core/src/__tests__/createPersister.test.ts` at line 439, Change the test description strings to use lowercase "should" for consistency with the file's convention: update the it(...) calls whose titles currently start with "Should" (e.g., "Should properly persist basic query" and the other two test strings referenced) to start with "should" instead; locate these in the tests for createPersister (the it() blocks) and edit the title strings only so casing matches the rest of the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/query-persist-client-core/src/__tests__/createPersister.test.ts`:
- Line 439: Change the test description strings to use lowercase "should" for
consistency with the file's convention: update the it(...) calls whose titles
currently start with "Should" (e.g., "Should properly persist basic query" and
the other two test strings referenced) to start with "should" instead; locate
these in the tests for createPersister (the it() blocks) and edit the title
strings only so casing matches the rest of the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 27f33200-e0d9-4cdc-9f5d-55a1abab925a
📒 Files selected for processing (1)
packages/query-persist-client-core/src/__tests__/createPersister.test.ts
size-limit report 📦
|
1 participant
🎯 Changes
Fixes typos in
itdescriptions increatePersister.test.ts:'Should properly persiste basic query'→'Should properly persist basic query'(2 occurrences)'Should skip persistance if storage is not provided'→'Should skip persistence if storage is not provided'(2 occurrences)'should skip persistance if query was not found'→'should skip persistence if query was not found'Resolves the
cspell/spellcheckerwarnings that flagged"persiste"as an unknown word and"persistance"as a misspelling of"persistence".✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit