test(angular-query-experimental/injectQueries): add 'readonly' modifier to component fields for consistency with other render-pattern tests by sukvvon · Pull Request #10564 · TanStack/query

sukvvon · 2026-04-23T06:27:46Z

🎯 Changes

Add readonly modifier to injectQueries(...) component fields so the file matches the convention used in the other render-pattern tests (e.g. injectIsFetching, injectIsMutating, injectInfiniteQuery).

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Internal test improvements to enforce immutability on test components.

Note: This release contains no user-facing changes.

…er to component fields for consistency with other render-pattern tests

coderabbitai · 2026-04-23T06:27:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2f12032f-1b8a-450a-9221-1a80163f12f9

📥 Commits

Reviewing files that changed from the base of the PR and between 0f339c1 and 1af9176.

📒 Files selected for processing (1)

packages/angular-query-experimental/src/__tests__/inject-queries.test.ts

📝 Walkthrough

Walkthrough

Test component class members in the inject-queries test file are declared as readonly to prevent reassignment. This change affects only test-local declarations and does not modify public or exported entities.

Changes

Cohort / File(s)	Summary
Test Readonly Properties `packages/angular-query-experimental/src/__tests__/inject-queries.test.ts`	Test component class members (`result`, `combined`, `queries`) marked as `readonly` to enforce immutability at the type level.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A readonly tale!
Properties now stand firm and still,
No reassignment shall they bear,
Type safety guards with steadfast will,
Tests declare what's locked in care! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding readonly modifiers to component fields in the injectQueries test for consistency with other similar tests.
Description check	✅ Passed	The description includes all required template sections with appropriate content: Changes section explains the modification and rationale, Checklist items are completed, and Release Impact correctly indicates this is dev-only with no changeset needed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/angular-query-inject-queries-add-readonly

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-23T06:28:21Z

View your CI Pipeline Execution ↗ for commit 1af9176

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 56s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-23 06:31:45 UTC

github-actions · 2026-04-23T06:28:36Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-23T06:29:26Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10564

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10564

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10564

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10564

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10564

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10564

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10564

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10564

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10564

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10564

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10564

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10564

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10564

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10564

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10564

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10564

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10564

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10564

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10564

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10564

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10564

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10564

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10564

commit: 1af9176

github-actions · 2026-04-23T06:29:35Z

size-limit report 📦

Path	Size
react full	11.99 KB (0%)
react minimal	9.02 KB (0%)

…er to component fields for consistency with other render-pattern tests (TanStack#10564)

test(angular-query-experimental/injectQueries): add 'readonly' modifi…

1af9176

…er to component fields for consistency with other render-pattern tests

github-actions Bot added the package: angular-query-experimental label Apr 23, 2026

sukvvon self-assigned this Apr 23, 2026

sukvvon merged commit 65f9eeb into main Apr 23, 2026
10 checks passed

sukvvon deleted the test/angular-query-inject-queries-add-readonly branch April 23, 2026 06:32

Ephem pushed a commit to Ephem/react-query that referenced this pull request Apr 23, 2026

test(angular-query-experimental/injectQueries): add 'readonly' modifi…

709b526

…er to component fields for consistency with other render-pattern tests (TanStack#10564)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(angular-query-experimental/injectQueries): add 'readonly' modifier to component fields for consistency with other render-pattern tests#10564

test(angular-query-experimental/injectQueries): add 'readonly' modifier to component fields for consistency with other render-pattern tests#10564
sukvvon merged 1 commit intomainfrom
test/angular-query-inject-queries-add-readonly

sukvvon commented Apr 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 23, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

pkg-pr-new Bot commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 23, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 23, 2026 •

edited

Loading

nx-cloud Bot commented Apr 23, 2026 •

edited

Loading