Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-bobcats-remember.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tanstack/eslint-plugin-query": patch
---

Fix `no-unstable-deps` false positives for `useSuspenseQueries` results returned from `combine`.
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,24 @@ const baseTestCases = {
}
`,
},
{
name: `should pass when useSuspenseQueries with combine is passed to ${reactHookAlias} as dependency`,
code: `
${reactHookImport}
import { useSuspenseQueries } from "@tanstack/react-query";

function Component() {
const queries = useSuspenseQueries({
queries: [
{ queryKey: ['test'], queryFn: () => 'test' }
],
combine: (results) => ({ data: results[0]?.data })
});
const callback = ${reactHookInvocation}(() => { queries.data }, [queries]);
return;
}
`,
},
])
.concat([
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,13 @@ export const rule = createRule({
allHookNames.includes(node.init.callee.name) &&
helpers.isTanstackQueryImport(node.init.callee)
) {
// Special case for useQueries with combine property - it's stable
// Special case for useQueries/useSuspenseQueries with combine property - it's stable
if (
node.init.callee.name === 'useQueries' &&
(node.init.callee.name === 'useQueries' ||
node.init.callee.name === 'useSuspenseQueries') &&
hasCombineProperty(node.init)
) {
// Don't track useQueries with combine as unstable
// Don't track useQueries/useSuspenseQueries with combine as unstable
return
}
collectVariableNames(node.id, node.init.callee.name)
Expand Down
Loading