fix(query-devtools): remove experimentalDts to prevent solid-js type leak by TkDodo · Pull Request #10694 · TanStack/query

TkDodo · 2026-05-11T13:51:52Z

Fixes #10421

Supersedes #10442 by @namgi2386 🙏

Summary by CodeRabbit

Bug Fixes
- Fixed TypeScript declaration generation configuration across query-devtools, solid-query-devtools, solid-query-persist-client, and solid-query packages to properly handle type declaration output.

…leak

coderabbitai · 2026-05-11T13:51:59Z

📝 Walkthrough

Walkthrough

This PR removes TypeScript declaration generation customization from tsup configuration files across four packages in the query library ecosystem. Each file removes two lines that were forcing experimentalDts and deleting the dts property, allowing preset-generated declaration settings to apply instead.

Changes

Build Configuration Updates

Layer / File(s)	Summary
Remove experimentalDts and dts deletion from tsup loops `packages/query-devtools/tsup.config.ts`, `packages/solid-query-devtools/tsup.config.ts`, `packages/solid-query-persist-client/tsup.config.ts`, `packages/solid-query/tsup.config.ts`	Per-option loops no longer override `experimentalDts = true` and `delete tsup_option.dts`; declaration configuration now derives from preset-generated values while `outDir = 'build'` assignment continues.
Changeset `.changeset/violet-canyons-love.md`	Adds a changeset entry listing four packages for a patch release and a release note stating `experimentalDts` was removed to avoid Solid.js type leakage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐰 Four configs trimmed with care,
Declaration settings dance in air—
Preset defaults take the stage,
Overrides removed from every page.
The build flows cleaner than before! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete and does not follow the required template structure. Essential sections are entirely missing.	Add the required sections: '## 🎯 Changes' with motivation/description, '## ✅ Checklist' with completed items, and '## 🚀 Release Impact' with changeset confirmation. The linked issue reference alone is insufficient.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main change: removing experimentalDts to prevent a Solid.js type leak, which matches the core objective of the pull request.
Linked Issues check	✅ Passed	The code changes successfully address the linked issue `#10421` by removing experimentalDts and dts customizations across all four tsup.config.ts files, preventing Solid.js type leakage into React devtools consumers.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to the objective: four tsup.config.ts files modified to remove experimentalDts/dts overrides, plus a changeset file documenting the fix, with no out-of-scope alterations present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/remove-expirmentalDts

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-05-11T13:52:23Z

View your CI Pipeline Execution ↗ for commit bd3219b

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	35s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-05-11 14:01:29 UTC

github-actions · 2026-05-11T13:52:37Z

🚀 Changeset Version Preview

4 package(s) bumped directly, 21 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/query-devtools`	5.100.9 → 5.100.10	Changeset
`@tanstack/solid-query`	5.100.9 → 5.100.10	Changeset
`@tanstack/solid-query-devtools`	5.100.9 → 5.100.10	Changeset
`@tanstack/solid-query-persist-client`	5.100.9 → 5.100.10	Changeset
`@tanstack/angular-query-experimental`	5.100.9 → 5.100.10	Dependent
`@tanstack/angular-query-persist-client`	5.100.9 → 5.100.10	Dependent
`@tanstack/eslint-plugin-query`	5.100.9 → 5.100.10	Dependent
`@tanstack/lit-query`	0.2.0 → 0.2.1	Dependent
`@tanstack/preact-query`	5.100.9 → 5.100.10	Dependent
`@tanstack/preact-query-devtools`	5.100.9 → 5.100.10	Dependent
`@tanstack/preact-query-persist-client`	5.100.9 → 5.100.10	Dependent
`@tanstack/query-async-storage-persister`	5.100.9 → 5.100.10	Dependent
`@tanstack/query-broadcast-client-experimental`	5.100.9 → 5.100.10	Dependent
`@tanstack/query-core`	5.100.9 → 5.100.10	Dependent
`@tanstack/query-persist-client-core`	5.100.9 → 5.100.10	Dependent
`@tanstack/query-sync-storage-persister`	5.100.9 → 5.100.10	Dependent
`@tanstack/react-query`	5.100.9 → 5.100.10	Dependent
`@tanstack/react-query-devtools`	5.100.9 → 5.100.10	Dependent
`@tanstack/react-query-next-experimental`	5.100.9 → 5.100.10	Dependent
`@tanstack/react-query-persist-client`	5.100.9 → 5.100.10	Dependent
`@tanstack/svelte-query`	6.1.28 → 6.1.29	Dependent
`@tanstack/svelte-query-devtools`	6.1.28 → 6.1.29	Dependent
`@tanstack/svelte-query-persist-client`	6.1.28 → 6.1.29	Dependent
`@tanstack/vue-query`	5.100.9 → 5.100.10	Dependent
`@tanstack/vue-query-devtools`	6.1.28 → 6.1.29	Dependent

pkg-pr-new · 2026-05-11T13:53:53Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10694

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10694

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@10694

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10694

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10694

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10694

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10694

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10694

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10694

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10694

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10694

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10694

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10694

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10694

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10694

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10694

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10694

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10694

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10694

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10694

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10694

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10694

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10694

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10694

commit: 4490c1a

github-actions · 2026-05-11T13:54:04Z

size-limit report 📦

Path	Size
react full	12.1 KB (0%)
react minimal	9.07 KB (0%)

namgi2386 · 2026-05-11T15:13:51Z

Thank you for picking this up and taking it further!
I'm glad my investigation could be helpful. 🙏

fix(query-devtools): remove experimentalDts to prevent solid-js type …

bd3219b

…leak

github-actions Bot added package: solid-query package: query-devtools package: solid-query-persist-client package: solid-query-devtools labels May 11, 2026

TkDodo marked this pull request as ready for review May 11, 2026 13:57

changeset

4490c1a

TkDodo merged commit 4d130b9 into main May 11, 2026
8 checks passed

TkDodo deleted the feature/remove-expirmentalDts branch May 11, 2026 14:02

github-actions Bot mentioned this pull request May 11, 2026

ci: Version Packages #10695

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(query-devtools): remove experimentalDts to prevent solid-js type leak#10694

fix(query-devtools): remove experimentalDts to prevent solid-js type leak#10694
TkDodo merged 2 commits into
mainfrom
feature/remove-expirmentalDts

TkDodo commented May 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 11, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented May 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 11, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

namgi2386 commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

TkDodo commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

namgi2386 commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TkDodo commented May 11, 2026 •

edited

Loading

coderabbitai Bot commented May 11, 2026 •

edited

Loading

nx-cloud Bot commented May 11, 2026 •

edited

Loading

github-actions Bot commented May 11, 2026 •

edited

Loading

pkg-pr-new Bot commented May 11, 2026 •

edited

Loading

github-actions Bot commented May 11, 2026 •

edited

Loading