Skip to content

test(query-core/queryObserver): split 'shouldFetchOnWindowFocus' test by 'refetchOnWindowFocus' value #10889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 1 commit into from
Jun 5, 2026
+11 −5
Merged

test(query-core/queryObserver): split 'shouldFetchOnWindowFocus' test by 'refetchOnWindowFocus' value #10889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/query-core/src/__tests__/queryObserver.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,22 +1294,28 @@ describe('queryObserver', () => {
unsubscribe()
})

it('shouldFetchOnWindowFocus should respect refetchOnWindowFocus option', () => {
it('shouldFetchOnWindowFocus should return true when refetchOnWindowFocus is true', () => {
const key = queryKey()

const observer1 = new QueryObserver(queryClient, {
const observer = new QueryObserver(queryClient, {
queryKey: key,
queryFn: () => 'data',
refetchOnWindowFocus: true,
})
expect(observer1.shouldFetchOnWindowFocus()).toBe(true)

const observer2 = new QueryObserver(queryClient, {
expect(observer.shouldFetchOnWindowFocus()).toBe(true)
})

it('shouldFetchOnWindowFocus should return false when refetchOnWindowFocus is false', () => {
const key = queryKey()

const observer = new QueryObserver(queryClient, {
queryKey: key,
queryFn: () => 'data',
refetchOnWindowFocus: false,
})
expect(observer2.shouldFetchOnWindowFocus()).toBe(false)

expect(observer.shouldFetchOnWindowFocus()).toBe(false)
})

it('fetchOptimistic should fetch and return optimistic result', async () => {
Expand Down
Loading