test(query-core/queryObserver): add tests for 'refetchOnWindowFocus' as a function in 'shouldFetchOnWindowFocus'#10898
Merged
sukvvon merged 1 commit intoJun 7, 2026
Conversation
Contributor
📝 WalkthroughWalkthroughAdds three tests to QueryObserver.shouldFetchOnWindowFocus() verifying behavior when refetchOnWindowFocus is a function returning true, false, or "always", and that the callback is called with the query cache entry. ChangesWindow focus callback behavior tests
Sequence Diagram(s)sequenceDiagram
participant Test
participant QueryObserver
participant QueryClient
participant QueryCache
Test->>QueryObserver: call shouldFetchOnWindowFocus()
QueryObserver->>QueryClient: getQueryCache()
QueryClient->>QueryCache: find({ queryKey })
QueryCache-->>QueryObserver: query cache entry
QueryObserver-->>Test: boolean decision (true/false)
Possibly related PRs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 2a90a52
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
…as a function in 'shouldFetchOnWindowFocus'
sukvvon
force-pushed
the
test/query-core-query-observer-should-fetch-on-window-focus-function
branch
from
2a90a52 to
e6644a8
Compare
Contributor
size-limit report 📦
|
sukvvon
deleted the
test/query-core-query-observer-should-fetch-on-window-focus-function
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Add tests covering
refetchOnWindowFocusas a function inshouldFetchOnWindowFocus.The existing tests only cover the value forms (
true,false,"always"), which all take the: fieldbranch oftypeof field === "function" ? field(query) : field. These add the function forms so thefield(query)branch is covered.Each function is a
vi.fnand asserts it is called with the query (toHaveBeenCalledWith), so the function-call path and the query argument are both verified:truefalse"always", kept fresh viastaleTime: Infinityso only the"always"path can make ittrue✅ Checklist
pnpm run test:pr.🚀 Release Impact