switching to an affected strategy

[ZackDeRose]

What It Does:

• Switches from using only the cache to not rerun tasks to using nx affected in addition to the cache
  • package scripts have been updated accordingly
  • pr workflow updated to set the --base option for nx affected to the PR's target branch
  • ci workflow updated to set the --base option for nx affected to the commit before the triggering push
  • ci-v3 workflow updated to set the --base option for nx affected to the commit before the triggering push

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 529bc0a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 5 targets

• nx run-many --target=test:build --projects=root
• nx affected --target=test:lib --parallel=5 --base=dbf452e99b30dd8e2c01d944877a47d404ecd04c
• nx affected --target=test:types --parallel=5 --base=dbf452e99b30dd8e2c01d944877a47d404ecd04c
• nx affected --target=test:eslint --parallel=5 --base=dbf452e99b30dd8e2c01d944877a47d404ecd04c
• nx affected --target=test:lib --projects=@tanstack/react-* --base=dbf452e99b30dd8e2c01d944877a47d404ecd04c

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)			Apr 1, 2023 11:43am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 529bc0a:

Sandbox	Source
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

[TkDodo]

I don't think the forwarding of --base works?

> query@ test:lib /home/runner/work/query/query
> nx affected --target=test:lib --parallel=5


 >  NX   Affected criteria defaulted to --base=main --head=HEAD

fatal: ambiguous argument 'main': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
nx.js affected

[ZackDeRose]

I don't think the forwarding of --base works?

> query@ test:lib /home/runner/work/query/query
> nx affected --target=test:lib --parallel=5


 >  NX   Affected criteria defaulted to --base=main --head=HEAD

fatal: ambiguous argument 'main': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
nx.js affected

Yes, something went wrong! lol

pnpm should forward the option - I believe this is actually me not getting the github context stuff correct. Let me see...

[ZackDeRose]

Alright - got the fix now. For the ci workflow, we'll want to make sure to test it.

(The issues with the PR workflow were due to this PR coming in from a fork. After checking out with default options, we were in a detatched head state, so Nx was unable to find the main branch in the linked list of commits, so affected command failed. With pushes to main/alpha/etc., this should be a non-issue since we'll always be inside this repo, never a fork. All the same, don't wanna bring things down!)