Skip to content

Conversation

@LarsJK
Copy link
Contributor

@LarsJK LarsJK commented Oct 19, 2023

TanstackLogo is used twice in devtools.tsx which causes duplicate ids.
Short ids like a could also clash with users own ids.

I noticed this when using Axe devtools top check for accessibility issues on a site. The duplicate logos made 39 "id attribute must be unique" errors.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 9:53am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2b295c7:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@nx-cloud
Copy link

nx-cloud bot commented Oct 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b295c7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

see 81 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ardeora ardeora merged commit 5227246 into TanStack:main Oct 20, 2023
@ardeora
Copy link
Contributor

ardeora commented Oct 20, 2023

This is looking great! And thanks for catching this and making a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants