Skip to content

feat(solid-query): Add useMutationState #6230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

feat(solid-query): Add useMutationState #6230

merged 1 commit into from
Oct 24, 2023

Conversation

@brenelz
Copy link
Contributor

@brenelz brenelz commented Oct 24, 2023 •
edited
Loading

Add useMutationState to solid-query. At lot of the tests and functionality were copied over from React Query

image

@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 4:18am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 24, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 771e53b:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@brenelz brenelz force-pushed the solid-create-mutation-state branch from 0cc8f38 to c5f9797 Compare October 24, 2023 01:16
ardeora
ardeora requested changes Oct 24, 2023
View reviewed changes
@brenelz brenelz force-pushed the solid-create-mutation-state branch from c5f9797 to 132746a Compare October 24, 2023 03:12
@brenelz brenelz changed the title WIP: feat(solid-query): Add createMutationState WIP: feat(solid-query): Add useMutationState Oct 24, 2023
@brenelz brenelz force-pushed the solid-create-mutation-state branch 3 times, most recently from 772c760 to 7992526 Compare October 24, 2023 03:28
@vercel
Copy link

vercel bot commented Oct 24, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

ardeora
ardeora requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ardeora ardeora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Last few tweaks

@ardeora
Copy link
Contributor

ardeora commented Oct 24, 2023

@brenelz Could you also run the formatter? Would just be a pnpm prettier:write from the root directory

@brenelz brenelz force-pushed the solid-create-mutation-state branch from 7992526 to 389b304 Compare October 24, 2023 04:02
@brenelz
Copy link
Contributor Author

brenelz commented Oct 24, 2023

@brenelz Could you also run the formatter? Would just be a pnpm prettier:write from the root directory

updated

ardeora
ardeora requested changes Oct 24, 2023
View reviewed changes
@brenelz brenelz force-pushed the solid-create-mutation-state branch from 389b304 to 771e53b Compare October 24, 2023 04:17
@brenelz brenelz changed the title WIP: feat(solid-query): Add useMutationState feat(solid-query): Add useMutationState Oct 24, 2023
@nx-cloud
Copy link

nx-cloud bot commented Oct 24, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 771e53b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
packages/solid-query/src/useMutationState.ts 88.23% <88.23%> (ø)

... and 69 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ardeora ardeora merged commit ac41f24 into TanStack:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardeora ardeora ardeora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brenelz @ardeora @codecov-commenter