-
-
Couldn't load subscription status.
- Fork 3.5k
refactor(angular-query): remove dependency to ngxtension #6558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(angular-query): remove dependency to ngxtension #6558
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7037d7d:
|
|
Agree, was already my intention to not depend on ngxtension later on but I wanted to get to an API as quickly as possible. Can highly recommend it to be used together with Angular Query though. |
|
Can you take a look at the unit tests? They are failing. You can run all the tests by running |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7037d7d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
I'll take a look probably tomorrow |
packages/angular-query-experimental/src/util/create-injection-token/create-injection-token.ts
Outdated
Show resolved
Hide resolved
…token/create-injection-token.ts Co-authored-by: Garrett Darnell <12160067+garrettld@users.noreply.github.com>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6558 +/- ##
===========================================
+ Coverage 39.15% 80.98% +41.83%
===========================================
Files 161 13 -148
Lines 6600 142 -6458
Branches 1302 21 -1281
===========================================
- Hits 2584 115 -2469
+ Misses 3665 27 -3638
+ Partials 351 0 -351 ☔ View full report in Codecov by Sentry. |
|
@arnoud-dv @garrettld thank you for taking care of the failing test. I'm still on vacation and could not do it. |
To maintain a stable lib I would prefer to maintain such utils on my own, just to reduce external dependencies