Skip to content

Conversation

@michaelbe812
Copy link
Contributor

To maintain a stable lib I would prefer to maintain such utils on my own, just to reduce external dependencies

@vercel
Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2023 2:48am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7037d7d:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@arnoud-dv arnoud-dv self-assigned this Dec 19, 2023
@arnoud-dv
Copy link
Collaborator

Agree, was already my intention to not depend on ngxtension later on but I wanted to get to an API as quickly as possible. Can highly recommend it to be used together with Angular Query though.

@arnoud-dv
Copy link
Collaborator

Can you take a look at the unit tests? They are failing. You can run all the tests by running pnpm test:ci

@nx-cloud
Copy link

nx-cloud bot commented Dec 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7037d7d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@michaelbe812
Copy link
Contributor Author

Can you take a look at the unit tests? They are failing. You can run all the tests by running pnpm test:ci

I'll take a look probably tomorrow

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6ec6ee8) 39.15% compared to head (7037d7d) 80.98%.
Report is 3 commits behind head on main.

Files Patch % Lines
...l/create-injection-token/create-injection-token.ts 78.57% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6558       +/-   ##
===========================================
+ Coverage   39.15%   80.98%   +41.83%     
===========================================
  Files         161       13      -148     
  Lines        6600      142     -6458     
  Branches     1302       21     -1281     
===========================================
- Hits         2584      115     -2469     
+ Misses       3665       27     -3638     
+ Partials      351        0      -351     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arnoud-dv arnoud-dv merged commit d6be91f into TanStack:main Dec 30, 2023
@michaelbe812
Copy link
Contributor Author

@arnoud-dv @garrettld thank you for taking care of the failing test. I'm still on vacation and could not do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants