Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/angular-query-experimental/src/create-base-query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import type { CreateBaseQueryOptions, CreateBaseQueryResult } from './types'

/**
* Base implementation for `injectQuery` and `injectInfiniteQuery`.
* @internal
*/
export function createBaseQuery<
TQueryFnData,
Expand Down Expand Up @@ -60,9 +59,7 @@ export function createBaseQuery<
>(queryClient, defaultedOptionsSignal())

const resultSignal = signal(
observer.getOptimisticResult(
queryClient.defaultQueryOptions(defaultedOptionsSignal()),
),
observer.getOptimisticResult(defaultedOptionsSignal()),
)

effect(
Expand Down
12 changes: 6 additions & 6 deletions packages/angular-query-experimental/src/inject-query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ import type {
UndefinedInitialDataOptions,
} from './query-options'

/**
* Create a Query.
* @param options
* @param injector
*/
export function injectQuery<
TQueryFnData = unknown,
TError = DefaultError,
Expand All @@ -44,7 +39,7 @@ export function injectQuery<
): DefinedCreateQueryResult<TData, TError>

export function injectQuery<
TQueryFnData,
TQueryFnData = unknown,
TError = DefaultError,
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
Expand All @@ -53,6 +48,11 @@ export function injectQuery<
client: QueryClient,
) => CreateQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
injector?: Injector,
): CreateQueryResult<TData, TError>

export function injectQuery(
options: (client: QueryClient) => CreateQueryOptions,
injector?: Injector,
) {
return assertInjector(injectQuery, injector, () => {
const queryClient = injectQueryClient()
Expand Down
10 changes: 7 additions & 3 deletions packages/angular-query-experimental/src/query-options.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { DefaultError, QueryKey } from '@tanstack/query-core'
import type { DataTag, DefaultError, QueryKey } from '@tanstack/query-core'
import type { CreateQueryOptions } from './types'

export type UndefinedInitialDataOptions<
Expand Down Expand Up @@ -30,7 +30,9 @@ export function queryOptions<
TQueryKey extends QueryKey = QueryKey,
>(
options: UndefinedInitialDataOptions<TQueryFnData, TError, TData, TQueryKey>,
): UndefinedInitialDataOptions<TQueryFnData, TError, TData, TQueryKey>
): UndefinedInitialDataOptions<TQueryFnData, TError, TData, TQueryKey> & {
queryKey: DataTag<TQueryKey, TData>
}

export function queryOptions<
TQueryFnData = unknown,
Expand All @@ -39,7 +41,9 @@ export function queryOptions<
TQueryKey extends QueryKey = QueryKey,
>(
options: DefinedInitialDataOptions<TQueryFnData, TError, TData, TQueryKey>,
): DefinedInitialDataOptions<TQueryFnData, TError, TData, TQueryKey>
): DefinedInitialDataOptions<TQueryFnData, TError, TData, TQueryKey> & {
queryKey: DataTag<TQueryKey, TData>
}

export function queryOptions(options: unknown) {
return options
Expand Down
40 changes: 21 additions & 19 deletions packages/angular-query-experimental/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,35 +11,46 @@ import type {
QueryKey,
QueryObserverOptions,
QueryObserverResult,
WithRequired,
} from '@tanstack/query-core'
import type { MapToSignals } from './signal-proxy'

/** Options for createBaseQuery */
export type CreateBaseQueryOptions<
export interface CreateBaseQueryOptions<
TQueryFnData = unknown,
TError = DefaultError,
TData = TQueryFnData,
TQueryData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
> = QueryObserverOptions<TQueryFnData, TError, TData, TQueryData, TQueryKey>
> extends WithRequired<
QueryObserverOptions<TQueryFnData, TError, TData, TQueryData, TQueryKey>,
'queryKey'
> {}

/** Result from createBaseQuery */
export type CreateBaseQueryResult<
TData = unknown,
TError = DefaultError,
State = QueryObserverResult<TData, TError>,
> = MapToSignals<State>
/** Result from createBaseQuery */

/** Options for createQuery */
export type CreateQueryOptions<
export interface CreateQueryOptions<
TQueryFnData = unknown,
TError = DefaultError,
TData = TQueryFnData,
TQueryKey extends QueryKey = QueryKey,
> = CreateBaseQueryOptions<TQueryFnData, TError, TData, TQueryFnData, TQueryKey>
> extends Omit<
WithRequired<
CreateBaseQueryOptions<
TQueryFnData,
TError,
TData,
TQueryFnData,
TQueryKey
>,
'queryKey'
>,
'suspense'
> {}

/** Result from createQuery */
export type CreateQueryResult<
TData = unknown,
TError = DefaultError,
Expand All @@ -62,26 +73,17 @@ export type CreateInfiniteQueryOptions<
TPageParam
>

/** Result from createInfiniteQuery */
export type CreateInfiniteQueryResult<
TData = unknown,
TError = DefaultError,
> = Signal<InfiniteQueryObserverResult<TData, TError>>

/** Options for createBaseQuery with initialData */
export type DefinedCreateBaseQueryResult<
export type DefinedCreateQueryResult<
TData = unknown,
TError = DefaultError,
DefinedQueryObserver = DefinedQueryObserverResult<TData, TError>,
> = MapToSignals<DefinedQueryObserver>

/** Options for createQuery with initialData */
export type DefinedCreateQueryResult<
TData = unknown,
TError = DefaultError,
> = DefinedCreateBaseQueryResult<TData, TError>

/** Options for createMutation */
export type CreateMutationOptions<
TData = unknown,
TError = DefaultError,
Expand Down