Skip to content

test(vue-query): add test and improve typing #8103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 3 commits into from
Oct 1, 2024
Merged

test(vue-query): add test and improve typing #8103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01afc66
test(vue-query): add test for clone getters returning values in queryKey
kickbelldev Sep 26, 2024
5967e9b
fix(vue-query): improve typing in vueQueryPlugin.test.ts to resolve e…
kickbelldev Sep 26, 2024
9ecb6f6
Merge branch 'main' into vue-query/test
TkDodo Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/vue-query/src/__tests__/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,12 @@ describe('utils', () => {
})
})

test('should clone getters returning values in queryKey', () => {
const val = ref({ queryKey: [1, 2, () => '3'] })
const cp = cloneDeepUnref(val)
expect(cp).toStrictEqual({ queryKey: [1, 2, '3'] })
})

test('should unref undefined', () => {
expect(cloneDeepUnref(ref(undefined))).toBe(undefined)
})
Expand Down
10 changes: 6 additions & 4 deletions packages/vue-query/src/__tests__/vueQueryPlugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ vi.mock('../devtools/devtools')
vi.mock('../useQueryClient')
vi.mock('../useBaseQuery')

type UnmountCallback = () => void

interface TestApp extends App {
onUnmount: Function
_unmount: Function
onUnmount: UnmountCallback
_unmount: UnmountCallback
_mixin: ComponentOptions
_provided: Record<string, any>
$root: TestApp
Expand All @@ -29,11 +31,11 @@ function getAppMock(withUnmountHook = false): TestApp {
provide: vi.fn(),
unmount: vi.fn(),
onUnmount: withUnmountHook
? vi.fn((u: Function) => {
? vi.fn((u: UnmountCallback) => {
mock._unmount = u
})
: undefined,
mixin: (m: ComponentOptions): any => {
mixin: (m: ComponentOptions) => {
mock._mixin = m
},
} as unknown as TestApp
Expand Down