Skip to content

fix(angular-query): forward queryFn errors to the NgZone #8842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnoud-dv merged 3 commits into from
Mar 22, 2025
Merged

fix(angular-query): forward queryFn errors to the NgZone #8842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42efd0c
fix(angular-query): forward queryFn errors to the NgZone
JoepKockelkorn Mar 21, 2025
1521b1e
fix(angular-query): forward mutationFn errors to the NgZone
JoepKockelkorn Mar 21, 2025
066cb8f
refactor: remove wrapping try catches
JoepKockelkorn Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/angular-query-experimental/src/create-base-query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export function createBaseQuery<
observer.getCurrentQuery(),
])
) {
ngZone.onError.emit(state.error)
throw state.error
}
resultFromSubscriberSignal.set(state)
Expand Down
1 change: 1 addition & 0 deletions packages/angular-query-experimental/src/inject-mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@
state.error,
])
) {
ngZone.onError.emit(state.error)

Check warning on line 123 in packages/angular-query-experimental/src/inject-mutation.ts

View check run for this annotation

Codecov / codecov/patch

packages/angular-query-experimental/src/inject-mutation.ts#L123 

Added line #L123 was not covered by tests
throw state.error
}

Expand Down
Loading