-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
ci: switch to nxCloudId
#9697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch to nxCloudId
#9697
Conversation
|
WalkthroughUpdates CI configurations: removes explicit parallel flags from PR and release test steps; adjusts dynamic changeset thresholds; and switches Nx Cloud credential from nxCloudAccessToken to nxCloudId. No other workflow steps or control flow changed. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
View your CI Pipeline Execution ↗ for commit 2e63961
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/pr.yml
(1 hunks).github/workflows/release.yml
(1 hunks).nx/workflows/dynamic-changesets.yaml
(1 hunks)nx.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
"$schema": "./node_modules/nx/schemas/nx-schema.json", | ||
"defaultBase": "main", | ||
"nxCloudAccessToken": "ZDdkNDA4MGEtYjNmYi00MWI4LWE1N2QtYTdlNmYxMGJlZWM2fHJlYWQ=", | ||
"nxCloudId": "6412c827e6da5d7b4a0b1fe3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fork PRs will now fail to start Nx agents
Dropping the committed nxCloudAccessToken
means the npx nx-cloud start-ci-run
step no longer has credentials when secrets are unavailable (e.g., PRs from forks). Nx Cloud still requires an access token to open a CI run, so those workflows will now exit with a 401 instead of booting agents. Please keep the hashed access token (safe to commit) or gate the agent steps behind the presence of a token before merging.
🤖 Prompt for AI Agents
In nx.json around line 4, removing the committed nxCloudAccessToken causes fork
PRs to fail when secrets are unavailable; restore the hashed nxCloudAccessToken
value in nx.json (it’s safe to commit) or modify CI to gate the npx nx-cloud
start-ci-run/agent steps behind a runtime check for an access token (e.g., only
run those steps if NX_CLOUD_ACCESS_TOKEN or the nxCloudAccessToken field is
present), so CI doesn’t attempt to open a run and error 401 when tokens are
missing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9697 +/- ##
=======================================
Coverage 46.38% 46.38%
=======================================
Files 214 214
Lines 8488 8488
Branches 1930 1923 -7
=======================================
Hits 3937 3937
Misses 4108 4108
Partials 443 443 🚀 New features to boost your workflow:
|
🎯 Changes
No longer need to use
nxCloudAccessToken
for read access.✅ Checklist
pnpm test:pr
.🚀 Release Impact
Summary by CodeRabbit