Skip to content

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Sep 27, 2025

🎯 Changes

No longer need to use nxCloudAccessToken for read access.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Simplified CI test execution by removing explicit parallelism in PR and release pipelines, aligning resource usage and stability.
    • Tuned automated change classification thresholds so medium and large releases are identified with smaller change counts, enabling more frequent versioning.
    • Updated build cloud configuration to the latest credential identifier for improved compatibility and security posture.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2025

⚠️ No Changeset found

Latest commit: 2e63961

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 27, 2025

Walkthrough

Updates CI configurations: removes explicit parallel flags from PR and release test steps; adjusts dynamic changeset thresholds; and switches Nx Cloud credential from nxCloudAccessToken to nxCloudId. No other workflow steps or control flow changed.

Changes

Cohort / File(s) Summary
GitHub Workflows
.github/workflows/pr.yml, .github/workflows/release.yml
Test commands updated: dropped --parallel=3 from pnpm run test:pr and pnpm run test:ci. No other step modifications.
Nx Cloud Config
nx.json
Replaced nxCloudAccessToken with nxCloudId. No other structural changes.
Dynamic Changesets
.nx/workflows/dynamic-changesets.yaml
Lowered thresholds: medium from 6→4, large from 10→5.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paws on CI ground,
Fewer flags, same tests resound.
Nx cloud key swaps—quick and neat,
Changeset scales step back a beat.
Pipelines hum, carrots queued,
Green lights glow—deploys renewed. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the core CI change—switching to nxCloudId—and uses a clear conventional commit prefix without extraneous details, making it easy for reviewers to understand the main change at a glance.
Description Check ✅ Passed The pull request description uses the required template and includes all mandatory sections: it clearly states the change under “🎯 Changes,” completes the checklist, and specifies the release impact, so reviewers have the needed context and confirmation of local testing and contributing guide compliance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nx-cloud-id

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Sep 27, 2025

View your CI Pipeline Execution ↗ for commit 2e63961

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 55s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-27 02:50:19 UTC

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93a9d71 and 2e63961.

📒 Files selected for processing (4)
  • .github/workflows/pr.yml (1 hunks)
  • .github/workflows/release.yml (1 hunks)
  • .nx/workflows/dynamic-changesets.yaml (1 hunks)
  • nx.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test
  • GitHub Check: Preview

"$schema": "./node_modules/nx/schemas/nx-schema.json",
"defaultBase": "main",
"nxCloudAccessToken": "ZDdkNDA4MGEtYjNmYi00MWI4LWE1N2QtYTdlNmYxMGJlZWM2fHJlYWQ=",
"nxCloudId": "6412c827e6da5d7b4a0b1fe3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fork PRs will now fail to start Nx agents

Dropping the committed nxCloudAccessToken means the npx nx-cloud start-ci-run step no longer has credentials when secrets are unavailable (e.g., PRs from forks). Nx Cloud still requires an access token to open a CI run, so those workflows will now exit with a 401 instead of booting agents. Please keep the hashed access token (safe to commit) or gate the agent steps behind the presence of a token before merging.

🤖 Prompt for AI Agents
In nx.json around line 4, removing the committed nxCloudAccessToken causes fork
PRs to fail when secrets are unavailable; restore the hashed nxCloudAccessToken
value in nx.json (it’s safe to commit) or modify CI to gate the npx nx-cloud
start-ci-run/agent steps behind a runtime check for an access token (e.g., only
run those steps if NX_CLOUD_ACCESS_TOKEN or the nxCloudAccessToken field is
present), so CI doesn’t attempt to open a run and error 401 when tokens are
missing.

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.38%. Comparing base (93a9d71) to head (2e63961).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9697   +/-   ##
=======================================
  Coverage   46.38%   46.38%           
=======================================
  Files         214      214           
  Lines        8488     8488           
  Branches     1930     1923    -7     
=======================================
  Hits         3937     3937           
  Misses       4108     4108           
  Partials      443      443           
Components Coverage Δ
@tanstack/angular-query-experimental 93.85% <ø> (ø)
@tanstack/eslint-plugin-query 83.24% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 97.48% <ø> (ø)
@tanstack/query-devtools 3.48% <ø> (ø)
@tanstack/query-persist-client-core 79.60% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils 77.77% <ø> (ø)
@tanstack/react-query 96.00% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.06% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.58% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lachlancollins lachlancollins merged commit 130382a into main Sep 27, 2025
7 of 8 checks passed
@lachlancollins lachlancollins deleted the nx-cloud-id branch September 27, 2025 02:50
Hellol77 pushed a commit to Hellol77/query that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant