Skip to content

ci: switch to nxCloudId #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2025
Merged

ci: switch to nxCloudId #9697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
with:
main-branch-name: main
- name: Run Checks
run: pnpm run test:pr --parallel=3
run: pnpm run test:pr
- name: Verify Links
run: pnpm run verify-links
- name: Stop Nx Agents
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Setup Tools
uses: tanstack/config/.github/setup@main
- name: Run Tests
run: pnpm run test:ci --parallel=3
run: pnpm run test:ci
- name: Stop Nx Agents
if: ${{ always() }}
run: npx nx-cloud stop-all-agents
Expand Down
4 changes: 2 additions & 2 deletions .nx/workflows/dynamic-changesets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
distribute-on:
small-changeset: 3 linux-medium-js
medium-changeset: 6 linux-medium-js
large-changeset: 10 linux-medium-js
medium-changeset: 4 linux-medium-js
large-changeset: 5 linux-medium-js
2 changes: 1 addition & 1 deletion nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"defaultBase": "main",
"nxCloudAccessToken": "ZDdkNDA4MGEtYjNmYi00MWI4LWE1N2QtYTdlNmYxMGJlZWM2fHJlYWQ=",
"nxCloudId": "6412c827e6da5d7b4a0b1fe3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fork PRs will now fail to start Nx agents

Dropping the committed nxCloudAccessToken means the npx nx-cloud start-ci-run step no longer has credentials when secrets are unavailable (e.g., PRs from forks). Nx Cloud still requires an access token to open a CI run, so those workflows will now exit with a 401 instead of booting agents. Please keep the hashed access token (safe to commit) or gate the agent steps behind the presence of a token before merging.

🤖 Prompt for AI Agents 
In nx.json around line 4, removing the committed nxCloudAccessToken causes fork
PRs to fail when secrets are unavailable; restore the hashed nxCloudAccessToken
value in nx.json (it’s safe to commit) or modify CI to gate the npx nx-cloud
start-ci-run/agent steps behind a runtime check for an access token (e.g., only
run those steps if NX_CLOUD_ACCESS_TOKEN or the nxCloudAccessToken field is
present), so CI doesn’t attempt to open a run and error 401 when tokens are
missing.

"useInferencePlugins": false,
"parallel": 5,
"namedInputs": {
Expand Down
Loading