Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/autofix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v5.0.0
uses: actions/checkout@v5.0.1
with:
fetch-depth: 0
- name: Setup Tools
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v5.0.0
uses: actions/checkout@v5.0.1
with:
fetch-depth: 0
- name: Start Nx Agents
run: npx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yaml"
- name: Setup Tools
uses: tanstack/config/.github/setup@main
- name: Get base and head commits for `nx affected`
uses: nrwl/nx-set-shas@v4.3.3
uses: nrwl/nx-set-shas@v4.4.0
with:
main-branch-name: main
- name: Run Checks
Expand All @@ -49,7 +49,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v5.0.0
uses: actions/checkout@v5.0.1
with:
fetch-depth: 0
- name: Setup Tools
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v5.0.0
uses: actions/checkout@v5.0.1
with:
fetch-depth: 0
- name: Check Provenance
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v5.0.0
uses: actions/checkout@v5.0.1
with:
fetch-depth: 0
- name: Start Nx Agents
Expand Down
14 changes: 7 additions & 7 deletions examples/angular/auto-refetching/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
"private": true,
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
14 changes: 7 additions & 7 deletions examples/angular/basic-persister/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@
"private": true,
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"@tanstack/angular-query-persist-client": "^5.62.18",
"@tanstack/query-async-storage-persister": "^5.90.13",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
14 changes: 7 additions & 7 deletions examples/angular/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
"private": true,
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
16 changes: 8 additions & 8 deletions examples/angular/devtools-panel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@
"private": true,
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/router": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@angular/router": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
14 changes: 7 additions & 7 deletions examples/angular/infinite-query-with-max-pages/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
},
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
16 changes: 8 additions & 8 deletions examples/angular/optimistic-updates/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@
"private": true,
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/forms": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/forms": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Revert zone.js to 0.15.0 — incompatible with Angular 20.3.14.

Line 20 updates zone.js from 0.15.0 to 0.16.0, but earlier reviews of this PR established that Angular 20.3.x (including 20.3.14) requires zone.js ~0.15.x. Zone.js 0.16.0 is not officially supported by Angular 20 and causes installation/build failures. This is the same critical issue flagged for examples/angular/basic-persister and examples/angular/devtools-panel in this PR — it appears to be a systematic problem across all Angular examples receiving this dependency update.

Apply this fix:

-    "zone.js": "0.16.0"
+    "zone.js": "0.15.0"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"zone.js": "0.16.0"
"zone.js": "0.15.0"
🤖 Prompt for AI Agents
In examples/angular/optimistic-updates/package.json around line 20, the zone.js
version was bumped to 0.16.0 which is incompatible with Angular 20.3.x; change
the dependency back to the supported 0.15.x range (e.g. "zone.js": "0.15.0" or
"zone.js": "~0.15.0") so the example matches Angular 20.3.14's required zone.js
and avoids install/build failures.

},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
14 changes: 7 additions & 7 deletions examples/angular/pagination/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
},
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Revert zone.js to 0.15.0 — incompatible with Angular 20.3.13 (same issue across all Angular examples).

Zone.js 0.16.0 is incompatible with Angular 20.3.13 and will break change detection. This same critical issue appears in other Angular examples in this PR (basic-persister, router). Revert to 0.15.0.

-    "zone.js": "0.16.0"
+    "zone.js": "0.15.0"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"zone.js": "0.16.0"
"zone.js": "0.15.0"
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around line 19, the dependency
"zone.js" is set to "0.16.0" which is incompatible with Angular 20.3.13; change
the version string to "0.15.0" to restore compatibility across Angular examples
(also check and align other Angular example package.json files such as
basic-persister and router to the same "0.15.0" value).

},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
16 changes: 8 additions & 8 deletions examples/angular/query-options-from-a-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@
"private": true,
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/router": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@angular/router": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
16 changes: 8 additions & 8 deletions examples/angular/router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@
"private": true,
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/router": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@angular/router": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

CRITICAL: zone.js 0.16.0 incompatibility with Angular 20.3.13 (flagged in previous review).

This file was previously reviewed and flagged for incompatibility between zone.js 0.16.0 and Angular 20.3.13. The issue remains unresolved. Angular 20.3.13 requires zone.js 0.15.x; upgrading to 0.16.0 will break Angular's change detection and cause runtime/test failures. Revert to zone.js 0.15.x.

-    "zone.js": "0.16.0"
+    "zone.js": "~0.15.0"

Also applies to: 20-20

🤖 Prompt for AI Agents
In examples/angular/router/package.json around line 20, zone.js is pinned to
0.16.0 which is incompatible with Angular 20.3.13; revert the dependency to a
0.15.x release (e.g., "zone.js": "0.15.x") to restore compatibility, update
package-lock/yarn lock by reinstalling dependencies, and run the test/build to
verify no runtime/change-detection regressions.

},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
16 changes: 8 additions & 8 deletions examples/angular/rxjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@
},
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/forms": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/forms": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
14 changes: 7 additions & 7 deletions examples/angular/simple/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@
"private": true,
"dependencies": {
"@angular/common": "^20.0.0",
"@angular/compiler": "^20.0.0",
"@angular/core": "^20.0.0",
"@angular/platform-browser": "^20.0.0",
"@angular/compiler": "^20.3.14",
"@angular/core": "^20.3.14",
"@angular/platform-browser": "^20.3.14",
"@tanstack/angular-query-experimental": "^5.90.15",
"rxjs": "^7.8.2",
"tslib": "^2.8.1",
"zone.js": "0.15.0"
"zone.js": "0.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Align zone.js version specifier to allow patch updates.

zone.js is pinned to exact version "0.16.0", but should use tilde range "~0.16.0" to allow patch-level updates for bug fixes and security improvements. This aligns with Angular's peer dependency conventions.

Apply this diff:

-    "zone.js": "0.16.0"
+    "zone.js": "~0.16.0"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"zone.js": "0.16.0"
"zone.js": "~0.16.0"
🤖 Prompt for AI Agents
In examples/angular/simple/package.json around line 19, zone.js is pinned to an
exact version "0.16.0"; change the version specifier to a tilde range "~0.16.0"
so patch-level updates are allowed. Edit the dependency entry to replace the
exact version with the tilde-prefixed range, save the file, and run npm install
(or update lockfile) to ensure the dependency range is reflected in
package-lock.json/yarn.lock.

},
"devDependencies": {
"@angular/build": "^20.0.0",
"@angular/cli": "^20.0.0",
"@angular/compiler-cli": "^20.0.0",
"@angular/build": "^20.3.12",
"@angular/cli": "^20.3.12",
"@angular/compiler-cli": "^20.3.14",
"typescript": "5.8.3"
}
}
4 changes: 2 additions & 2 deletions examples/react/algolia/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"preview": "vite preview"
},
"dependencies": {
"@algolia/client-search": "5.2.1",
"@algolia/client-search": "5.45.0",
"@tanstack/react-query": "^5.90.11",
"@tanstack/react-query-devtools": "^5.91.1",
"react": "^19.0.0",
Expand All @@ -18,7 +18,7 @@
"@tanstack/eslint-plugin-query": "^5.91.2",
"@types/react": "^18.2.79",
"@types/react-dom": "^18.2.25",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"typescript": "5.8.3",
"vite": "^6.3.6"
}
Expand Down
6 changes: 3 additions & 3 deletions examples/react/basic-graphql-request/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
"dependencies": {
"@tanstack/react-query": "^5.90.11",
"@tanstack/react-query-devtools": "^5.91.1",
"graphql": "^16.9.0",
"graphql-request": "^7.1.2",
"graphql": "^16.12.0",
"graphql-request": "^7.3.5",
"react": "^19.0.0",
"react-dom": "^19.0.0"
},
"devDependencies": {
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"vite": "^6.3.6"
}
}
2 changes: 1 addition & 1 deletion examples/react/basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@tanstack/eslint-plugin-query": "^5.91.2",
"@types/react": "^18.2.79",
"@types/react-dom": "^18.2.25",
"@vitejs/plugin-react": "^4.3.4",
"@vitejs/plugin-react": "^4.7.0",
"typescript": "5.8.3",
"vite": "^6.3.6"
},
Expand Down
Loading
Loading