Skip to content

test(react-query-persist-client/PersistQueryClientProvider): replace 'await sleep' with 'sleep().then()' pattern in restoreClient and add additional timer advance for refetch verification #9901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

test(react-query-persist-client/PersistQueryClientProvider): replace 'await sleep' with 'sleep().then()' pattern in restoreClient and add additional timer advance for refetch verification #9901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ const createMockErrorPersister = (
// noop
},
async restoreClient() {
await sleep(10)
throw error
return sleep(10).then(() => {
throw error
})
Comment on lines -44 to +46
Copy link
Collaborator

@TkDodo TkDodo Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question: why? are there any functional difference ?

Copy link
Contributor Author

@sukvvon sukvvon Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TkDodo If we apply the pattern from #9900 (comment), we could write it like this:

return sleep(10).then(() => Promise.reject(error))

What do you think about this approach?

},
removeClient,
},
Expand Down Expand Up @@ -415,6 +416,8 @@ describe('PersistQueryClientProvider', () => {
expect(rendered.getByText('data: null')).toBeInTheDocument()
await act(() => vi.advanceTimersByTimeAsync(10))
expect(rendered.getByText('data: hydrated')).toBeInTheDocument()
await act(() => vi.advanceTimersByTimeAsync(11))
expect(rendered.getByText('data: hydrated')).toBeInTheDocument()

expect(states).toHaveLength(2)

Expand Down
Loading