Skip to content

docs(redact/server): correct fallback wire-format comment — fallback '<div>' is visible, not hidden#13

Open
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:docs/server-fix-bootstrap-wire-format-comment
Open

docs(redact/server): correct fallback wire-format comment — fallback '<div>' is visible, not hidden#13
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:docs/server-fix-bootstrap-wire-format-comment

Conversation

@sukvvon
Copy link
Copy Markdown

@sukvvon sukvvon commented May 9, 2026

Summary

  • Comment vs. emit drift: bootstrap-script.ts's wire-format block comment claimed <!--$?ID--><div hidden id="B:ID">fallback</div><!--/$-->, but the actual emit at walk.ts:441 writes <div id="B:ID"> (no hidden). The adjacent comment at walk.ts:438 already states "Visible div wrapper so the fallback UI shows".
  • Why visible is correct: the B: div wraps the user-visible loading state. Hiding it would defeat the purpose of streaming SSR fallbacks. Only the S: resolved-content staging div is hidden, so $RC(ID) can splice its children into place before the B: div is removed.
  • Doc-only: comment text only; no behavior change.

Test plan

  • grep <div .* id="B: repo-wide — only walk.ts:441 emits, and it has no hidden
  • cross-checked against the runtime: $RC (bootstrap-script.ts:30-39) and hydrateSuspenseBoundary (suspense/full.ts:141-148) both assume a visible B: container
  • pnpm test:types — clean

@sukvvon sukvvon force-pushed the docs/server-fix-bootstrap-wire-format-comment branch from b4d708e to c2a747c Compare May 9, 2026 15:01
@sukvvon sukvvon changed the title docs(server): correct fallback wire-format comment — fallback <div> is visible, not hidden docs(redact/server): correct fallback wire-format comment — fallback <div> is visible, not hidden May 9, 2026
@sukvvon sukvvon force-pushed the docs/server-fix-bootstrap-wire-format-comment branch from c2a747c to 3d20663 Compare May 9, 2026 15:07
@sukvvon sukvvon changed the title docs(redact/server): correct fallback wire-format comment — fallback <div> is visible, not hidden docs(redact/server): correct fallback wire-format comment — fallback '<div>' is visible, not hidden May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant