docs(redact/server): correct fallback wire-format comment — fallback '<div>' is visible, not hidden#13
Open
sukvvon wants to merge 1 commit intoTanStack:mainfrom
Conversation
b4d708e to
c2a747c
Compare
<div> is visible, not hidden<div> is visible, not hidden
…'<div>' is visible, not hidden
c2a747c to
3d20663
Compare
<div> is visible, not hidden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bootstrap-script.ts's wire-format block comment claimed<!--$?ID--><div hidden id="B:ID">fallback</div><!--/$-->, but the actual emit atwalk.ts:441writes<div id="B:ID">(nohidden). The adjacent comment atwalk.ts:438already states "Visible div wrapper so the fallback UI shows".B:div wraps the user-visible loading state. Hiding it would defeat the purpose of streaming SSR fallbacks. Only theS:resolved-content staging div ishidden, so$RC(ID)can splice its children into place before theB:div is removed.Test plan
<div .* id="B:repo-wide — onlywalk.ts:441emits, and it has nohidden$RC(bootstrap-script.ts:30-39) andhydrateSuspenseBoundary(suspense/full.ts:141-148) both assume a visibleB:containerpnpm test:types— clean