Skip to content

fix: deps#5195

Merged
schiller-manuel merged 1 commit intomainfrom
fix-deps
Sep 23, 2025
Merged

fix: deps#5195
schiller-manuel merged 1 commit intomainfrom
fix-deps

Conversation

@schiller-manuel
Copy link
Contributor

@schiller-manuel schiller-manuel commented Sep 23, 2025

Summary by CodeRabbit

  • Chores
    • Streamlined client packages by removing an unused dependency, reducing install size.
    • Updated a routing-related dependency to the latest major version with no user-facing changes.
    • Moved select packages to development-only dependencies in server core to minimize production footprint.
    • Overall: no functional or runtime behavior changes expected; improvements focus on dependency hygiene and leaner installations.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 23, 2025

Walkthrough

Dependencies adjusted across packages: cookie-es removed from multiple client/core packages, upgraded to ^2.0.0 in router-core, and shifted (with two others) from dependencies to devDependencies in start-server-core. No source code changes or public API modifications are indicated.

Changes

Cohort / File(s) Summary of Changes
Client packages: remove cookie-es
packages/react-start-client/package.json, packages/solid-start-client/package.json, packages/start-client-core/package.json
Deleted dependency cookie-es (was ^1.2.2 where specified). No other dependency or config edits.
Router core: upgrade cookie-es
packages/router-core/package.json
Upgraded cookie-es from ^1.2.2 to ^2.0.0.
Server core: move deps to dev
packages/start-server-core/package.json
Moved @standard-schema/spec, cookie-es, and fetchdts from dependencies to devDependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled through deps with gentle care,
Plucked cookie crumbs from client air,
The router gets a fresher bite,
The server stows its tools at night.
Hop hop—versions neat and lean,
Gardens of builds, now crisp and clean. 🐇🍪

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix: deps" is short and directly related to the changeset, which modifies dependencies across multiple packages (removals, a devDependency move, and an upgrade). It communicates that the PR addresses dependency fixes rather than behavioral or API changes. The title is terse and could be more descriptive, but it is not misleading about the PR's intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-deps

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70d2989 and 67c5804.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/react-start-client/package.json (0 hunks)
  • packages/router-core/package.json (1 hunks)
  • packages/solid-start-client/package.json (0 hunks)
  • packages/start-client-core/package.json (0 hunks)
  • packages/start-server-core/package.json (1 hunks)
💤 Files with no reviewable changes (3)
  • packages/start-client-core/package.json
  • packages/react-start-client/package.json
  • packages/solid-start-client/package.json
🧰 Additional context used
📓 Path-based instructions (3)
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Use workspace:* protocol for internal dependencies in package.json files

Files:

  • packages/start-server-core/package.json
  • packages/router-core/package.json
packages/{*-start,start-*}/**

📄 CodeRabbit inference engine (AGENTS.md)

Name and place Start framework packages under packages/-start/ or packages/start-/

Files:

  • packages/start-server-core/package.json
packages/router-core/**

📄 CodeRabbit inference engine (AGENTS.md)

Keep framework-agnostic core router logic in packages/router-core/

Files:

  • packages/router-core/package.json
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: TanStack/router#0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.589Z
Learning: Applies to packages/router-core/** : Keep framework-agnostic core router logic in packages/router-core/
Learnt from: CR
PR: TanStack/router#0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.589Z
Learning: Applies to packages/{router-devtools,*-router-devtools}/** : Keep router devtools packages in packages/router-devtools/ and packages/*-router-devtools/
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Preview
  • GitHub Check: Test
🔇 Additional comments (2)
packages/start-server-core/package.json (1)

68-73: OK to keep in devDependencies — imports are type-only

All three packages are imported with import type and only used in type positions: packages/start-server-core/src/request-response.ts (fetchdts, cookie-es, @standard-schema/spec) and packages/start-server-core/src/session.ts (cookie-es).

packages/router-core/package.json (1)

84-84: cookie-es ^2.0.0 is ESM-only — confirm CJS entrypoints & Node engine compatibility

  • cookie-es v2 is ESM-only (no CJS). It’s declared in packages/router-core/package.json and packages/start-server-core/package.json; repo search shows no source imports (only package.json entries).
  • router-core publishes a CJS entrypoint (exports.require -> ./dist/cjs/index.cjs). Ensure the CJS build bundles cookie-es or provides a CJS-compatible fallback; otherwise CJS consumers will fail at require-time. (packages/router-core/package.json)
  • Align engines: router-core currently targets "node": ">=12" — raise to a Node with stable ESM support (>=14; prefer >=16/18 per your support policy) if you keep cookie-es@2, or pin cookie-es to v1.
  • Confirm no stray cookie-es ^1.x remains (search found none).

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Sep 23, 2025

View your CI Pipeline Execution ↗ for commit 67c5804

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 4m 23s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-23 22:33:16 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 23, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5195

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5195

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5195

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5195

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5195

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5195

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5195

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5195

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5195

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5195

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5195

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5195

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5195

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5195

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5195

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5195

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5195

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5195

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5195

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5195

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5195

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5195

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5195

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5195

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5195

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5195

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5195

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5195

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5195

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5195

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5195

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5195

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5195

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5195

commit: 67c5804

@schiller-manuel schiller-manuel merged commit bd55576 into main Sep 23, 2025
6 checks passed
@schiller-manuel schiller-manuel deleted the fix-deps branch September 23, 2025 22:33
naoya7076 pushed a commit to naoya7076/router that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant