Conversation
|
View your CI Pipeline Execution ↗ for commit 4680d80
☁️ Nx Cloud last updated this comment at |
Contributor
📝 WalkthroughWalkthroughThe change consolidates match state selection in Match.tsx by computing matchIndex via findIndex and deriving both match and additional fields (resetKey, parentRouteId) from a single consolidated matchState selector, replacing previous linear search and separate selectors. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
naoya7076
pushed a commit
to naoya7076/router
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
<Match>component, we need bothFor both, we need to iterate the matches array. We can do this in a single iteration, and reduce the use of
useRouterStatefrom 3 calls to 1.before

after

Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.