Skip to content

test: fix vue viewTransition e2e flakiness#6830

Merged
Sheraff merged 2 commits intomainfrom
test-vue-transition-fix-flakiness
Mar 5, 2026
Merged

test: fix vue viewTransition e2e flakiness#6830
Sheraff merged 2 commits intomainfrom
test-vue-transition-fix-flakiness

Conversation

@Sheraff
Copy link
Contributor

@Sheraff Sheraff commented Mar 5, 2026

Summary by CodeRabbit

  • Tests
    • Improved reliability of end-to-end view transition tests by switching to polling-based assertions; reduces flakiness and better captures asynchronous UI behavior during transitions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f6ea0798-8b13-4d51-a3dc-a2cf6ed0ff22

📥 Commits

Reviewing files that changed from the base of the PR and between 117c1e5 and 19c6608.

📒 Files selected for processing (1)
  • e2e/vue-router/view-transitions/tests/view-transitions.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • e2e/vue-router/view-transitions/tests/view-transitions.spec.ts

📝 Walkthrough

Walkthrough

A test in the view-transitions spec was changed to use polling-based assertion (expect.poll) that waits for window.__viewTransitionCalls to become non-empty instead of performing an immediate synchronous check.

Changes

Cohort / File(s) Summary
Test Assertion Enhancement
e2e/vue-router/view-transitions/tests/view-transitions.spec.ts
Replaced synchronous checks of __viewTransitionCalls with expect.poll to wait until the array is populated, making the test tolerant of asynchronous timing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I waited patiently, paw on the clock,

Polling the garden, tick by tick-tock,
The array filled slowly, a hop then a cheer,
View transitions appeared — now the path is clear! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'test: fix vue viewTransition e2e flakiness' clearly and specifically describes the main change: fixing flaky e2e tests for Vue view transitions by replacing immediate assertions with polling-based assertions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test-vue-transition-fix-flakiness

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 5, 2026

View your CI Pipeline Execution ↗ for commit 19c6608

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 27s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-05 23:03:49 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 5, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6830

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6830

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6830

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6830

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6830

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6830

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6830

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6830

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6830

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6830

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6830

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6830

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6830

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6830

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6830

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6830

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6830

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6830

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6830

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6830

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6830

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6830

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6830

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6830

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6830

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6830

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6830

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6830

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6830

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6830

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6830

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6830

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6830

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6830

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6830

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6830

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6830

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6830

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6830

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6830

commit: 78bf061

@Sheraff Sheraff merged commit cc12980 into main Mar 5, 2026
1 check passed
@Sheraff Sheraff deleted the test-vue-transition-fix-flakiness branch March 5, 2026 23:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Bundle Size Benchmarks

  • Commit: 64dee75088e3
  • Measured at: 2026-03-05T23:04:28.182Z
  • Baseline source: history:64dee75088e3
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 86.84 KiB 0 B (0.00%) 273.33 KiB 75.44 KiB ▁▁▁▁▁▁▁▁▁██
react-router.full 89.88 KiB 0 B (0.00%) 283.67 KiB 78.18 KiB ▁▁▁▁▁▁▁▁▁██
solid-router.minimal 36.17 KiB 0 B (0.00%) 108.44 KiB 32.49 KiB ▁▁▁▁▁▁▁▁▁██
solid-router.full 40.50 KiB 0 B (0.00%) 121.49 KiB 36.40 KiB ▁▁▁▁▁▁▁▁▁██
vue-router.minimal 52.03 KiB 0 B (0.00%) 148.42 KiB 46.71 KiB ▁▁▁▁▁▁▁▁▁██
vue-router.full 56.85 KiB 0 B (0.00%) 164.01 KiB 51.04 KiB ▁▁▁▁▁▁▁▁▁██
react-start.minimal 99.40 KiB 0 B (0.00%) 312.48 KiB 85.98 KiB ▁▁▁▁▁▁▁▁▁██
react-start.full 102.78 KiB 0 B (0.00%) 322.29 KiB 88.82 KiB ▁▁▁▁▁▁▁▁▁██
solid-start.minimal 48.49 KiB 0 B (0.00%) 146.03 KiB 42.85 KiB ▁▁▁▁▁▁▁▁▁██
solid-start.full 53.96 KiB 0 B (0.00%) 161.98 KiB 47.51 KiB ▁▁▁▁▁▁▁▁▁██

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 5, 2026

Merging this PR will not alter performance

✅ 5 untouched benchmarks


Comparing test-vue-transition-fix-flakiness (117c1e5) with main (64dee75)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant