-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs(examples): update the vinxi-basic-ssr-streaming example to reflect the TanStack website #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Now that Tanstack.com is using TSR in production, do you mind updating your PR here? |
Sure I'll get to it once I get a chance |
|
Done now @SeanCassiere |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 078a61a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
With CI failing, need to figure out what's causing this. |
|
Looks to be conflicting |
|
#1467 should resolve these CI errors. Once merged in, you should be able to rebase and have CI pass. |
|
@alessandrojcm When you have some time, could you update the PR and rebase with main? The changes from #1467 should allow for the higher version of vinxi that the example was using (that required a higher vite and vitest version from our end). |
Done now |
|
@alessandrojcm thank you! 🚀 |
Hey, I am playing around with vinxi and realized that the example in this repo was not working so I updated it following up with the TanStack website migration. Let me know if anything is wrong.