Skip to content

Conversation

@alessandrojcm
Copy link
Contributor

Hey, I am playing around with vinxi and realized that the example in this repo was not working so I updated it following up with the TanStack website migration. Let me know if anything is wrong.

@SeanCassiere
Copy link
Member

Now that Tanstack.com is using TSR in production, do you mind updating your PR here?
If everything works after the update, I'd be happy to push to this into the repo.

@alessandrojcm
Copy link
Contributor Author

Now that Tanstack.com is using TSR in production, do you mind updating your PR here?
If everything works after the update, I'd be happy to push to this into the repo.

Sure I'll get to it once I get a chance

@alessandrojcm
Copy link
Contributor Author

Done now @SeanCassiere

@nx-cloud
Copy link

nx-cloud bot commented Apr 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 078a61a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@SeanCassiere
Copy link
Member

SeanCassiere commented Apr 14, 2024

With CI failing, need to figure out what's causing this.

@SeanCassiere
Copy link
Member

Looks to be conflicting vite and vitest dependencies that are causing this.

@SeanCassiere
Copy link
Member

#1467 should resolve these CI errors. Once merged in, you should be able to rebase and have CI pass.

@SeanCassiere SeanCassiere changed the title Updated Vinxi example with Streaming docs(examples): update the vinxi-basic-ssr-streaming example to reflect the TanStack website Apr 14, 2024
@SeanCassiere
Copy link
Member

@alessandrojcm When you have some time, could you update the PR and rebase with main?

The changes from #1467 should allow for the higher version of vinxi that the example was using (that required a higher vite and vitest version from our end).

@alessandrojcm
Copy link
Contributor Author

@alessandrojcm When you have some time, could you update the PR and rebase with main?

The changes from #1467 should allow for the higher version of vinxi that the example was using (that required a higher vite and vitest version from our end).

Done now

@SeanCassiere SeanCassiere merged commit 862fd78 into TanStack:main Apr 15, 2024
@SeanCassiere
Copy link
Member

@alessandrojcm thank you!

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: _a.assets.filter is not a function (Tanstack Router with Vinxi)

3 participants