Skip to content

Conversation

@schiller-manuel
Copy link
Contributor

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Apr 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6755cfd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@schiller-manuel
Copy link
Contributor Author

Performance before this change:

Files:                         589
Lines of Library:            38118
Lines of Definitions:        77155
Lines of TypeScript:         12777
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Identifiers:                113524
Symbols:                    190002
Types:                       50723
Instantiations:             564441
Memory used:               230872K
Assignability cache size:    34134
Identity cache size:          3717
Subtype cache size:              0
Strict subtype cache size:       0
I/O Read time:               0.02s
Parse time:                  0.24s
ResolveModule time:          0.03s
ResolveTypeReference time:   0.00s
ResolveLibrary time:         0.01s
Program time:                0.33s
Bind time:                   0.11s
Check time:                  2.17s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                  2.61s

Performance after this change:

Files:                         589
Lines of Library:            38118
Lines of Definitions:        77155
Lines of TypeScript:         12777
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Identifiers:                113608
Symbols:                    199432
Types:                       51680
Instantiations:             570731
Memory used:               244387K
Assignability cache size:    34191
Identity cache size:          3717
Subtype cache size:              0
Strict subtype cache size:       0
I/O Read time:               0.02s
Parse time:                  0.25s
ResolveModule time:          0.03s
ResolveTypeReference time:   0.00s
ResolveLibrary time:         0.01s
Program time:                0.35s
Bind time:                   0.12s
Check time:                  2.32s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                  2.79s

=> Instantiations increased from 564441 to 570731

@chorobin
Copy link
Contributor

chorobin commented Apr 17, 2024

Can we try to add some type tests for this feature ;) Maybe in a separate pr but it would be good to get a habit of adding to them

@schiller-manuel schiller-manuel force-pushed the feat-strong-typing-onX branch from 477c733 to 6755cfd Compare April 19, 2024 20:08
@schiller-manuel schiller-manuel merged commit e08b881 into main Apr 19, 2024
@schiller-manuel schiller-manuel deleted the feat-strong-typing-onX branch April 19, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants