fix(history): update the state.key when using memory history on navigation change via .back(), .forward(), and .go()
#1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igation change via `.back(), .forward(), and .go()`
SeanCassiere
changed the title
state.key when using memory history on navigation change via .back(), .forward(), and .go()state.key when using memory history on navigation change via .back(), .forward(), and .go()
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 007a2e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1410
Fixes a bug where the
state.keyin the memory history wasn't being updated when a navigation call was made using one of these methods:back()forward()go()This change is not required for the
.pushState()and.replaceState()methods on thecreateMemoryHistoryfactory, since they have theirstate.keyvalues seeded by the.push()and.replace()methods from the basecreateHistory()factory anyways.