Skip to content

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Oct 14, 2025

Summary by CodeRabbit

  • Chores

    • Updated development tooling across example React monorepos (patch-level plugin bumps) and locked a shared config package to a specific version for consistent builds.
    • Enforced a single resolved version of a TypeScript declaration plugin via workspace overrides for predictable development installs.
    • No runtime or user-facing changes; applications continue to function as before.
  • Documentation

    • Updated doc generation paths to reflect reorganized React routing guides.

Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

Bumped devDependency vite-plugin-dts from ^4.5.0 to ^4.5.4 across multiple example React monorepos, updated root @tanstack/config and added a pnpm.overrides entry for vite-plugin-dts at 4.0.3, removed a // @ts-expect-error above an ESLint import, and adjusted two doc path strings in scripts/llms-generate.mjs. No functional runtime code changes.

Changes

Cohort / File(s) Summary of Changes
React Query monorepo: vite-plugin-dts bump
examples/react/router-monorepo-react-query/package.json, examples/react/router-monorepo-react-query/packages/app/package.json, examples/react/router-monorepo-react-query/packages/post-feature/package.json, examples/react/router-monorepo-react-query/packages/router/package.json
Updated devDependency vite-plugin-dts from ^4.5.0^4.5.4.
Simple-lazy monorepo: vite-plugin-dts bump
examples/react/router-monorepo-simple-lazy/package.json, examples/react/router-monorepo-simple-lazy/packages/app/package.json, examples/react/router-monorepo-simple-lazy/packages/post-feature/package.json, examples/react/router-monorepo-simple-lazy/packages/router/package.json
Updated devDependency vite-plugin-dts from ^4.5.0^4.5.4.
Simple monorepo: vite-plugin-dts bump
examples/react/router-monorepo-simple/package.json, examples/react/router-monorepo-simple/packages/app/package.json, examples/react/router-monorepo-simple/packages/post-feature/package.json, examples/react/router-monorepo-simple/packages/router/package.json
Updated devDependency vite-plugin-dts from ^4.5.0^4.5.4.
Root package and workspace overrides
package.json
Updated @tanstack/config from ^0.16.10.22.0 (caret dropped); added pnpm.overrides entry forcing vite-plugin-dts@4.0.3.
ESLint config change
eslint.config.js
Removed the // @ts-expect-error directive above the @tanstack/config/eslint import (no other config logic changed).
Docs generation paths update
scripts/llms-generate.mjs
Replaced two migrated doc path strings with new nested paths: .../migrate-from-react-router.md.../how-to/migrate-from-react-router.md and .../migrate-from-react-location.md.../installation/migrate-from-react-location.md.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • SeanCassiere
  • birkskyum

Poem

I hop through commits, tidy and spry,
Bumped dts versions up toward the sky.
Paths rearranged, lint comment freed,
Carrots of config planted like seed.
Ship the patch — the repo’s spry! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title accurately captures the primary change of upgrading @tanstack/config to v0.22.0 and is concise and clear without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-tanstack-config

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

nx-cloud bot commented Oct 14, 2025

View your CI Pipeline Execution ↗ for commit 7660b8b

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 7m 27s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 52s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-14 11:36:23 UTC

Copy link

pkg-pr-new bot commented Oct 14, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5474

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5474

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5474

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5474

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5474

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5474

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5474

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5474

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5474

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5474

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5474

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5474

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5474

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5474

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5474

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5474

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5474

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5474

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5474

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5474

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5474

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5474

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5474

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5474

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5474

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5474

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5474

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5474

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5474

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5474

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5474

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5474

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5474

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5474

commit: 7660b8b

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d31c0ca and 7660b8b.

📒 Files selected for processing (2)
  • eslint.config.js (0 hunks)
  • scripts/llms-generate.mjs (1 hunks)
💤 Files with no reviewable changes (1)
  • eslint.config.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Preview
  • GitHub Check: Test

Comment on lines +45 to +46
`${DOCS_DIR}/router/framework/react/how-to/migrate-from-react-router.md`,
`${DOCS_DIR}/router/framework/react/installation/migrate-from-react-location.md`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

🧩 Analysis chain

Verify the new documentation paths exist and check for stale references.

The migration guide paths have been updated to new nested locations. Ensure that:

  1. The files exist at the new paths
  2. No other code or documentation references the old paths

Run the following script to verify:


🏁 Script executed:

#!/bin/bash

# Check if the new files exist at the specified paths
echo "=== Checking if new documentation files exist ==="
NEW_PATH_1="docs/router/framework/react/how-to/migrate-from-react-router.md"
NEW_PATH_2="docs/router/framework/react/installation/migrate-from-react-location.md"

if [ -f "$NEW_PATH_1" ]; then
  echo "✓ Found: $NEW_PATH_1"
else
  echo "✗ Missing: $NEW_PATH_1"
fi

if [ -f "$NEW_PATH_2" ]; then
  echo "✓ Found: $NEW_PATH_2"
else
  echo "✗ Missing: $NEW_PATH_2"
fi

echo ""
echo "=== Searching for references to old paths ==="
# Search for old path references
rg -n --type=md --type=js --type=ts --type=tsx -g '!node_modules' \
  'migrate-from-react-router\.md|migrate-from-react-location\.md' \
  | grep -v 'how-to/migrate-from-react-router' \
  | grep -v 'installation/migrate-from-react-location'

Length of output: 278


🏁 Script executed:

#!/bin/bash
echo "=== Searching for references to old migration guide paths ==="
rg -n 'migrate-from-react-router\.md|migrate-from-react-location\.md' -g '!node_modules' \
  | grep -v 'docs/router/framework/react/how-to/migrate-from-react-router.md' \
  | grep -v 'docs/router/framework/react/installation/migrate-from-react-location.md'

Length of output: 855


Update stale documentation links for migration guides

  • how-to-testing-plan.md (lines 80, 220): change migrate-from-react-router.md → correct relative path under router/framework/react/how-to/migrate-from-react-router.md
  • docs/router/framework/react/how-to/deploy-to-production.md (line 438): update ../migrate-from-react-router.md../how-to/migrate-from-react-router.md
  • docs/router/framework/react/how-to/README.md (line 16): update ./migrate-from-react-router.md./how-to/migrate-from-react-router.md
🤖 Prompt for AI Agents
In scripts/llms-generate.mjs around lines 45 to 46, the generated list contains
stale/misplaced migration doc paths; update occurrences of
migrate-from-react-router.md to the correct relative paths under
router/framework/react/how-to (e.g.,
router/framework/react/how-to/migrate-from-react-router.md) and change any
../migrate-from-react-router.md or ./migrate-from-react-router.md references to
../how-to/migrate-from-react-router.md and ./how-to/migrate-from-react-router.md
respectively so all links point to the how-to subdirectory.

@lachlancollins lachlancollins merged commit 0bdb0ee into main Oct 14, 2025
6 checks passed
@lachlancollins lachlancollins deleted the update-tanstack-config branch October 14, 2025 11:36
@coderabbitai coderabbitai bot mentioned this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant