-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: bump @tanstack/config to v0.22.0 #5474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumped devDependency Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
View your CI Pipeline Execution ↗ for commit 7660b8b
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
eslint.config.js
(0 hunks)scripts/llms-generate.mjs
(1 hunks)
💤 Files with no reviewable changes (1)
- eslint.config.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
`${DOCS_DIR}/router/framework/react/how-to/migrate-from-react-router.md`, | ||
`${DOCS_DIR}/router/framework/react/installation/migrate-from-react-location.md`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
Verify the new documentation paths exist and check for stale references.
The migration guide paths have been updated to new nested locations. Ensure that:
- The files exist at the new paths
- No other code or documentation references the old paths
Run the following script to verify:
🏁 Script executed:
#!/bin/bash
# Check if the new files exist at the specified paths
echo "=== Checking if new documentation files exist ==="
NEW_PATH_1="docs/router/framework/react/how-to/migrate-from-react-router.md"
NEW_PATH_2="docs/router/framework/react/installation/migrate-from-react-location.md"
if [ -f "$NEW_PATH_1" ]; then
echo "✓ Found: $NEW_PATH_1"
else
echo "✗ Missing: $NEW_PATH_1"
fi
if [ -f "$NEW_PATH_2" ]; then
echo "✓ Found: $NEW_PATH_2"
else
echo "✗ Missing: $NEW_PATH_2"
fi
echo ""
echo "=== Searching for references to old paths ==="
# Search for old path references
rg -n --type=md --type=js --type=ts --type=tsx -g '!node_modules' \
'migrate-from-react-router\.md|migrate-from-react-location\.md' \
| grep -v 'how-to/migrate-from-react-router' \
| grep -v 'installation/migrate-from-react-location'
Length of output: 278
🏁 Script executed:
#!/bin/bash
echo "=== Searching for references to old migration guide paths ==="
rg -n 'migrate-from-react-router\.md|migrate-from-react-location\.md' -g '!node_modules' \
| grep -v 'docs/router/framework/react/how-to/migrate-from-react-router.md' \
| grep -v 'docs/router/framework/react/installation/migrate-from-react-location.md'
Length of output: 855
Update stale documentation links for migration guides
- how-to-testing-plan.md (lines 80, 220): change
migrate-from-react-router.md
→ correct relative path underrouter/framework/react/how-to/migrate-from-react-router.md
- docs/router/framework/react/how-to/deploy-to-production.md (line 438): update
../migrate-from-react-router.md
→../how-to/migrate-from-react-router.md
- docs/router/framework/react/how-to/README.md (line 16): update
./migrate-from-react-router.md
→./how-to/migrate-from-react-router.md
🤖 Prompt for AI Agents
In scripts/llms-generate.mjs around lines 45 to 46, the generated list contains
stale/misplaced migration doc paths; update occurrences of
migrate-from-react-router.md to the correct relative paths under
router/framework/react/how-to (e.g.,
router/framework/react/how-to/migrate-from-react-router.md) and change any
../migrate-from-react-router.md or ./migrate-from-react-router.md references to
../how-to/migrate-from-react-router.md and ./how-to/migrate-from-react-router.md
respectively so all links point to the how-to subdirectory.
Summary by CodeRabbit
Chores
Documentation