Bump vite plugin solid to 2.11.10 #5572

birkskyum · 2025-10-21T19:44:23Z

This .10 patch allow for the cloudflare vite plugin integration to work better for solid-start

Summary by CodeRabbit

Chores
- Updated a development build plugin to a newer patch version across project examples, e2e suites, and packages.
Refactor
- Simplified the Cloudflare build configuration by removing an auxiliary SSR-external clearing step.

coderabbitai · 2025-10-21T19:44:56Z

Walkthrough

Updated dev/peer dependency ranges for vite-plugin-solid to ^2.11.10 across many e2e, examples, and package manifests; removed a local Vite plugin helper (clearSsrExternal) import and invocation from a Cloudflare example Vite config.

Changes

Cohort / File(s)	Summary
E2E: solid-router `e2e/solid-router/basic-file-based-code-splitting/package.json`, `e2e/solid-router/basic-file-based/package.json`, `e2e/solid-router/basic-scroll-restoration/package.json`, `e2e/solid-router/basic-solid-query-file-based/package.json`, `e2e/solid-router/basic-solid-query/package.json`, `e2e/solid-router/basic-virtual-file-based/package.json`, `e2e/solid-router/basic-virtual-named-export-config-file-based/package.json`, `e2e/solid-router/basic/package.json`, `e2e/solid-router/scroll-restoration-sandbox-vite/package.json`	Bumped devDependency `vite-plugin-solid` to `^2.11.10`.
E2E: solid-start `e2e/solid-start/basic-auth/package.json`, `e2e/solid-start/basic-solid-query/package.json`, `e2e/solid-start/basic-tsr-config/package.json`, `e2e/solid-start/basic/package.json`, `e2e/solid-start/custom-basepath/package.json`, `e2e/solid-start/query-integration/package.json`, `e2e/solid-start/scroll-restoration/package.json`, `e2e/solid-start/selective-ssr/package.json`, `e2e/solid-start/server-functions/package.json`, `e2e/solid-start/server-routes/package.json`, `e2e/solid-start/spa-mode/package.json`, `e2e/solid-start/virtual-routes/package.json`, `e2e/solid-start/website/package.json`	Bumped devDependency `vite-plugin-solid` to `^2.11.10` (previously various `^2.11.8`/`^2.11.9`).
Examples: solid `examples/solid/basic-devtools-panel/package.json`, `examples/solid/basic-file-based/package.json`, `examples/solid/basic-non-nested-devtools/package.json`, `examples/solid/basic-solid-query-file-based/package.json`, `examples/solid/basic-solid-query/package.json`, `examples/solid/basic-ssr-streaming-file-based/package.json`, `examples/solid/basic/package.json`, `examples/solid/quickstart-file-based/package.json`, `examples/solid/kitchen-sink-file-based/package.json`, `examples/solid/kitchen-sink-solid-query-file-based/package.json`, `examples/solid/kitchen-sink-solid-query/package.json`, `examples/solid/start-bare/package.json`, `examples/solid/start-basic-auth/package.json`, `examples/solid/start-basic-cloudflare/package.json`, `examples/solid/start-basic-solid-query/package.json`, `examples/solid/start-basic-static/package.json`, `examples/solid/start-basic/package.json`	Bumped devDependency `vite-plugin-solid` to `^2.11.10` (some files updated from `^2.11.6`/`^2.11.9`).
Examples: Cloudflare Vite config `examples/solid/start-basic-cloudflare/vite.config.ts`	Removed local Vite plugin helper `clearSsrExternal` along with its import and plugin invocation.
Packages: core & plugins `packages/router-devtools-core/package.json`, `packages/router-plugin/package.json`, `packages/solid-router-devtools/package.json`, `packages/solid-router-ssr-query/package.json`, `packages/solid-router/package.json`, `packages/solid-start-client/package.json`, `packages/solid-start-server/package.json`	Bumped dev/peer dependency `vite-plugin-solid` to `^2.11.10` (peer updated in `packages/router-plugin/package.json`).
Misc file tidy `packages/react-router/src/useNavigate.tsx`	Minor whitespace change (blank line added); no functional changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Homogeneous dependency bumps across many manifests with one small config removal and a trivial whitespace edit.

Suggested reviewers

lachlancollins

Poem

🐇 Hop, hop — the versions climb again,

from eight to ten we tweak the chain.
A helper waved a soft goodbye,
configs trim, manifests sigh.
Build tools hum, the tests will prance — hooray, advance!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Bump vite plugin solid to 2.11.10" directly and accurately describes the primary change in the changeset. The overwhelming majority of modifications across the pull request consist of updates to the vite-plugin-solid devDependency (and one peerDependency) from various previous versions (^2.11.6, ^2.11.8, or ^2.11.9) to ^2.11.10 across 40+ package.json files. The title is concise, clear, and specific enough that a teammate scanning the project history would understand the primary objective. While the PR description mentions secondary improvements related to Cloudflare Vite plugin integration, the title appropriately focuses on the main change, which is the dependency version bump.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch bump-vite-plugin-solid-to-2.11.10

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20dd330 and 1aa4b9c.

📒 Files selected for processing (1)

packages/react-router/src/useNavigate.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/react-router/src/useNavigate.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Preview
GitHub Check: Test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-10-21T19:45:01Z

View your CI Pipeline Execution ↗ for commit 1aa4b9c

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	6m 1s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	54s	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-21 20:13:17 UTC

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

examples/solid/start-basic-solid-query/package.json (1)
11-21: Use workspace:* protocol for internal dependencies.

Per coding guidelines, all internal dependencies (those in the @TanStack namespace) should use the workspace:* protocol instead of semantic version ranges. This applies to @tanstack/solid-query, @tanstack/solid-query-devtools, @tanstack/solid-router, @tanstack/solid-router-ssr-query, @tanstack/solid-router-devtools, and @tanstack/solid-start.

Apply this diff to align with coding guidelines:
   "dependencies": {
-    "@tanstack/solid-query": "^5.66.0",
-    "@tanstack/solid-query-devtools": "^5.66.0",
-    "@tanstack/solid-router": "^1.133.20",
-    "@tanstack/solid-router-ssr-query": "^1.133.20",
-    "@tanstack/solid-router-devtools": "^1.133.20",
-    "@tanstack/solid-start": "^1.133.21",
+    "@tanstack/solid-query": "workspace:*",
+    "@tanstack/solid-query-devtools": "workspace:*",
+    "@tanstack/solid-router": "workspace:*",
+    "@tanstack/solid-router-ssr-query": "workspace:*",
+    "@tanstack/solid-router-devtools": "workspace:*",
+    "@tanstack/solid-start": "workspace:*",
     "solid-js": "^1.9.5",
     "redaxios": "^0.5.1",
     "tailwind-merge": "^2.6.0"
   },

🧹 Nitpick comments (2)

examples/solid/quickstart-file-based/package.json (1)
11-26: Consider using workspace:* for internal dependencies.

The internal dependencies (@tanstack/solid-router, @tanstack/router-plugin, @tanstack/solid-router-devtools) should use the workspace:* protocol per coding guidelines, rather than pinned versions. This ensures consistency across the workspace and prevents version mismatches.

Apply this diff to align with the workspace protocol:
  "dependencies": {
-    "@tanstack/solid-router": "^1.133.20",
+    "@tanstack/solid-router": "workspace:*",
    "@tanstack/solid-router-devtools": "^1.133.20",
  "devDependencies": {
-    "@tanstack/router-plugin": "^1.133.21",
+    "@tanstack/router-plugin": "workspace:*",
As per coding guidelines.
examples/solid/basic-solid-query-file-based/package.json (1)

12-16: Consider using workspace:* protocol for internal @tanstack/ dependencies.*

Per the coding guidelines, internal dependencies in package.json files should use the workspace:* protocol. The @tanstack/* packages in this file (@tanstack/solid-query, @tanstack/solid-query-devtools, @tanstack/solid-router, @tanstack/solid-router-devtools, @tanstack/router-plugin) appear to be internal monorepo packages and would benefit from using workspace:* instead of versioned constraints.

This is not a blocker for the current PR but would align the file with project conventions.

Also applies to: 25-25

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3a3c0b and 20dd330.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (47)

e2e/solid-router/basic-file-based-code-splitting/package.json (1 hunks)
e2e/solid-router/basic-file-based/package.json (1 hunks)
e2e/solid-router/basic-scroll-restoration/package.json (1 hunks)
e2e/solid-router/basic-solid-query-file-based/package.json (1 hunks)
e2e/solid-router/basic-solid-query/package.json (1 hunks)
e2e/solid-router/basic-virtual-file-based/package.json (1 hunks)
e2e/solid-router/basic-virtual-named-export-config-file-based/package.json (1 hunks)
e2e/solid-router/basic/package.json (1 hunks)
e2e/solid-router/scroll-restoration-sandbox-vite/package.json (1 hunks)
e2e/solid-start/basic-auth/package.json (1 hunks)
e2e/solid-start/basic-solid-query/package.json (1 hunks)
e2e/solid-start/basic-tsr-config/package.json (1 hunks)
e2e/solid-start/basic/package.json (1 hunks)
e2e/solid-start/custom-basepath/package.json (1 hunks)
e2e/solid-start/query-integration/package.json (1 hunks)
e2e/solid-start/scroll-restoration/package.json (1 hunks)
e2e/solid-start/selective-ssr/package.json (1 hunks)
e2e/solid-start/server-functions/package.json (1 hunks)
e2e/solid-start/server-routes/package.json (1 hunks)
e2e/solid-start/spa-mode/package.json (1 hunks)
e2e/solid-start/virtual-routes/package.json (1 hunks)
e2e/solid-start/website/package.json (1 hunks)
examples/solid/basic-devtools-panel/package.json (1 hunks)
examples/solid/basic-file-based/package.json (1 hunks)
examples/solid/basic-non-nested-devtools/package.json (1 hunks)
examples/solid/basic-solid-query-file-based/package.json (1 hunks)
examples/solid/basic-solid-query/package.json (1 hunks)
examples/solid/basic-ssr-streaming-file-based/package.json (1 hunks)
examples/solid/basic/package.json (1 hunks)
examples/solid/kitchen-sink-file-based/package.json (1 hunks)
examples/solid/kitchen-sink-solid-query-file-based/package.json (1 hunks)
examples/solid/kitchen-sink-solid-query/package.json (1 hunks)
examples/solid/quickstart-file-based/package.json (1 hunks)
examples/solid/start-bare/package.json (1 hunks)
examples/solid/start-basic-auth/package.json (1 hunks)
examples/solid/start-basic-cloudflare/package.json (1 hunks)
examples/solid/start-basic-cloudflare/vite.config.ts (0 hunks)
examples/solid/start-basic-solid-query/package.json (1 hunks)
examples/solid/start-basic-static/package.json (1 hunks)
examples/solid/start-basic/package.json (1 hunks)
packages/router-devtools-core/package.json (1 hunks)
packages/router-plugin/package.json (1 hunks)
packages/solid-router-devtools/package.json (1 hunks)
packages/solid-router-ssr-query/package.json (1 hunks)
packages/solid-router/package.json (1 hunks)
packages/solid-start-client/package.json (1 hunks)
packages/solid-start-server/package.json (1 hunks)

💤 Files with no reviewable changes (1)

examples/solid/start-basic-cloudflare/vite.config.ts

🧰 Additional context used

📓 Path-based instructions (7)

**/package.json