-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add jsdoc annotations to public api #5587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsdoc annotations to public api #5587
Conversation
Co-authored-by: tannerlinsley <tannerlinsley@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
Caution Review failedThe pull request is closed. WalkthroughThe changes add new public utilities, constants, and symbols across the router-core package, along with comprehensive JSDoc documentation. Key additions include TSR_DEFERRED_PROMISE symbol, exactPathTest function, rootRouteId constant, and utilities for error serialization, location change detection, route matching, and initial state creation. Mostly additive changes with no modifications to existing logic or behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Multiple files contain new public APIs with logic requiring verification (particularly router.ts with several utility functions), while several files contain documentation-only changes. Heterogeneous mix of functional additions and documentation updates across the codebase demands separate reasoning for each new utility. Possibly related PRs
Suggested labels
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (9)
Comment |
|
View your CI Pipeline Execution ↗ for commit 116e4c0
☁️ Nx Cloud last updated this comment at |
Co-authored-by: tannerlinsley <tannerlinsley@gmail.com>
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-router-ssr-query
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Add JSDoc annotations to 20 core public API exports to improve code self-documentation.
Summary by CodeRabbit
Release Notes
New Features
exactPathTestfor path comparison,getLocationChangeInfofor tracking location changes, andgetMatchedRoutesfor route matching.SearchParamErrorandPathParamError.defaultSerializeErrorfor error serialization andgetInitialRouterStatefor router initialization.lazyFnfunction.preserveoption for trailing slash handling.rootRouteIdconstant for stable root route identification.Documentation