Skip to content

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 16, 2025

Summary by CodeRabbit

  • Chores
    • Removed example code and associated end-to-end tests for transition functionality across multiple framework implementations.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 16, 2025

Walkthrough

This pull request removes four files: two route modules and two corresponding end-to-end test files from the React Router and Solid Router e2e examples. Both route modules defined a /transition/count/query page with React Query integration, along with their associated Playwright tests that validated navigation transitions and count increments.

Changes

Cohort / File(s) Summary
React Router transition/count/query route & test
e2e/react-router/basic-react-query-file-based/src/routes/transition/count/query.tsx, e2e/react-router/basic-react-query-file-based/tests/transition.spec.ts
Deleted route file defining Zod-validated search schema, React Query options, file-based Route with loader, and TransitionPage component; deleted corresponding e2e test validating navigation, polling, button clicks, value assertions, and absence of loading state.
Solid Router transition/count/query route & test
e2e/solid-router/basic-solid-query-file-based/src/routes/transition/count/query.tsx, e2e/solid-router/basic-solid-query-file-based/tests/transition.spec.ts
Deleted route file defining Solid Router file-based Route with search schema validation, Solid Query options, and Suspense-wrapped UI component; deleted corresponding e2e test validating transitions, incremental updates, timeouts, and loading state absence.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify deletions are intentional and align with related refactoring efforts
  • Confirm no orphaned imports or references remain in other files
  • Check that deleted routes are not referenced in route tree configurations elsewhere

Possibly related PRs

Suggested labels

package: react-router, package: solid-router

Poem

🐰 A whisker twitch, then whoosh—away,
Four files vanish, cleared today!
React and Solid routes take flight,
Tests disappear into the night.
The query count bids its goodbye,
As rabbit refactors soar on high! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing flaky query transition tests from the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test(router)--remove-flaky-test

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf73030 and 9195dc5.

📒 Files selected for processing (4)
  • e2e/react-router/basic-react-query-file-based/src/routes/transition/count/query.tsx (0 hunks)
  • e2e/react-router/basic-react-query-file-based/tests/transition.spec.ts (0 hunks)
  • e2e/solid-router/basic-solid-query-file-based/src/routes/transition/count/query.tsx (0 hunks)
  • e2e/solid-router/basic-solid-query-file-based/tests/transition.spec.ts (0 hunks)
💤 Files with no reviewable changes (4)
  • e2e/react-router/basic-react-query-file-based/tests/transition.spec.ts
  • e2e/solid-router/basic-solid-query-file-based/tests/transition.spec.ts
  • e2e/react-router/basic-react-query-file-based/src/routes/transition/count/query.tsx
  • e2e/solid-router/basic-solid-query-file-based/src/routes/transition/count/query.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test
  • GitHub Check: Preview

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Nov 16, 2025

View your CI Pipeline Execution ↗ for commit 9195dc5

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 2m 18s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-16 18:26:36 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 16, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5883

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5883

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5883

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5883

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5883

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5883

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5883

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5883

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5883

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5883

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5883

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5883

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5883

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5883

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5883

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5883

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5883

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5883

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5883

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5883

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5883

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5883

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5883

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5883

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5883

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5883

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5883

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5883

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5883

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5883

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5883

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5883

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5883

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5883

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5883

commit: 9195dc5

@birkskyum birkskyum merged commit f830dff into main Nov 16, 2025
6 checks passed
@birkskyum birkskyum deleted the test(router)--remove-flaky-test branch November 16, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants