Skip to content

Conversation

@phoefflin
Copy link
Contributor

@phoefflin phoefflin commented Nov 19, 2025

Fixes js-yaml prototype pollution vulnerability (GHSA-mh29-5h37-fv8m) in xmlbuilder2 v3.1.1 by upgrading to v4.0.0, which updates js-yaml to 4.1.0.

the reason for bumping a major version is minimum node version requirement of node 20, see: https://github.com/oozcitak/xmlbuilder2/blob/master/CHANGELOG.md#400---2025-10-08

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to improve system stability and compatibility.

Fixes js-yaml prototype pollution vulnerability (GHSA-mh29-5h37-fv8m) in
xmlbuilder2 v3.1.1 by upgrading to v4.0.0, which updates js-yaml to 4.1.0.

see: https://github.com/oozcitak/xmlbuilder2/blob/master/CHANGELOG.md#400---2025-10-08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Walkthrough

The xmlbuilder2 dependency in the start-plugin-core package is upgraded from version 3.1.1 to 4.0.0, representing a major version bump in the package manifest.

Changes

Cohort / File(s) Summary
Dependency Update
packages/start-plugin-core/package.json
xmlbuilder2 version bumped from ^3.1.1 to ^4.0.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Note: Major version bump (3→4) warrants brief verification of xmlbuilder2 changelog to confirm no breaking changes in public API surface used by this package

Poem

🐰 XML builders hop with glee,
Version four, now wild and free,
From three to four, we've made the leap,
Dependencies now running deep! 🔄

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating xmlbuilder2 to v4.0.0 to address npm audit vulnerability warnings, which aligns perfectly with the PR's objective of fixing security issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a97163 and ea940a1.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/start-plugin-core/package.json (1 hunks)
🔇 Additional comments (2)
packages/start-plugin-core/package.json (2)

83-83: Node.js requirement is compatible with xmlbuilder2 v4.0.0.

The current Node.js requirement of >=22.12.0 (line 61) exceeds the minimum Node.js 20 requirement for xmlbuilder2 v4.0.0, so this upgrade is compatible with your project's baseline.


83-83: Verify xmlbuilder2 v4 compatibility with the existing codebase.

xmlbuilder2 is actively used in packages/start-plugin-core/src/build-sitemap.ts and relies on core, fundamental APIs: create(), ele(), att(), txt(), com(), and end(). These chainable methods are unlikely to have breaking changes. However, no specific v3→v4 breaking changes were found in available documentation. Recommend testing the sitemap generation after upgrading to confirm XML output remains correct and properly formatted.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Nov 19, 2025

View your CI Pipeline Execution ↗ for commit ea940a1

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 13m 20s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-19 16:56:00 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 19, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5902

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5902

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5902

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5902

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5902

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5902

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5902

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5902

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5902

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5902

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5902

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5902

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5902

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5902

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5902

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5902

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5902

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5902

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5902

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5902

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5902

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5902

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5902

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5902

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5902

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5902

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5902

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5902

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5902

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5902

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5902

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5902

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5902

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5902

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5902

commit: ea940a1

Copy link
Member

@birkskyum birkskyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@birkskyum birkskyum merged commit 04f701f into TanStack:main Nov 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants