Skip to content

fix(solid-start): fix hydration regression in 1.136.9 #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
+1 −1
Merged

fix(solid-start): fix hydration regression in 1.136.9 #5903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7303794
fix(solid-start): fix hydration regression in 1.136.9
birkskyum Nov 19, 2025
ec9247a
ci: apply automated fixes
autofix-ci[bot] Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/solid-router/src/Asset.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function Script({

if (!router.isServer) {
// render an empty script on the client just to avoid hydration errors
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Update the comment to match the new behavior.

The comment states "render an empty script on the client just to avoid hydration errors", but the code now returns null instead of an empty script tag.

Apply this diff to update the comment:

-    // render an empty script on the client just to avoid hydration errors
+    // render nothing on the client to match server-side behavior and avoid hydration errors
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// render an empty script on the client just to avoid hydration errors
// render nothing on the client to match server-side behavior and avoid hydration errors
🤖 Prompt for AI Agents 
In packages/solid-router/src/Asset.tsx around line 127, update the inline
comment which currently reads "render an empty script on the client just to
avoid hydration errors" to reflect the new behavior: the component now returns
null on the client to avoid hydration errors; change the comment to something
like "return null on the client to avoid hydration errors" so it matches the
code.

return <script />
return null
}

if (attrs?.src && typeof attrs.src === 'string') {
Expand Down
Loading