Skip to content

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 19, 2025

There is no start command e.g. vite start, so i remove it here since it's just confusing.

Basically vite just reads start as an unknown command and launches a dev server on port 5173, instead of honoring port settings in vite.config.ts like defined commands vite/vite dev/vite serve

What we really need is a "preview" command ot show the production build, like suggested here:

Summary by CodeRabbit

  • Chores
    • Removed start scripts from multiple React and Solid example projects. Build scripts remain available.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Walkthrough

Removed the "start": "vite start" npm script from 23 example project package.json files across React and Solid frameworks. Build scripts and all other configurations remain unchanged.

Changes

Cohort / File(s) Change Summary
React Examples
examples/react/start-bare/package.json, examples/react/start-basic-auth/package.json, examples/react/start-basic-react-query/package.json, examples/react/start-basic-rsc/package.disabled.json, examples/react/start-basic-static/package.json, examples/react/start-clerk-basic/package.json, examples/react/start-convex-trellaux/package.json, examples/react/start-counter/package.json, examples/react/start-large/package.json, examples/react/start-material-ui/package.json, examples/react/start-streaming-data-from-server-functions/package.json, examples/react/start-supabase-basic/package.json, examples/react/start-trellaux/package.json, examples/react/start-workos/package.json
Removed start script from scripts section; build script remains unchanged
Solid Examples
examples/solid/start-basic-auth/package.json, examples/solid/start-basic-solid-query/package.json, examples/solid/start-basic-static/package.json, examples/solid/start-basic/package.json, examples/solid/start-convex-better-auth/package.json, examples/solid/start-counter/package.json, examples/solid/start-large/package.json, examples/solid/start-streaming-data-from-server-functions/package.json, examples/solid/start-supabase-basic/package.json
Removed start script from scripts section; build script remains unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • All 23 changes are identical in nature (same script removal pattern across different files)
  • Verify consistency of the removal across all package.json files
  • Confirm that no build or dev scripts were inadvertently affected

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • schiller-manuel

Poem

🐰 ✨ A start script's farewell we sing,
Twenty-three files lose their spring,
Vite start may no longer run,
But the build script's still got fun!
Examples trimmed, and configs lean,
Cleanest workflows ever seen! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately reflects the main change: removing the undocumented vite start command from example package.json files across multiple frameworks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch example--remove-undocumented-vite-start-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Nov 19, 2025

View your CI Pipeline Execution ↗ for commit 0712c75

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 38s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 55s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-19 23:11:44 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 19, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5914

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5914

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5914

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5914

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5914

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5914

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5914

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5914

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5914

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5914

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5914

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5914

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5914

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5914

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5914

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5914

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5914

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5914

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5914

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5914

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5914

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5914

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5914

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5914

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5914

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5914

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5914

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5914

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5914

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5914

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5914

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5914

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5914

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5914

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5914

commit: 0712c75

@birkskyum birkskyum merged commit 532669e into main Nov 19, 2025
6 checks passed
@birkskyum birkskyum deleted the example--remove-undocumented-`vite-start`-command branch November 19, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants