-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
example: remove undocumented vite start command
#5914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: remove undocumented vite start command
#5914
Conversation
WalkthroughRemoved the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 0712c75
☁️ Nx Cloud last updated this comment at |
There is no start command e.g.
vite start, so i remove it here since it's just confusing.Basically vite just reads
startas an unknown command and launches a dev server on port 5173, instead of honoring port settings in vite.config.ts like defined commandsvite/vite dev/vite serveWhat we really need is a "preview" command ot show the production build, like suggested here:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.