feat: prerender with vite preview server #5921
Conversation
WalkthroughAdds a /static route and tests for Cloudflare e2e examples, enables prerendering for that route, and refactors post-build/prerender to run against a Vite preview server (removing reliance on a server bundle and adjusting plugin hooks and signatures). Changes
Sequence Diagram(s)sequenceDiagram
participant Build as Build Process
participant Plugin as start-plugin-core (post-build)
participant PostBuild as postServerBuild
participant PreRender as prerender
participant Preview as Vite Preview Server
participant Fetcher as HTTP Fetcher
Build->>Plugin: buildApp completes
Plugin->>PostBuild: invoke postServerBuild(builder, startConfig)
PostBuild->>PreRender: prerender({ builder, startConfig })
rect rgba(200,220,240,0.6)
Note over PreRender,Preview: NEW — start preview server & resolve base URL
PreRender->>Preview: startPreviewServer(viteConfig)
Preview-->>PreRender: previewServer instance
PreRender->>PreRender: baseURL = getResolvedUrl(previewServer)
end
rect rgba(240,230,210,0.6)
Note over PreRender,Fetcher: Prerender loop (pages)
loop for each page
PreRender->>Fetcher: fetch(baseURL + page.path)
Fetcher-->>PreRender: HTML response
PreRender->>PreRender: write HTML to disk
end
end
rect rgba(220,240,220,0.6)
Note over PreRender,Preview: cleanup
PreRender->>Preview: previewServer.close() (finally)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit b954752
☁️ Nx Cloud last updated this comment at |
|
cc: @schiller-manuel |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/start-plugin-core/src/prerender.ts (1)
62-89: Preview-server-based prerender flow looks solid; a couple of small robustness tweaks to considerThe new approach of starting a Vite preview server, resolving its URL, and then using
localFetchagainst that base is a nice way to make prerendering runtime‑agnostic and unlock Workers support. A few minor hardening points you might want to consider:
Always close the preview server, even if URL resolution fails
Right now,startPreviewServerandgetResolvedUrl(previewServer)run before thetry/finally. IfgetResolvedUrlthrows (e.g.resolvedUrls.localis unexpectedly empty), the function will exit before reaching thefinallyblock andpreviewServer.close()won’t be called. It’s low‑probability, but you could avoid any leak by moving thegetResolvedUrlcall inside thetry(or wrapping server startup + URL resolution in their owntry/finallyand guardingpreviewServerbefore closing).Make redirect handling base‑URL aware instead of hard‑coding
http://localhost
InlocalFetch, redirects are only treated as “local” if thelocationheader starts with'http://localhost'or'/'. Now that the preview base URL is dynamic, it may be safer to compare againstbaseUrl.origin(e.g.location.startsWith(baseUrl.origin)) rather than assuminglocalhost, which would make this logic more resilient if Vite or the runtime ever emits redirects to a different loopback host.These are defensive improvements; the core design and flow of the new prerender implementation look correct.
Also applies to: 91-103, 265-296
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
e2e/react-start/basic-cloudflare/package.json(2 hunks)e2e/react-start/basic-cloudflare/src/routeTree.gen.ts(3 hunks)e2e/react-start/basic-cloudflare/src/routes/static.tsx(1 hunks)e2e/react-start/basic-cloudflare/tests/app.spec.ts(2 hunks)e2e/react-start/basic-cloudflare/vite.config.ts(1 hunks)packages/start-plugin-core/src/plugin.ts(1 hunks)packages/start-plugin-core/src/post-server-build.ts(1 hunks)packages/start-plugin-core/src/prerender.ts(5 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-11-02T16:16:24.898Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5732
File: packages/start-client-core/src/client/hydrateStart.ts:6-9
Timestamp: 2025-11-02T16:16:24.898Z
Learning: In packages/start-client-core/src/client/hydrateStart.ts, the `import/no-duplicates` ESLint disable is necessary for imports from `#tanstack-router-entry` and `#tanstack-start-entry` because both aliases resolve to the same placeholder file (`fake-start-entry.js`) in package.json during static analysis, even though they resolve to different files at runtime.
Applied to files:
e2e/react-start/basic-cloudflare/vite.config.tspackages/start-plugin-core/src/prerender.tse2e/react-start/basic-cloudflare/src/routeTree.gen.ts
📚 Learning: 2025-10-08T08:11:47.088Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5402
File: packages/router-generator/tests/generator/no-formatted-route-tree/routeTree.nonnested.snapshot.ts:19-21
Timestamp: 2025-10-08T08:11:47.088Z
Learning: Test snapshot files in the router-generator tests directory (e.g., files matching the pattern `packages/router-generator/tests/generator/**/routeTree*.snapshot.ts` or `routeTree*.snapshot.js`) should not be modified or have issues flagged, as they are fixtures used to verify the generator's output and are intentionally preserved as-is.
Applied to files:
e2e/react-start/basic-cloudflare/tests/app.spec.tse2e/react-start/basic-cloudflare/src/routeTree.gen.ts
📚 Learning: 2025-10-01T18:31:35.420Z
Learnt from: schiller-manuel
Repo: TanStack/router PR: 5330
File: e2e/react-start/custom-basepath/src/routeTree.gen.ts:58-61
Timestamp: 2025-10-01T18:31:35.420Z
Learning: Do not review files named `routeTree.gen.ts` in TanStack Router repositories, as these are autogenerated files that should not be manually modified.
Applied to files:
e2e/react-start/basic-cloudflare/src/routeTree.gen.ts
🧬 Code graph analysis (1)
packages/start-plugin-core/src/plugin.ts (1)
packages/start-plugin-core/src/post-server-build.ts (1)
postServerBuild(8-70)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (6)
e2e/react-start/basic-cloudflare/package.json (1)
23-36: Cloudflare tooling version bumps look aligned with the new preview-based prerender flowThe updated
@cloudflare/vite-pluginandwranglerversions make sense given the move to a preview-server-based prerender and the referenced workerd cleanup fix. Just make sure these versions remain in sync with whatever minimum versions the core plugin assumes when this lands onmain(especially around preview behavior and bindings exposure).e2e/react-start/basic-cloudflare/tests/app.spec.ts (1)
1-31: Prerender E2E test nicely covers both build artifact and runtime behaviorThe
prerender with Cloudflare Workers runtimetest looks solid: it asserts that/staticis actually prerendered todist/client/static/index.htmland then verifies, via Playwright, that the page renders with the expected heading and binding-derived content. This lines up well with the new/staticroute and prerender filter.packages/start-plugin-core/src/plugin.ts (1)
328-360: Clean separation of build vs post-build responsibilitiesMoving
postServerBuildinto a dedicatedbuildApphook withorder: 'post'keeps the corebuilder.buildAppfocused purely on building client/server environments while still guaranteeing that prerendering + sitemap run after a successful build. ThegetConfig()usage here reuses the parsedstartConfigand stays consistent with how config is resolved earlier.e2e/react-start/basic-cloudflare/vite.config.ts (1)
13-18: Prerender config correctly scopes output to/staticEnabling prerendering with a
filterthat matches onlypage.path === '/static'is a good fit for this e2e app: it keeps the prerender surface minimal while lining up with the new/staticroute and the test that assertsdist/client/static/index.htmlexists.e2e/react-start/basic-cloudflare/src/routes/static.tsx (1)
1-25:/staticroute cleanly exercises Cloudflare bindings via a server functionThe route setup looks good:
createServerFnreadsenv.MY_VARfrom the Workers environment, the loader delegates to it, andStaticPageconsumes the loader data withRoute.useLoaderData()while exposing stable test IDs. This should give strong coverage of Worker bindings in both runtime and prerender flows.packages/start-plugin-core/src/post-server-build.ts (1)
6-14: postServerBuild API adjustment matches preview-based prerender flowDropping the
serverBundleparameter and callingprerender({ startConfig, builder })keeps this helper aligned with the new preview-server-based prerender implementation while preserving the existing prerender/spa/sitemap behaviors. Call sites (in the core plugin) have been updated consistently.Also applies to: 53-59
| buildApp: { | ||
| order: 'post', | ||
| async handler(builder) { | ||
| const { startConfig } = getConfig() | ||
| await postServerBuild({ builder, startConfig }) | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I have moved the postServerBuild step to the buildApp hook to ensure all plugins finish their builds before we start the preview server.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
e2e/solid-start/basic-cloudflare/src/components/DefaultCatchBoundary.tsx (1)
17-17: Consider adding a descriptive prefix to the error log for consistency.Other similar error boundary components in the codebase use a descriptive prefix (e.g.,
'DefaultCatchBoundary Error:') when logging errors, which aids in debugging and log filtering.Apply this diff to add a descriptive prefix:
- console.error(error) + console.error('DefaultCatchBoundary Error:', error)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (8)
e2e/solid-start/basic-cloudflare/public/android-chrome-192x192.pngis excluded by!**/*.pnge2e/solid-start/basic-cloudflare/public/android-chrome-512x512.pngis excluded by!**/*.pnge2e/solid-start/basic-cloudflare/public/apple-touch-icon.pngis excluded by!**/*.pnge2e/solid-start/basic-cloudflare/public/favicon-16x16.pngis excluded by!**/*.pnge2e/solid-start/basic-cloudflare/public/favicon-32x32.pngis excluded by!**/*.pnge2e/solid-start/basic-cloudflare/public/favicon.icois excluded by!**/*.icoe2e/solid-start/basic-cloudflare/public/favicon.pngis excluded by!**/*.pngpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (20)
e2e/solid-start/basic-cloudflare/.gitignore(1 hunks)e2e/solid-start/basic-cloudflare/package.json(1 hunks)e2e/solid-start/basic-cloudflare/playwright.config.ts(1 hunks)e2e/solid-start/basic-cloudflare/postcss.config.mjs(1 hunks)e2e/solid-start/basic-cloudflare/public/site.webmanifest(1 hunks)e2e/solid-start/basic-cloudflare/src/components/DefaultCatchBoundary.tsx(1 hunks)e2e/solid-start/basic-cloudflare/src/components/NotFound.tsx(1 hunks)e2e/solid-start/basic-cloudflare/src/routeTree.gen.ts(1 hunks)e2e/solid-start/basic-cloudflare/src/router.tsx(1 hunks)e2e/solid-start/basic-cloudflare/src/routes/__root.tsx(1 hunks)e2e/solid-start/basic-cloudflare/src/routes/index.tsx(1 hunks)e2e/solid-start/basic-cloudflare/src/routes/static.tsx(1 hunks)e2e/solid-start/basic-cloudflare/src/styles/app.css(1 hunks)e2e/solid-start/basic-cloudflare/src/utils/seo.ts(1 hunks)e2e/solid-start/basic-cloudflare/tests/app.spec.ts(1 hunks)e2e/solid-start/basic-cloudflare/tests/setup/global.setup.ts(1 hunks)e2e/solid-start/basic-cloudflare/tests/setup/global.teardown.ts(1 hunks)e2e/solid-start/basic-cloudflare/tsconfig.json(1 hunks)e2e/solid-start/basic-cloudflare/vite.config.ts(1 hunks)e2e/solid-start/basic-cloudflare/wrangler.jsonc(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- e2e/solid-start/basic-cloudflare/package.json
- e2e/solid-start/basic-cloudflare/.gitignore
🧰 Additional context used
🧠 Learnings (5)
📚 Learning: 2025-11-02T16:16:24.898Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5732
File: packages/start-client-core/src/client/hydrateStart.ts:6-9
Timestamp: 2025-11-02T16:16:24.898Z
Learning: In packages/start-client-core/src/client/hydrateStart.ts, the `import/no-duplicates` ESLint disable is necessary for imports from `#tanstack-router-entry` and `#tanstack-start-entry` because both aliases resolve to the same placeholder file (`fake-start-entry.js`) in package.json during static analysis, even though they resolve to different files at runtime.
Applied to files:
e2e/solid-start/basic-cloudflare/tsconfig.jsone2e/solid-start/basic-cloudflare/src/routeTree.gen.tse2e/solid-start/basic-cloudflare/tests/setup/global.setup.ts
📚 Learning: 2025-10-08T08:11:47.088Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5402
File: packages/router-generator/tests/generator/no-formatted-route-tree/routeTree.nonnested.snapshot.ts:19-21
Timestamp: 2025-10-08T08:11:47.088Z
Learning: Test snapshot files in the router-generator tests directory (e.g., files matching the pattern `packages/router-generator/tests/generator/**/routeTree*.snapshot.ts` or `routeTree*.snapshot.js`) should not be modified or have issues flagged, as they are fixtures used to verify the generator's output and are intentionally preserved as-is.
Applied to files:
e2e/solid-start/basic-cloudflare/src/router.tsxe2e/solid-start/basic-cloudflare/src/routeTree.gen.ts
📚 Learning: 2025-10-09T12:59:14.842Z
Learnt from: hokkyss
Repo: TanStack/router PR: 5418
File: e2e/react-start/custom-identifier-prefix/public/site.webmanifest:2-3
Timestamp: 2025-10-09T12:59:14.842Z
Learning: In e2e test fixtures (files under e2e directories), empty or placeholder values in configuration files like site.webmanifest are acceptable and should not be flagged unless the test specifically validates those fields.
Applied to files:
e2e/solid-start/basic-cloudflare/tests/app.spec.tse2e/solid-start/basic-cloudflare/public/site.webmanifeste2e/solid-start/basic-cloudflare/playwright.config.ts
📚 Learning: 2025-09-28T21:41:45.233Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5284
File: e2e/react-start/basic/server.js:50-0
Timestamp: 2025-09-28T21:41:45.233Z
Learning: In Express v5, catch-all routes must use named wildcards. Use `/*splat` to match everything except root path, or `/{*splat}` (with braces) to match including root path. The old `*` syntax is not allowed and will cause "Missing parameter name" errors. This breaking change requires explicit naming of wildcard parameters.
Applied to files:
e2e/solid-start/basic-cloudflare/src/routes/__root.tsx
📚 Learning: 2025-10-01T18:31:35.420Z
Learnt from: schiller-manuel
Repo: TanStack/router PR: 5330
File: e2e/react-start/custom-basepath/src/routeTree.gen.ts:58-61
Timestamp: 2025-10-01T18:31:35.420Z
Learning: Do not review files named `routeTree.gen.ts` in TanStack Router repositories, as these are autogenerated files that should not be manually modified.
Applied to files:
e2e/solid-start/basic-cloudflare/src/routeTree.gen.ts
🧬 Code graph analysis (10)
e2e/solid-start/basic-cloudflare/src/components/NotFound.tsx (4)
examples/solid/start-basic-cloudflare/src/components/NotFound.tsx (1)
NotFound(3-25)e2e/solid-start/server-routes/src/components/NotFound.tsx (1)
NotFound(3-25)examples/solid/start-basic-nitro/src/components/NotFound.tsx (1)
NotFound(3-25)e2e/solid-start/basic-solid-query/src/router.tsx (1)
NotFound(16-16)
e2e/solid-start/basic-cloudflare/src/utils/seo.ts (2)
examples/solid/start-basic/src/utils/seo.ts (1)
title(1-33)examples/solid/start-basic-cloudflare/src/utils/seo.ts (1)
title(1-33)
e2e/solid-start/basic-cloudflare/src/components/DefaultCatchBoundary.tsx (3)
e2e/solid-start/server-routes/src/components/DefaultCatchBoundary.tsx (1)
DefaultCatchBoundary(10-53)examples/solid/start-basic-cloudflare/src/components/DefaultCatchBoundary.tsx (1)
DefaultCatchBoundary(10-53)examples/solid/start-basic-nitro/src/components/DefaultCatchBoundary.tsx (1)
DefaultCatchBoundary(10-53)
e2e/solid-start/basic-cloudflare/src/router.tsx (2)
e2e/solid-start/basic-cloudflare/src/components/DefaultCatchBoundary.tsx (1)
DefaultCatchBoundary(10-53)e2e/solid-start/basic-cloudflare/src/components/NotFound.tsx (1)
NotFound(3-25)
e2e/solid-start/basic-cloudflare/tests/setup/global.teardown.ts (1)
scripts/set-ts-version.js (1)
packageJson(33-33)
e2e/solid-start/basic-cloudflare/playwright.config.ts (1)
scripts/set-ts-version.js (1)
packageJson(33-33)
e2e/solid-start/basic-cloudflare/src/routes/__root.tsx (5)
e2e/solid-start/basic-cloudflare/src/routes/index.tsx (1)
Route(5-8)e2e/solid-start/basic-cloudflare/src/routes/static.tsx (1)
Route(5-8)e2e/solid-start/basic-cloudflare/src/utils/seo.ts (1)
seo(1-33)e2e/solid-start/basic-cloudflare/src/components/DefaultCatchBoundary.tsx (1)
DefaultCatchBoundary(10-53)e2e/solid-start/basic-cloudflare/src/components/NotFound.tsx (1)
NotFound(3-25)
e2e/solid-start/basic-cloudflare/src/routes/static.tsx (2)
e2e/solid-start/basic-cloudflare/src/routes/index.tsx (1)
Route(5-8)e2e/solid-start/basic-cloudflare/worker-configuration.d.ts (1)
env(9632-9632)
e2e/solid-start/basic-cloudflare/src/routeTree.gen.ts (1)
e2e/solid-start/basic-cloudflare/src/router.tsx (1)
getRouter(6-16)
e2e/solid-start/basic-cloudflare/src/routes/index.tsx (2)
e2e/solid-start/basic-cloudflare/src/routes/static.tsx (1)
Route(5-8)e2e/solid-start/basic-cloudflare/worker-configuration.d.ts (1)
env(9632-9632)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (20)
e2e/solid-start/basic-cloudflare/src/utils/seo.ts (1)
1-33: LGTM!The SEO utility implementation is consistent with other examples in the codebase and correctly generates meta tags for social media platforms.
e2e/solid-start/basic-cloudflare/postcss.config.mjs (1)
1-5: LGTM!Standard PostCSS configuration for Tailwind CSS integration.
e2e/solid-start/basic-cloudflare/src/styles/app.css (1)
1-30: LGTM!Standard Tailwind CSS base layer configuration with appropriate light/dark mode support.
e2e/solid-start/basic-cloudflare/src/components/DefaultCatchBoundary.tsx (1)
10-52: LGTM!The error boundary component correctly handles errors with appropriate user actions for recovery and navigation.
e2e/solid-start/basic-cloudflare/src/components/NotFound.tsx (1)
1-25: LGTM!The NotFound component is well-structured and consistent with similar implementations across the codebase. The inclusion of the test ID enables proper e2e testing.
e2e/solid-start/basic-cloudflare/tests/app.spec.ts (1)
1-31: LGTM!The test suite effectively validates Cloudflare Workers runtime behavior, including the new prerendering functionality. The prerender test correctly verifies both the build artifact and runtime behavior.
e2e/solid-start/basic-cloudflare/tests/setup/global.teardown.ts (1)
1-6: LGTM!The global teardown function properly cleans up the test server after test execution.
e2e/solid-start/basic-cloudflare/wrangler.jsonc (2)
4-4: Verify the compatibility date is appropriate.The
compatibility_dateis set to2025-09-24, which is about 2 months before the PR creation date (November 2025). Ensure this date aligns with the intended Cloudflare Workers runtime features and behaviors for this test project.
1-10: LGTM!The Wrangler configuration correctly sets up the Cloudflare Workers environment with Node.js compatibility and the required environment variable for testing.
e2e/solid-start/basic-cloudflare/public/site.webmanifest (1)
1-19: LGTM! Empty values are acceptable in e2e test fixtures.The empty
nameandshort_namefields are acceptable for an e2e test fixture, as the test does not validate these specific fields.Based on learnings
e2e/solid-start/basic-cloudflare/tests/setup/global.setup.ts (1)
1-6: LGTM!The test setup is clean and follows the standard pattern for starting the e2e dummy server.
e2e/solid-start/basic-cloudflare/tsconfig.json (1)
1-24: LGTM!The TypeScript configuration is appropriate for a SolidJS project with Cloudflare Workers support. The strict mode, modern module resolution, and path aliases are all configured correctly.
e2e/solid-start/basic-cloudflare/src/router.tsx (1)
6-16: LGTM!The router configuration is clean and follows Solid Router best practices. The settings for preload, error handling, and scroll restoration are all appropriate.
e2e/solid-start/basic-cloudflare/src/routes/__root.tsx (1)
60-86: LGTM!The RootDocument shell component is well-structured with proper hydration setup, head content, and scripts placement.
e2e/solid-start/basic-cloudflare/src/routes/index.tsx (1)
1-27: LGTM!The route implementation correctly uses Cloudflare Workers environment variables and follows Solid Start patterns. The test identifiers will enable reliable e2e testing.
e2e/solid-start/basic-cloudflare/src/routes/static.tsx (1)
1-25: LGTM!The static route implementation is clean and follows the same pattern as the index route. While there is some code duplication with the
getDataserver function, this is acceptable for e2e test fixtures where each route may have different data requirements.e2e/solid-start/basic-cloudflare/vite.config.ts (1)
7-21: LGTM!The Vite configuration is well-structured for Cloudflare Workers with SSR support. The prerender filter correctly targets only the
/staticroute, which aligns with the PR's objective to test prerendering with Cloudflare Workers runtime.e2e/solid-start/basic-cloudflare/playwright.config.ts (2)
11-38: LGTM! Well-structured Playwright configuration.The configuration correctly:
- Uses a single worker to prevent port conflicts during Cloudflare preview server testing
- Wires global setup/teardown for test lifecycle management
- Configures the preview server workflow (
build && preview) which aligns with the PR's objective of using Vite's preview server for prerendering- Sets appropriate server reuse and output handling
3-5: No issues found. Modern syntax features are properly supported.The project's Node.js version (24.4.1, specified in the root
.nvmrc) and ES module configuration ("type": "module"in package.json) fully support both import assertions and top-level await. The configuration is correct as-is.e2e/solid-start/basic-cloudflare/src/routeTree.gen.ts (1)
7-9: Skipping review of autogenerated file.This file is autogenerated by TanStack Router and should not be manually modified. Based on learnings, autogenerated
routeTree.gen.tsfiles are not reviewed.
| sizes: '16x16', | ||
| href: '/favicon-16x16.png', | ||
| }, | ||
| { rel: 'manifest', href: '/site.webmanifest', color: '#fffff' }, |
There was a problem hiding this comment.
Fix the color value typo.
The color value '#fffff' has 5 hexadecimal digits. Valid hex colors should be either 3 digits (#fff) or 6 digits (#ffffff).
Apply this diff to fix the typo:
- { rel: 'manifest', href: '/site.webmanifest', color: '#fffff' },
+ { rel: 'manifest', href: '/site.webmanifest', color: '#ffffff' },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { rel: 'manifest', href: '/site.webmanifest', color: '#fffff' }, | |
| { rel: 'manifest', href: '/site.webmanifest', color: '#ffffff' }, |
🤖 Prompt for AI Agents
In e2e/solid-start/basic-cloudflare/src/routes/__root.tsx around line 51, the
meta object has an invalid color value '#fffff' (5 hex digits); replace it with
a valid hex color such as '#ffffff' (or '#fff') so the color value is 6 (or 3)
hex digits.
|
Thank you @birkskyum! |
|
I'm having issues during prerendering on Cloudflare where it imports my API routes which in turn import my db.ts for Drizzle, which has my Neon Database. It throws an error due to process.env.DATABASE_URL being undefined. This doesn't happen for local builds with pre-rendering, only on Cloudflare. It seems to be throwing away all non VITE_ environment variables, and this is causing errors during the pre-rendering phase specifically on Cloudflare, since it is importing the entire route tree including API routes which might throw when env variables are missing. I was able to suppress it by wrapping my Neon with a try catch, but it doesn't feel right. |
|
It looks like the specific issue is that process.env is not being populated. I see in your example you are using Here it seems that the compatibility option to load in process.env vars as well isn't happening during the prerender. EDIT- even with using { env } binding, I'm still getting the error. db.ts import { env } from "cloudflare:workers"
import { neon } from "@neondatabase/serverless"
import { drizzle } from "drizzle-orm/neon-http"
import * as schema from "./schema"
const sql = neon(env.DATABASE_URL)
export const db = drizzle(sql, { schema })Looks like the issue is that it is not binding my secrets, during the build, specifically: 
23:51:23.795 Your Worker has access to the following bindings:
23:51:23.796 Binding Resource
23:51:23.796 env.FOO ("BAR") Environment Variable |
|
Hi @daveycodez, Thanks for giving it a try! We don't inject runtime variables and secret in the build environment for you at the moment. You will need to set them up in the build settings in the dashboard. I will share this with the CI team to see how we can simplify this further. Just let me know if you run into any issue with prerendering. 👍🏼 |
|
@edmundhung Oh I actually also added them as both Environment Variables & Build variables and they still weren't present during the pre-render phase |
3 participants
This updates prerendering to use Vite's preview server instead of directly importing the server bundle. This makes prerendering runtime-agnostic. It works the same way regardless of whether your server targets Node.js, Cloudflare Workers, or other runtimes. The preview server handles the runtime differences, so the prerendering logic doesn't need to know about them.
This particularly enables Cloudflare projects to prerender with full Workers runtime support and access to all bindings. I have updated the Cloudflare packages (
wranglerand@cloudflare/vite-plugin) to fix a workerd cleanup issue, and added a prerendering test for the Cloudflare e2e project to verify everything works correctly.All existing prerendering tests for Node.js continue to pass, so no additional test coverage was needed there.
The wrangler update (039c805) brings a large amount of generated type definition changes, so it's recommended to review this by commit.
Summary by CodeRabbit
New Features
Build / Runtime
Dependencies
Tests
✏️ Tip: You can customize this high-level summary in your review settings.