Skip to content

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 20, 2025

closes #5923

Summary by CodeRabbit

  • Chores

    • Updated serialization library dependencies to version 1.4.0 across packages for improved stability and performance.
  • Refactor

    • Simplified error message handling by removing unnecessary type casting in the serialization layer.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates seroval and seroval-plugins dependencies from ^1.3.2 to ^1.4.0 across multiple packages to resolve SSR compatibility issues. Additionally, an unnecessary type cast is removed from ShallowErrorPlugin.ts, and a seroval devDependency is removed from an e2e test package.

Changes

Cohort / File(s) Summary
Dependency Version Bumps
packages/router-core/package.json, packages/start-client-core/package.json, packages/start-server-core/package.json, packages/start-static-server-functions/package.json
Updated seroval (and seroval-plugins in router-core) from ^1.3.2 to ^1.4.0 to resolve SSR compatibility with seroval v1.4.0 API changes
Code Refinement
packages/router-core/src/ssr/serializer/ShallowErrorPlugin.ts
Removed unnecessary as string type cast in Error deserialization
Dev Dependency Cleanup
e2e/solid-start/serialization-adapters/package.json
Removed seroval ^1.3.2 devDependency

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • All dependency bumps follow the same pattern across multiple package.json files (homogeneous changes)
  • Single minor code change (type cast removal) with no behavioral impact
  • Changes align directly with resolving known SSR compatibility issue (#5923)

Suggested reviewers

  • lachlancollins

Poem

🐰 A hop, skip, and version bump away,
Seroval 1.4 saves the day!
No more createEffectfulFunction fright,
SSR streams and serialization—all right!
One cast removed, six files aligned,
Dependencies clean, no rope left behind. 🎉

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-seroval-140

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 282cefb and 1e32947.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • e2e/solid-start/serialization-adapters/package.json (0 hunks)
  • packages/router-core/package.json (1 hunks)
  • packages/router-core/src/ssr/serializer/ShallowErrorPlugin.ts (1 hunks)
  • packages/start-client-core/package.json (1 hunks)
  • packages/start-server-core/package.json (1 hunks)
  • packages/start-static-server-functions/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Nov 20, 2025

View your CI Pipeline Execution ↗ for commit 1e32947

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 7m 56s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 31s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-20 20:27:58 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5924

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5924

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5924

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5924

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5924

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5924

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5924

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5924

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5924

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5924

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5924

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5924

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5924

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5924

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5924

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5924

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5924

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5924

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5924

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5924

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5924

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5924

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5924

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5924

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5924

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5924

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5924

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5924

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5924

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5924

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5924

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5924

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5924

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5924

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5924

commit: 1e32947

@birkskyum birkskyum marked this pull request as ready for review November 20, 2025 20:34
@birkskyum birkskyum merged commit d2e9e39 into main Nov 20, 2025
5 of 6 checks passed
@birkskyum birkskyum deleted the bump-seroval-140 branch November 20, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TanStack Router SSR: seroval-plugins version constraint incompatible with seroval v1.4.0

2 participants