Skip to content

Conversation

@vemoo
Copy link
Contributor

@vemoo vemoo commented Dec 5, 2025

fixes #6022

Summary by CodeRabbit

  • Chores
    • Reorganized build tool dependencies across multiple development packages. Development-only build tools have been moved from production dependencies to development-only configuration sections. This change improves overall dependency management, results in cleaner package structures, and ensures more accurate dependency declarations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Walkthrough

Four DevTools packages (react-router-devtools, router-devtools-core, router-devtools, solid-router-devtools) have the vite dependency moved from runtime dependencies to devDependencies, preventing unnecessary package installation for consuming projects.

Changes

Cohort / File(s) Summary
Vite dependency scope adjustment
packages/react-router-devtools/package.json, packages/router-devtools-core/package.json, packages/router-devtools/package.json, packages/solid-router-devtools/package.json
Moved vite (^7.1.7) from dependencies to devDependencies in all four DevTools packages

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple, repetitive configuration changes across 4 files with identical pattern
  • No logic modifications or control flow changes
  • Dependency scope reorganization only

Possibly related PRs

Suggested labels

package: react-router-devtools, package: router-devtools-core, package: router-devtools, package: solid-router-devtools

Suggested reviewers

  • birkskyum
  • lachlancollins
  • brenelz

Poem

🐰 Vite hops away from dependencies bright,
To devDependencies, where tools belong just right,
No more baggage for projects that depend,
Lighter installs, a better end! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and concisely describes the main change: moving vite from dependencies to devDependencies across the router devtools packages.
Linked Issues check ✅ Passed The pull request successfully addresses issue #6022 by moving vite from dependencies to devDependencies in all four affected packages: @tanstack/react-router-devtools, @tanstack/router-devtools, @tanstack/router-devtools-core, and @tanstack/solid-router-devtools.
Out of Scope Changes check ✅ Passed All changes in the pull request are in-scope: only vite dependencies were moved in package.json files across the four devtools packages, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34d13e5 and 680359e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • packages/react-router-devtools/package.json (1 hunks)
  • packages/router-devtools-core/package.json (1 hunks)
  • packages/router-devtools/package.json (1 hunks)
  • packages/solid-router-devtools/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Use workspace protocol for internal dependencies (workspace:*)

Files:

  • packages/router-devtools-core/package.json
  • packages/react-router-devtools/package.json
  • packages/solid-router-devtools/package.json
  • packages/router-devtools/package.json
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T00:18:21.282Z
Learning: Applies to packages/react-router/**/*.{ts,tsx} : React Router components and hooks should use the tanstack/react-router package
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T00:18:21.282Z
Learning: Applies to packages/solid-router/**/*.{ts,tsx} : Solid Router components and primitives should use the tanstack/solid-router package
📚 Learning: 2025-11-25T00:18:21.282Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T00:18:21.282Z
Learning: Applies to packages/solid-router/**/*.{ts,tsx} : Solid Router components and primitives should use the tanstack/solid-router package

Applied to files:

  • packages/router-devtools-core/package.json
  • packages/react-router-devtools/package.json
  • packages/solid-router-devtools/package.json
  • packages/router-devtools/package.json
📚 Learning: 2025-11-25T00:18:21.282Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T00:18:21.282Z
Learning: Applies to packages/react-router/**/*.{ts,tsx} : React Router components and hooks should use the tanstack/react-router package

Applied to files:

  • packages/router-devtools-core/package.json
  • packages/react-router-devtools/package.json
  • packages/solid-router-devtools/package.json
  • packages/router-devtools/package.json
📚 Learning: 2025-11-25T00:18:21.282Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T00:18:21.282Z
Learning: Applies to **/package.json : Use workspace protocol for internal dependencies (workspace:*)

Applied to files:

  • packages/react-router-devtools/package.json
  • packages/solid-router-devtools/package.json
  • packages/router-devtools/package.json
🔇 Additional comments (4)
packages/solid-router-devtools/package.json (1)

69-69: Dependency scoping is correct.

Vite has been appropriately moved from dependencies to devDependencies since it's a build-time tool, not a runtime dependency. The core devtools package remains a runtime dependency, and build scripts retain access to Vite through devDependencies.

Also applies to: 73-73

packages/react-router-devtools/package.json (1)

65-65: Correct dependency organization.

Vite is now appropriately scoped to devDependencies. React and React-DOM are correctly positioned as devDependencies with peer dependency declarations, preventing unnecessary installation for consumers.

Also applies to: 71-71

packages/router-devtools-core/package.json (1)

65-67: Runtime dependencies remain properly scoped.

Vite has been moved to devDependencies while core UI utilities (clsx, goober, tiny-invariant) remain as runtime dependencies. Build-time tooling is correctly isolated from production dependencies.

Also applies to: 71-71

packages/router-devtools/package.json (1)

65-67: Dependency scoping aligns with build-time vs. runtime distinction.

Vite and React build tooling are correctly placed in devDependencies, while the core devtools package and UI utilities (clsx, goober) remain as runtime dependencies. This prevents bloated consumer installations.

Also applies to: 73-73


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Dec 5, 2025

View your CI Pipeline Execution ↗ for commit 680359e

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 8m 10s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-05 20:02:31 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 5, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6026

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@6026

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6026

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6026

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6026

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6026

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6026

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6026

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6026

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6026

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6026

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6026

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6026

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6026

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6026

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6026

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6026

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6026

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6026

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6026

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@6026

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6026

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6026

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6026

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6026

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6026

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6026

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6026

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6026

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6026

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6026

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6026

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6026

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6026

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6026

commit: 680359e

@schiller-manuel schiller-manuel merged commit 7d113ce into TanStack:main Dec 5, 2025
6 checks passed
enBonnet pushed a commit to enBonnet/router that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@tanstack/react-router-devtools should not have vite as a dependency, it should be a devDependency

2 participants