Skip to content

fix: full npm registry URLs, sync package versions #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lachlancollins merged 3 commits into from
Dec 7, 2025
+3,074 −2,117
Merged

fix: full npm registry URLs, sync package versions #6035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9724ba
Update repository URLs
lachlancollins Dec 6, 2025
dcdc99a
Start sherif fixes
lachlancollins Dec 7, 2025
83abc65
Fic CI
lachlancollins Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/react-router/basic-file-based-code-splitting/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"postcss": "^8.5.1",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/basic-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/basic-react-query-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/basic-react-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.17"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/basic-scroll-restoration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.17"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/basic-virtual-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/basic-virtual-named-export-config-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.17"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/generator-cli-only/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.17"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/js-only-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.17"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/rspack-basic-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"postcss": "^8.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2"
}
}
2 changes: 1 addition & 1 deletion e2e/react-router/rspack-basic-virtual-named-export-config-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"postcss": "^8.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2"
}
}
2 changes: 1 addition & 1 deletion e2e/react-router/scroll-restoration-sandbox-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/sentry-integration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.17"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-router/view-transitions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/basic-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"dotenv": "^17.2.3",
"postcss": "^8.5.1",
"prisma": "^7.0.0",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite-tsconfig-paths": "^5.1.4"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/basic-cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"postcss": "^8.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite": "^7.1.7",
"vite-tsconfig-paths": "^5.1.4",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/basic-react-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@vitejs/plugin-react": "^4.3.4",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite-tsconfig-paths": "^5.1.4"
}
Expand Down
36 changes: 0 additions & 36 deletions e2e/react-start/basic-rsc/package.disabled.json
View file
Open in desktop

This file was deleted.

33 changes: 32 additions & 1 deletion e2e/react-start/basic-rsc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,37 @@
{
"name": "tanstack-react-start-e2e-basic-rsc",
"private": true,
"sideEffects": false,
"type": "module",
"scripts": {
"dev": "vite dev",
"build": "exit 0; vite build",
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix the build script — exit 0 prevents vite build from executing.

The build script runs exit 0 which terminates with success status before vite build can execute, effectively disabling the build step. This appears to be a placeholder or workaround.

Apply this diff to enable the build:

-    "build": "exit 0; vite build",
+    "build": "vite build",

If exit 0 was intentional (e.g., for skipping builds in CI), clarify the intent or use a more explicit approach.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"build": "exit 0; vite build",
"build": "vite build",
🤖 Prompt for AI Agents 
In e2e/react-start/basic-rsc/package.json around line 8, the build script
currently uses "exit 0; vite build" which causes the script to exit before
running Vite; remove the leading "exit 0;" so the script runs "vite build" (or,
if skipping builds intentionally, replace with a clear conditional/CI-specific
skip or a no-op script name and document the reason). Ensure package.json's
build script runs the actual build command and update any CI configs if they
relied on the previous placeholder.

"start": "node .output/server/index.mjs"
},
"dependencies": {
"@babel/plugin-syntax-typescript": "^7.25.9",
"@tanstack/react-router": "workspace:^",
"@tanstack/react-router-devtools": "workspace:^",
"@tanstack/react-start": "workspace:^",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"redaxios": "^0.5.1",
"tailwind-merge": "^2.6.0",
"vite": "^7.1.7"
},
"devDependencies": {
"@tailwindcss/postcss": "^4.1.15",
"tailwindcss": "^4.1.15"
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"autoprefixer": "^10.4.20",
"postcss": "^8.5.1",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite-tsconfig-paths": "^5.1.4"
},
"overrides": {
"react": "0.0.0-experimental-035a41c4e-20230704",
"react-dom": "0.0.0-experimental-035a41c4e-20230704"
}
}
2 changes: 1 addition & 1 deletion e2e/react-start/basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"combinate": "^1.1.11",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite": "^7.1.7",
"vite-tsconfig-paths": "^5.1.4",
Expand Down
2 changes: 1 addition & 1 deletion ...t-start/clerk-basic/package.disabled.json → e2e/react-start/clerk-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scripts": {
"dev": "vite dev --port 3000",
"dev:e2e": "vite dev",
"build": "vite build",
"build": "exit 0; vite build",
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

cat -n e2e/react-start/clerk-basic/package.json

Repository: TanStack/router

Length of output: 1418

🏁 Script executed:

# Find other e2e package.json files with similar patterns
fd -t f "package.json" e2e/ --exec grep -l "exit 0" {}

# Also check the git log for context around this change
git log --oneline -n 20 -- e2e/react-start/clerk-basic/package.json

Repository: TanStack/router

Length of output: 262

🏁 Script executed:

# Get full commit message for the "Fix CI" commit
git show 83abc654d --stat

# Check another e2e package.json to see if the pattern is identical
cat -n e2e/react-start/basic-auth/package.json | head -20

Repository: TanStack/router

Length of output: 50372

🏁 Script executed:

# Check another e2e package
cat -n e2e/react-start/basic-auth/package.json | head -15

# Look for any documentation or comments in e2e directory
find e2e -maxdepth 2 -name "README*" -o -name "*.md" | head -10

Repository: TanStack/router

Length of output: 632

🏁 Script executed:

# Check the build scripts specifically in the e2e packages that had exit 0
for file in e2e/react-start/basic-rsc/package.json e2e/solid-start/basic-auth/package.json e2e/e2e-utils/package.json; do
  if [ -f "$file" ]; then
    echo "=== $file ==="
    grep -A2 '"build"' "$file"
  fi
done

Repository: TanStack/router

Length of output: 485

🏁 Script executed:

# Search for any TODOs, FIXMEs, or comments related to exit 0 in the file
cd e2e/react-start/clerk-basic && find . -type f \( -name "*.ts" -o -name "*.tsx" -o -name "*.js" -o -name "*.json" -o -name "*.md" \) -exec grep -l "exit\|build\|publint\|sherif" {} \; 2>/dev/null | head -20

# Also check for any comments in the package.json itself or nearby
cd /repo && cat -n e2e/react-start/clerk-basic/package.json | grep -B2 -A2 "build"

Repository: TanStack/router

Length of output: 169

🏁 Script executed:

# Check playwright.config.ts for any clues
cat -n e2e/react-start/clerk-basic/playwright.config.ts | head -50

# Search git history for when exit 0 was introduced in build scripts
git log --all --oneline --grep="build\|exit" -i | head -20

# Check the specific commit that added these packages
git show 83abc654d --name-only | grep "clerk-basic\|basic-rsc"

Repository: TanStack/router

Length of output: 9589

🏁 Script executed:

# Let me verify the build directory expectations
cat -n e2e/react-start/clerk-basic/package.json | grep -A2 -B2 "start"

# Check if there are any error logs or CI failures related to this
git log --all --oneline --since="2025-12-01" -- e2e/react-start/clerk-basic/ | head -10

Repository: TanStack/router

Length of output: 738

The build script prevents the test server from starting.

The exit 0; vite build pattern exits before Vite builds the application, which is needed for the playwright test server. Since playwright.config.ts runs pnpm build && pnpm start, skipping the build means the .output/server/index.mjs file won't exist and the server startup will fail. This will break all e2e tests for this package.

Either:

  1. Remove the exit 0; prefix to allow the actual build to run
  2. If intentionally disabling builds, explain why and update the test configuration accordingly
  3. If this is a temporary CI workaround, add a TODO comment with context and a ticket reference
🤖 Prompt for AI Agents 
In e2e/react-start/clerk-basic/package.json around line 9, the build script uses
"exit 0; vite build" which prevents Vite from actually producing the build
artifacts required by the Playwright test server; remove the "exit 0;" prefix so
the script runs the real build (i.e., change to just run the build command), or
if builds must be disabled intentionally, add a clear TODO comment with
rationale and ticket reference and update playwright.config.ts to not run pnpm
build (or to skip this package) so tests don't expect .output/server/index.mjs.

"start": "node .output/server/index.mjs",
"test:e2e": "exit 0; rm -rf port*.txt; playwright test --project=chromium"
},
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/custom-basepath/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"cross-env": "^10.0.0",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"tsx": "^4.20.3",
"typescript": "^5.7.2",
"vite": "^7.1.7",
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/query-integration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@types/react-dom": "^19.0.3",
"@vitejs/plugin-react": "^4.3.4",
"postcss": "^8.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite-tsconfig-paths": "^5.1.4"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/scroll-restoration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"combinate": "^1.1.11",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite-tsconfig-paths": "^5.1.4"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/selective-ssr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@vitejs/plugin-react": "^4.3.4",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2"
}
}
2 changes: 1 addition & 1 deletion e2e/react-start/serialization-adapters/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@vitejs/plugin-react": "^4.3.4",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2"
}
}
2 changes: 1 addition & 1 deletion e2e/react-start/server-functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"combinate": "^1.1.11",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite-tsconfig-paths": "^5.1.4"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/server-routes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"combinate": "^1.1.11",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite-tsconfig-paths": "^5.1.4"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/spa-mode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"postcss": "^8.5.1",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite": "^7.1.7",
"vite-tsconfig-paths": "^5.1.4"
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/virtual-routes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"combinate": "^1.1.11",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite-tsconfig-paths": "^5.1.4"
}
Expand Down
2 changes: 1 addition & 1 deletion e2e/react-start/website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@vitejs/plugin-react": "^4.3.4",
"postcss": "^8.5.1",
"srvx": "^0.8.6",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"typescript": "^5.7.2",
"vite": "^7.1.7",
"vite-tsconfig-paths": "^5.1.4"
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-router/basic-file-based-code-splitting/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@tanstack/solid-router-devtools": "workspace:^",
"postcss": "^8.5.1",
"solid-js": "^1.9.10",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-router/basic-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"postcss": "^8.5.1",
"redaxios": "^0.5.1",
"solid-js": "^1.9.10",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion e2e/solid-router/basic-scroll-restoration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"postcss": "^8.5.1",
"redaxios": "^0.5.1",
"solid-js": "^1.9.10",
"tailwindcss": "^4.1.15"
"tailwindcss": "^4.1.17"
},
"devDependencies": {
"@playwright/test": "^1.50.1",
Expand Down
4 changes: 2 additions & 2 deletions e2e/solid-router/basic-solid-query-file-based/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
"@tailwindcss/postcss": "^4.1.15",
"@tanstack/router-plugin": "workspace:^",
"@tanstack/solid-query": "^5.90.9",
"@tanstack/solid-query-devtools": "^5.71.9",
"@tanstack/solid-query-devtools": "^5.90.0",
"@tanstack/solid-router": "workspace:^",
"@tanstack/solid-router-devtools": "workspace:^",
"postcss": "^8.5.1",
"redaxios": "^0.5.1",
"solid-js": "^1.9.10",
"tailwindcss": "^4.1.15",
"tailwindcss": "^4.1.17",
"zod": "^3.24.2"
},
"devDependencies": {
Expand Down
Loading
Loading