Skip to content

Conversation

@lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Dec 7, 2025

Figure this is worth doing for a new package before deployment!

Summary by CodeRabbit

  • Chores
    • Standardized build configs across packages for more consistent bundling and plugin setup.
  • Breaking Changes
    • Packages no longer publish CommonJS entry points — distribution now targets modern ESM-only consumers.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

Vite configs updated across three packages: entry values changed to arrays, cjs: false added, and explicit plugins typing removed. Inline test config and package.json import removed from one vite.config. Package.json files for three packages removed CommonJS main/require entries and require-style export mappings.

Changes

Cohort / File(s) Summary
Vite config standardization
packages/vue-router-devtools/vite.config.ts, packages/vue-router-ssr-query/vite.config.ts, packages/vue-router/vite.config.ts
Updated tanstackViteConfig calls: entry changed from a string to an array (e.g., './src/index.tsx'['./src/index.tsx']), added cjs: false, and removed TypeScript type assertion on plugins
Test config removal
packages/vue-router-ssr-query/vite.config.ts
Removed inline test configuration block and removed the package.json import used by that block
Package exports (remove CJS)
packages/vue-router-devtools/package.json, packages/vue-router-ssr-query/package.json, packages/vue-router/package.json
Removed top-level main pointing at dist/cjs/index.cjs and removed require/CommonJS branches under exports, leaving only ESM/import export entries

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Pay attention to package.json export changes (impact on consumers, types paths).
  • Verify vite.config changes produce intended build outputs (cjs disabled) and that plugins remain compatible.
  • Confirm removed test block has been relocated or intentionally dropped.

Possibly related PRs

Suggested reviewers

  • birkskyum

Poem

🐰 I nibbled lines of package.json,

Strings turned arrays, CJS undone,
Tests hopped out to greener fields,
Exports trimmed to lighter yields,
A tidy patch — a rabbit's run.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(vue): disable CJS build' accurately describes the main change—removing CommonJS build configuration from the Vue packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vue-cjs

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4078db and daf633b.

📒 Files selected for processing (3)
  • packages/vue-router-devtools/package.json (0 hunks)
  • packages/vue-router-ssr-query/package.json (0 hunks)
  • packages/vue-router/package.json (0 hunks)
💤 Files with no reviewable changes (3)
  • packages/vue-router/package.json
  • packages/vue-router-devtools/package.json
  • packages/vue-router-ssr-query/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Preview
  • GitHub Check: Test

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Dec 7, 2025

View your CI Pipeline Execution ↗ for commit daf633b

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 2m 24s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-07 01:20:05 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 7, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6036

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@6036

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6036

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6036

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6036

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6036

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6036

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6036

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6036

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6036

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6036

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6036

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6036

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6036

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6036

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6036

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6036

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6036

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6036

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6036

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@6036

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6036

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6036

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6036

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6036

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6036

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6036

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6036

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6036

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6036

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6036

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6036

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6036

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6036

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6036

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6036

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6036

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6036

commit: daf633b

@lachlancollins lachlancollins merged commit c7fc110 into main Dec 7, 2025
6 checks passed
@lachlancollins lachlancollins deleted the vue-cjs branch December 7, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants