feat: use lit-store internally instead of reyling on vanilla store dependency

[fredericbahr]

Summary by CodeRabbit

• Chores
  • Updated @tanstack/lit-store dependency to version 0.13.2.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR migrates lit-table from @tanstack/store to @tanstack/lit-store@^0.13.2, updating imports and refactoring TableController.Subscribe to use TanStackStoreSelector for reactive state selection instead of inline direct source access.

Changes

Store package migration and selector refactoring

Layer / File(s)	Summary
Dependency and import migration to @tanstack/lit-store packages/lit-table/package.json, packages/lit-table/src/TableController.ts, packages/lit-table/src/reactivity.ts	Package dependency updated to @tanstack/lit-store@^0.13.2. Type imports for Atom, ReadonlyAtom, Store, and ReadonlyStore now reference the new package in TableController. Reactivity module imports batch and createAtom from the new package.
Subscribe implementation with TanStackStoreSelector packages/lit-table/src/TableController.ts	Subscribe function now constructs a TanStackStoreSelector via the new _getOrCreateSelector helper and uses storeSelector.value as the selected state passed to children, replacing the previous inline source.get() + selector application pattern.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A store refresh hops into view,
From tanstack's old to the new,
Selectors now dance in lit's light,
Each subscription shines bright—
A cleaner path through the code's delight!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: migrating from vanilla store to lit-store as an internal dependency across the lit-table package.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​tanstack/​lit-store@​0.13.2

View full report

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/lit-table/src/TableController.ts`:
- Around line 217-218: Cache and reuse selector instances per source/selector
pair to avoid creating a new TanStackStoreSelector on every Subscribe call: add
a private two-level cache field (e.g., _selectorCache: WeakMap<any, Map<any,
TanStackStoreSelector<unknown>>> ) on TableController, update
_getOrCreateSelector(source, selector) to look up and return an existing
instance from _selectorCache[source].get(selector) or create, store, and return
a new one; ensure keys use the raw selector object/function (handle undefined
selectors consistently). Also update hostDisconnected (or appropriate teardown)
to remove the source entry from _selectorCache so entries can be
garbage-collected when a source is gone.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a4fff87a-9368-42bf-8177-7772f2a4b78d

📥 Commits

Reviewing files that changed from the base of the PR and between 05f3ed1 and 275b166.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)

• packages/lit-table/package.json
• packages/lit-table/src/TableController.ts
• packages/lit-table/src/reactivity.ts

[coderabbitai]

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Locate TanStackStoreSelector implementation =="
selector_files="$(fd -i 'TanStackStoreSelector.*\.ts$' || true)"
if [ -z "${selector_files}" ]; then
  echo "No TanStackStoreSelector source file found in-repo (may be external package)."
else
  while IFS= read -r f; do
    echo "---- $f ----"
    rg -n -C3 'class\s+TanStackStoreSelector|addController\(|subscribe\(|unsubscribe\(' "$f"
  done <<< "${selector_files}"
fi

echo
echo "== Inspect creation sites in TableController =="
rg -n -C3 '_getOrCreateSelector|new TanStackStoreSelector|storeSelector\.value' packages/lit-table/src/TableController.ts

Repository: TanStack/table

Length of output: 1193

---

🏁 Script executed:

cat -n packages/lit-table/src/TableController.ts | head -n 320 | tail -n 100

Repository: TanStack/table

Length of output: 3667

---

🏁 Script executed:

rg -n 'import.*TanStackStoreSelector|from.*TanStackStoreSelector' packages/lit-table/src/TableController.ts

Repository: TanStack/table

Length of output: 120

---

Cache selector instances; new instance created on every Subscribe call.

Line 279 creates a fresh TanStackStoreSelector on each Subscribe invocation. The TODO comment on line 269 acknowledges this concern. In render-heavy usage, this accumulates controller and subscription instances without cleanup, since hostDisconnected only cleans up the main store subscriptions, not these selector instances.

Implement a two-level cache using WeakMap<source, Map<selector, instance>> to reuse instances per (source, selector) pair. The WeakMap ensures the cache is garbage-collected when sources are no longer referenced.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/lit-table/src/TableController.ts` around lines 217 - 218, Cache and
reuse selector instances per source/selector pair to avoid creating a new
TanStackStoreSelector on every Subscribe call: add a private two-level cache
field (e.g., _selectorCache: WeakMap<any, Map<any,
TanStackStoreSelector<unknown>>> ) on TableController, update
_getOrCreateSelector(source, selector) to look up and return an existing
instance from _selectorCache[source].get(selector) or create, store, and return
a new one; ensure keys use the raw selector object/function (handle undefined
selectors consistently). Also update hostDisconnected (or appropriate teardown)
to remove the source entry from _selectorCache so entries can be
garbage-collected when a source is gone.