Skip to content

feat: drop the underscore. It's cleaner#6296

Merged
KevinVandy merged 2 commits into
betafrom
drop-_
Jun 5, 2026
Merged

feat: drop the underscore. It's cleaner#6296
KevinVandy merged 2 commits into
betafrom
drop-_

Conversation

@KevinVandy
Copy link
Copy Markdown
Member

@KevinVandy KevinVandy commented Jun 5, 2026

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026 •
edited
Loading

Important

Review skipped

Too many files!

This PR contains 300 files, which is 150 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ccffa2bc-c0e2-4fc8-b009-8eae2410d332

📥 Commits

Reviewing files that changed from the base of the PR and between f152e7d and 801b54e.

📒 Files selected for processing (300)
  • _artifacts/domain_map.yaml
  • _artifacts/scratch/cluster-a-foundational.yaml
  • _artifacts/scratch/cluster-b-row-model-features.yaml
  • _artifacts/scratch/cluster-c-ui-state-features.yaml
  • _artifacts/scratch/cluster-d-framework-adapters.yaml
  • _artifacts/scratch/cluster-e-lifecycle-composition.yaml
  • _artifacts/scratch/cluster-f-issues-failure-modes.yaml
  • _artifacts/skill_spec.md
  • _artifacts/skill_tree.yaml
  • docs/framework/angular/angular-table.md
  • docs/framework/angular/guide/migrating.md
  • docs/framework/angular/guide/rendering.md
  • docs/framework/angular/guide/table-composition.md
  • docs/framework/angular/guide/table-state.md
  • docs/framework/angular/reference/functions/createTableHook.md
  • docs/framework/angular/reference/functions/injectTable.md
  • docs/framework/angular/reference/type-aliases/CreateTableHookResult.md
  • docs/framework/lit/guide/table-state.md
  • docs/framework/lit/lit-table.md
  • docs/framework/lit/reference/classes/TableController.md
  • docs/framework/lit/reference/functions/createTableHook.md
  • docs/framework/preact/guide/create-table-hook.md
  • docs/framework/preact/guide/table-state.md
  • docs/framework/preact/preact-table.md
  • docs/framework/preact/reference/functions/createTableHook.md
  • docs/framework/preact/reference/functions/useTable.md
  • docs/framework/react/guide/create-table-hook.md
  • docs/framework/react/guide/migrating.md
  • docs/framework/react/guide/table-state.md
  • docs/framework/react/guide/use-legacy-table.md
  • docs/framework/react/react-table.md
  • docs/framework/react/reference/index/functions/createTableHook.md
  • docs/framework/react/reference/index/functions/useTable.md
  • docs/framework/react/reference/legacy/functions/useLegacyTable.md
  • docs/framework/react/reference/legacy/interfaces/LegacyRowModelOptions.md
  • docs/framework/react/reference/legacy/type-aliases/LegacyTableOptions.md
  • docs/framework/solid/guide/table-state.md
  • docs/framework/solid/reference/functions/createTable.md
  • docs/framework/solid/reference/functions/createTableHook.md
  • docs/framework/solid/solid-table.md
  • docs/framework/svelte/guide/table-state.md
  • docs/framework/svelte/reference/functions/createTable.md
  • docs/framework/svelte/reference/functions/createTableHook.md
  • docs/framework/svelte/svelte-table.md
  • docs/framework/vanilla/guide/table-state.md
  • docs/framework/vue/guide/table-state.md
  • docs/framework/vue/reference/functions/createTableHook.md
  • docs/framework/vue/reference/functions/useTable.md
  • docs/framework/vue/vue-table.md
  • docs/guide/column-defs.md
  • docs/guide/column-faceting.md
  • docs/guide/column-filtering.md
  • docs/guide/column-ordering.md
  • docs/guide/column-pinning.md
  • docs/guide/column-resizing.md
  • docs/guide/column-sizing.md
  • docs/guide/column-visibility.md
  • docs/guide/custom-features.md
  • docs/guide/data.md
  • docs/guide/expanding.md
  • docs/guide/features.md
  • docs/guide/fuzzy-filtering.md
  • docs/guide/global-faceting.md
  • docs/guide/global-filtering.md
  • docs/guide/grouping.md
  • docs/guide/pagination.md
  • docs/guide/row-models.md
  • docs/guide/row-selection.md
  • docs/guide/rows.md
  • docs/guide/sorting.md
  • docs/guide/tables.md
  • docs/reference/index/functions/createColumnHelper.md
  • docs/reference/index/functions/tableFeatures.md
  • docs/reference/index/functions/tableOptions.md
  • docs/reference/index/interfaces/TableOptions_Core.md
  • docs/reference/index/interfaces/TableOptions_Table.md
  • docs/reference/index/interfaces/Table_CoreProperties.md
  • docs/reference/index/interfaces/Table_RowModels_Faceted.md
  • docs/reference/index/interfaces/Table_Table.md
  • docs/reference/index/type-aliases/Table.md
  • docs/reference/index/type-aliases/Table_Internal.md
  • docs/reference/static-functions/functions/table_getCoreRowModel.md
  • examples/angular/basic-app-table/src/app/app.ts
  • examples/angular/basic-external-atoms/src/app/app.ts
  • examples/angular/basic-external-state/src/app/app.ts
  • examples/angular/basic-inject-table/src/app/app.ts
  • examples/angular/column-groups/src/app/app.ts
  • examples/angular/column-ordering/src/app/app.ts
  • examples/angular/column-pinning-split/src/app/app.ts
  • examples/angular/column-pinning-sticky/src/app/app.ts
  • examples/angular/column-pinning/src/app/app.ts
  • examples/angular/column-resizing-performant/src/app/app.ts
  • examples/angular/column-resizing/src/app/app.ts
  • examples/angular/column-sizing/src/app/app.ts
  • examples/angular/column-visibility/src/app/app.ts
  • examples/angular/composable-tables/src/app/table.ts
  • examples/angular/custom-plugin/src/app/app.ts
  • examples/angular/editable/src/app/app.ts
  • examples/angular/expanding/src/app/app.ts
  • examples/angular/expanding/src/app/expandable-cell/expandable-cell.ts
  • examples/angular/filters-faceted/src/app/app.ts
  • examples/angular/filters-faceted/src/app/table-filter/table-filter.ts
  • examples/angular/filters-fuzzy/src/app/app.ts
  • examples/angular/filters/src/app/app.ts
  • examples/angular/filters/src/app/table-filter/table-filter.ts
  • examples/angular/grouping/src/app/columns.ts
  • examples/angular/kitchen-sink/src/app/app.ts
  • examples/angular/kitchen-sink/src/app/table-filter/table-filter.ts
  • examples/angular/pagination/src/app/app.ts
  • examples/angular/remote-data/src/app/app.ts
  • examples/angular/row-dnd/src/app/app.ts
  • examples/angular/row-pinning/src/app/app.ts
  • examples/angular/row-selection-signal/src/app/app.component.ts
  • examples/angular/row-selection/src/app/table.ts
  • examples/angular/signal-input/src/app/person-table/person-table.ts
  • examples/angular/sorting/src/app/app.ts
  • examples/angular/sub-components/src/app/app.ts
  • examples/angular/virtualized-columns/src/app/app.ts
  • examples/angular/virtualized-infinite-scrolling/src/app/app.ts
  • examples/angular/virtualized-rows/src/app/app.ts
  • examples/angular/with-tanstack-form/src/app/app.ts
  • examples/angular/with-tanstack-query/src/app/app.ts
  • examples/lit/basic-app-table/src/main.ts
  • examples/lit/basic-external-atoms/src/main.ts
  • examples/lit/basic-external-state/src/main.ts
  • examples/lit/basic-table-controller/src/main.ts
  • examples/lit/column-groups/src/main.ts
  • examples/lit/column-ordering/src/main.ts
  • examples/lit/column-pinning-split/src/main.ts
  • examples/lit/column-pinning-sticky/src/main.ts
  • examples/lit/column-pinning/src/main.ts
  • examples/lit/column-resizing-performant/src/main.ts
  • examples/lit/column-resizing/src/main.ts
  • examples/lit/column-sizing/src/main.ts
  • examples/lit/column-visibility/src/main.ts
  • examples/lit/composable-tables/src/components/users-table.ts
  • examples/lit/composable-tables/src/hooks/table.ts
  • examples/lit/expanding/src/main.ts
  • examples/lit/filters-faceted/src/main.ts
  • examples/lit/filters-fuzzy/src/main.ts
  • examples/lit/filters/src/main.ts
  • examples/lit/grouping/src/main.ts
  • examples/lit/kitchen-sink/src/main.ts
  • examples/lit/pagination/src/main.ts
  • examples/lit/row-pinning/src/main.ts
  • examples/lit/row-selection/src/main.ts
  • examples/lit/sorting-dynamic-data/src/main.ts
  • examples/lit/sorting/src/main.ts
  • examples/lit/sub-components/src/main.ts
  • examples/lit/virtualized-columns/src/main.ts
  • examples/lit/virtualized-infinite-scrolling/src/main.ts
  • examples/lit/virtualized-rows/src/main.ts
  • examples/preact/basic-external-atoms/src/main.tsx
  • examples/preact/basic-external-state/src/main.tsx
  • examples/preact/basic-subscribe/src/main.tsx
  • examples/preact/basic-use-app-table/src/main.tsx
  • examples/preact/basic-use-table/src/main.tsx
  • examples/preact/column-groups/src/main.tsx
  • examples/preact/column-ordering/src/main.tsx
  • examples/preact/column-pinning-split/src/main.tsx
  • examples/preact/column-pinning-sticky/src/main.tsx
  • examples/preact/column-pinning/src/main.tsx
  • examples/preact/column-resizing-performant/src/main.tsx
  • examples/preact/column-resizing/src/main.tsx
  • examples/preact/column-sizing/src/main.tsx
  • examples/preact/column-visibility/src/main.tsx
  • examples/preact/composable-tables/src/hooks/table.ts
  • examples/preact/composable-tables/src/main.tsx
  • examples/preact/custom-plugin/src/main.tsx
  • examples/preact/expanding/src/main.tsx
  • examples/preact/filters-faceted/src/main.tsx
  • examples/preact/filters-fuzzy/src/main.tsx
  • examples/preact/filters/src/main.tsx
  • examples/preact/grouping/src/main.tsx
  • examples/preact/kitchen-sink/src/main.tsx
  • examples/preact/pagination/src/main.tsx
  • examples/preact/row-pinning/src/main.tsx
  • examples/preact/row-selection/src/main.tsx
  • examples/preact/sorting/src/main.tsx
  • examples/preact/sub-components/src/main.tsx
  • examples/preact/with-tanstack-query/src/main.tsx
  • examples/react/basic-external-atoms/src/main.tsx
  • examples/react/basic-external-state/src/main.tsx
  • examples/react/basic-subscribe/src/main.tsx
  • examples/react/basic-use-app-table/src/main.tsx
  • examples/react/basic-use-legacy-table/src/main.tsx
  • examples/react/basic-use-table/src/main.tsx
  • examples/react/column-dnd/src/main.tsx
  • examples/react/column-groups/src/main.tsx
  • examples/react/column-ordering/src/main.tsx
  • examples/react/column-pinning-split/src/main.tsx
  • examples/react/column-pinning-sticky/src/main.tsx
  • examples/react/column-pinning/src/main.tsx
  • examples/react/column-resizing-performant/src/main.tsx
  • examples/react/column-resizing/src/main.tsx
  • examples/react/column-sizing/src/main.tsx
  • examples/react/column-visibility/src/main.tsx
  • examples/react/composable-tables/README.md
  • examples/react/composable-tables/src/hooks/table.ts
  • examples/react/composable-tables/src/main.tsx
  • examples/react/custom-plugin/src/main.tsx
  • examples/react/expanding/src/main.tsx
  • examples/react/filters-faceted/src/main.tsx
  • examples/react/filters-fuzzy/src/main.tsx
  • examples/react/filters/src/main.tsx
  • examples/react/grouping/src/main.tsx
  • examples/react/kitchen-sink-hero-ui/src/main.tsx
  • examples/react/kitchen-sink-mantine/src/main.tsx
  • examples/react/kitchen-sink-material-ui/src/main.tsx
  • examples/react/kitchen-sink-react-aria/src/main.tsx
  • examples/react/kitchen-sink-shadcn-base/src/main.tsx
  • examples/react/kitchen-sink-shadcn-radix/src/main.tsx
  • examples/react/kitchen-sink/src/main.tsx
  • examples/react/lib-hero-ui/src/main.tsx
  • examples/react/lib-mantine/src/main.tsx
  • examples/react/lib-material-ui/src/main.tsx
  • examples/react/lib-react-aria/src/main.tsx
  • examples/react/lib-shadcn-base/src/main.tsx
  • examples/react/lib-shadcn-radix/src/main.tsx
  • examples/react/mantine-react-table/README.md
  • examples/react/mantine-react-table/src/mantine-react-table/hooks/useMRT_TableOptions.ts
  • examples/react/material-react-table/README.md
  • examples/react/material-react-table/src/material-react-table/hooks/useMRT_TableOptions.ts
  • examples/react/pagination/src/main.tsx
  • examples/react/row-dnd/src/main.tsx
  • examples/react/row-pinning/src/main.tsx
  • examples/react/row-selection/src/main.tsx
  • examples/react/sorting/src/main.tsx
  • examples/react/sub-components/src/main.tsx
  • examples/react/virtualized-columns-experimental/src/main.tsx
  • examples/react/virtualized-columns/src/main.tsx
  • examples/react/virtualized-infinite-scrolling/src/main.tsx
  • examples/react/virtualized-rows-experimental/src/main.tsx
  • examples/react/virtualized-rows/src/main.tsx
  • examples/react/with-tanstack-form/src/main.tsx
  • examples/react/with-tanstack-query/src/main.tsx
  • examples/react/with-tanstack-router/src/components/table.tsx
  • examples/solid/basic-app-table/src/App.tsx
  • examples/solid/basic-external-atoms/src/App.tsx
  • examples/solid/basic-external-state/src/App.tsx
  • examples/solid/basic-use-table/src/App.tsx
  • examples/solid/column-groups/src/App.tsx
  • examples/solid/column-ordering/src/App.tsx
  • examples/solid/column-pinning-split/src/App.tsx
  • examples/solid/column-pinning-sticky/src/App.tsx
  • examples/solid/column-pinning/src/App.tsx
  • examples/solid/column-resizing-performant/src/App.tsx
  • examples/solid/column-resizing/src/App.tsx
  • examples/solid/column-sizing/src/App.tsx
  • examples/solid/column-visibility/src/App.tsx
  • examples/solid/composable-tables/src/App.tsx
  • examples/solid/composable-tables/src/hooks/table.ts
  • examples/solid/expanding/src/App.tsx
  • examples/solid/filters-faceted/src/App.tsx
  • examples/solid/filters-faceted/src/ColumnFilter.tsx
  • examples/solid/filters-fuzzy/src/App.tsx
  • examples/solid/filters/src/App.tsx
  • examples/solid/filters/src/ColumnFilter.tsx
  • examples/solid/grouping/src/App.tsx
  • examples/solid/kitchen-sink/src/App.tsx
  • examples/solid/pagination/src/App.tsx
  • examples/solid/row-pinning/src/App.tsx
  • examples/solid/row-selection/src/App.tsx
  • examples/solid/sorting/src/App.tsx
  • examples/solid/sub-components/src/App.tsx
  • examples/solid/virtualized-columns/src/App.tsx
  • examples/solid/virtualized-infinite-scrolling/src/App.tsx
  • examples/solid/virtualized-rows/src/App.tsx
  • examples/solid/with-tanstack-form/src/App.tsx
  • examples/solid/with-tanstack-query/src/App.tsx
  • examples/solid/with-tanstack-router/src/components/table.tsx
  • examples/svelte/basic-app-table/src/App.svelte
  • examples/svelte/basic-create-table/src/App.svelte
  • examples/svelte/basic-external-atoms/src/App.svelte
  • examples/svelte/basic-external-state/src/App.svelte
  • examples/svelte/basic-snippets/src/App.svelte
  • examples/svelte/column-groups/src/App.svelte
  • examples/svelte/column-ordering/src/App.svelte
  • examples/svelte/column-pinning-split/src/App.svelte
  • examples/svelte/column-pinning-sticky/src/App.svelte
  • examples/svelte/column-pinning/src/App.svelte
  • examples/svelte/column-resizing-performant/src/App.svelte
  • examples/svelte/column-resizing/src/App.svelte
  • examples/svelte/column-sizing/src/App.svelte
  • examples/svelte/column-visibility/src/App.svelte
  • examples/svelte/composable-tables/src/components/UsersTable.svelte
  • examples/svelte/composable-tables/src/hooks/table.ts
  • examples/svelte/expanding/src/App.svelte
  • examples/svelte/filtering/src/App.svelte
  • examples/svelte/filters-faceted/src/App.svelte
  • examples/svelte/filters-fuzzy/src/App.svelte
  • examples/svelte/grouping/src/App.svelte
  • examples/svelte/kitchen-sink/src/App.svelte
  • examples/svelte/pagination/src/App.svelte
  • examples/svelte/row-pinning/src/App.svelte
  • examples/svelte/row-selection/src/App.svelte
  • examples/svelte/sorting/src/App.svelte
  • examples/svelte/sorting/src/tableHelper.svelte.ts
  • examples/svelte/sub-components/src/App.svelte
  • examples/svelte/virtualized-columns/src/App.svelte

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drop-_

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 5, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 82c1ac1

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 4m 17s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 26s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-06-05 18:34:32 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 5, 2026 •
edited
Loading

More templates

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6296

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6296

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6296

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6296

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6296

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6296

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6296

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6296

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6296

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6296

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6296

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6296

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6296

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6296

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6296

commit: 801b54e

@KevinVandy KevinVandy merged commit 60e4d7b into beta Jun 5, 2026
9 checks passed
@KevinVandy KevinVandy deleted the drop-_ branch June 5, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KevinVandy