-
-
Notifications
You must be signed in to change notification settings - Fork 372
perf: stop shipping full blog post content to every client bundle #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0218d7e
Refactor blog utilities: move formatting functions to blog-format module
LadyBluenotes 37eb0cf
format
LadyBluenotes c0714f8
Enhance CategoryArticle to support related posts and refactor fetchin…
LadyBluenotes 4df165e
Refactor blog post fetching: replace getPostsForLibrary with fetchPos…
LadyBluenotes 6eff051
format
LadyBluenotes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import { findLibrary, type LibrarySlim } from '~/libraries' | ||
|
|
||
| const listJoiner = new Intl.ListFormat('en-US', { | ||
| style: 'long', | ||
| type: 'conjunction', | ||
| }) | ||
|
|
||
| export function formatAuthors(authors: Array<string>) { | ||
| if (!authors.length) { | ||
| return 'TanStack' | ||
| } | ||
|
|
||
| return listJoiner.format(authors) | ||
| } | ||
|
|
||
| function getUtcDateString(date = new Date()) { | ||
| return date.toISOString().slice(0, 10) | ||
| } | ||
|
|
||
| function parsePublishedDate(published: string) { | ||
| const [year, month, day] = published.split('-').map(Number) | ||
|
|
||
| return new Date(Date.UTC(year, month - 1, day, 12)) | ||
| } | ||
|
|
||
| export function formatPublishedDate(published: string) { | ||
| return parsePublishedDate(published).toLocaleDateString('en-US', { | ||
| timeZone: 'UTC', | ||
| year: 'numeric', | ||
| month: 'short', | ||
| day: 'numeric', | ||
| }) | ||
| } | ||
|
|
||
| export function isPublishedDateReleased(published: string, now = new Date()) { | ||
| return published <= getUtcDateString(now) | ||
| } | ||
|
|
||
| export function publishedDateToUTCString(published: string) { | ||
| return parsePublishedDate(published).toUTCString() | ||
| } | ||
|
|
||
| function isLibrarySlim( | ||
| library: LibrarySlim | undefined, | ||
| ): library is LibrarySlim { | ||
| return library !== undefined | ||
| } | ||
|
|
||
| export function getBlogLibraries(library: string | undefined): LibrarySlim[] { | ||
| if (!library) { | ||
| return [] | ||
| } | ||
|
|
||
| return library | ||
| .split(',') | ||
| .map((libraryId) => findLibrary(libraryId.trim())) | ||
| .filter(isLibrarySlim) | ||
| } | ||
|
|
||
| export function getDistinctAuthors( | ||
| posts: ReadonlyArray<{ authors: string[] }>, | ||
| ): string[] { | ||
| const authors = new Set<string>() | ||
| for (const post of posts) { | ||
| for (const author of post.authors) { | ||
| authors.add(author) | ||
| } | ||
| } | ||
| return [...authors].sort((a, b) => a.localeCompare(b)) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Pin locale for deterministic sort order.
localeComparewithout an explicit locale depends on the runtime's default locale, which can differ between server (SSR) and client (hydration), causing non-deterministic author ordering and potential hydration mismatches.formatAuthorsin this same file already pins locale ('en-US') for this reason — apply the same here.🌐 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents