Skip to content

Conversation

@SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented May 3, 2025

This has to do with the "Edit on GitHub" link that we place at the moment of our markdown documents.

Previously, this link took the user to "view" the markdown document on GitHub.

image

With this change, the new link takes the user to a view designed by GitHub to encourage more native flows towards making edits.

If the user already has write-access on GitHub (which they most likely won't), then they can start making changes.

image

If not, the user will be asked to fork the repository, before they can begin making changes and opening a pull request (which they'd have to do anyways).

image

@netlify
Copy link

netlify bot commented May 3, 2025

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit 3d3c5a0
🔍 Latest deploy log https://app.netlify.com/sites/tanstack/deploys/681976e7af076100082ad4ed
😎 Deploy Preview https://deploy-preview-397--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 36 (🔴 down 4 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (no change from production)
SEO: 77 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lachlancollins lachlancollins merged commit c20a741 into main May 6, 2025
5 of 6 checks passed
@lachlancollins lachlancollins deleted the fix-markdown-edit-link branch May 6, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants