Skip to content

Conversation

@nrjdalal
Copy link

@nrjdalal nrjdalal commented May 31, 2025

  • migrate from tailwind v3 to v4
  • enhance usage area on mobile and desktop
  • dropped shadows, used border and scale
  • fixed broken text alignment and area usage in home cards
  • fix: prettier and added tailwindcss sorting
  • enabled non working pnpm run format/lint
  • attached images for visual changes, beside that, just fixed alignment of docs, when there's no TOC things are not centered or small-width (visual transition has no layout shifts)
  • preview: https://tanstack-com.vercel.app

Screenshot 2025-06-01 at 9 07 30 AM


Screenshot 2025-06-01 at 3 48 00 AM


Screenshot 2025-06-01 at 3 50 44 AM
Screenshot 2025-06-01 at 6 19 42 AM

@netlify
Copy link

netlify bot commented May 31, 2025

‼️ Deploy request for tanstack rejected.

Name Link
🔨 Latest commit 989227b

SeanCassiere

This comment was marked as resolved.

@nrjdalal
Copy link
Author

nrjdalal commented Jun 1, 2025

This is my overall feedback on changes:

  • Do not remove the drop shadows on the cards on the homepage. This is a quite a large visual change and I'd prefer it be pushed up separate to the other stylings changes. I'm asking for it to be separated out since it'd be best that the other have some input on whether it stylistically fits what's happening.
  • Do not add the @ianvs/prettier-plugin-sort-imports package for sorting imports. The website doesn't need to be that opinionated.
  • For TailwindCSS v4, please use the PostCSS method.

Overall, while the PR is workable, I think that it has just a bit too much happening in it. Please break it out into smaller chunks.

I'd recommend doing in separate chunks/PRs like.

  • Tailwind v4 upgrade.
  • Tailwindcss plugin addition. This would include the linting changes while the update to the styles. Optionally, you could introduce this in the tailwindcss v4 upgrade to save time.
  • Website styling changes. Please list exactly what's changing (and where) for this.
  • reduced footprint from 100 to 25%, removed import-sorting, add postcss
  • attached images for visual changes, beside that, just fixed alignment of docs, when there's no TOC things are not centered or small-width (visual transition has no layout shifts), fixed width aligned right, there's not a lot to it

@SeanCassiere SeanCassiere marked this pull request as draft June 1, 2025 02:35
@KevinVandy
Copy link
Member

There seems to be some extra spacing here:

image

@nrjdalal
Copy link
Author

nrjdalal commented Jun 2, 2025

@KevinVandy 1920? what's your viewport?

@KevinVandy
Copy link
Member

@KevinVandy 1920? what's your viewport?

Although, it may be the case that your tastack-com preview hasn't updated with any of the new commits?

@KevinVandy
Copy link
Member

Looks like these headings got centered aligned somehow

image

@nrjdalal
Copy link
Author

nrjdalal commented Jun 2, 2025

try now, what was really extra was the space, just left to the red part

if we mark the same spot here, it's is kinda intentional to keep docs centered to reader viewing area

preview faster here - https://tanstack-com.vercel.app

Screenshot 2025-06-02 at 6 32 47 PM

@nrjdalal
Copy link
Author

nrjdalal commented Jun 2, 2025

@KevinVandy #422 (comment) should I align em' to left?

@KevinVandy
Copy link
Member

@KevinVandy #422 (comment) should I align em' to left?

As @SeanCassiere said, I think this PR would ideally just upgrade to Tailwind v4 without large style differences. Fixing bugs or style inconsistencies along the way is fine, but it's easier to respect Tanner's original style choices, and then tweak those independently in subsequent proposals.

@nrjdalal
Copy link
Author

nrjdalal commented Jun 2, 2025

when no TOC, the idea is to keep the transition alignment stable not breaking also

Screenshot 2025-06-02 at 6 32 47 PM

Screenshot 2025-06-02 at 6 41 06 PM

@nrjdalal
Copy link
Author

nrjdalal commented Jun 2, 2025

@KevinVandy #422 (comment) should I align em' to left?

As @SeanCassiere said, I think this PR would ideally just upgrade to Tailwind v4 without large style differences. Fixing bugs or style inconsistencies along the way is fine, but it's easier to respect Tanner's original style choices, and then tweak those independently in subsequent proposals.

sure, no worries...

@nrjdalal
Copy link
Author

nrjdalal commented Jun 2, 2025

@KevinVandy - on sidenote, won't be able to make anymore changes for now as I did ran prettier and made many changes before and after, migrating from v3 to v4 also broke so many things that had to be fixed...

keep the PR as draft, when I or somebody gets time to make em' changes, they can refer to this

@nrjdalal
Copy link
Author

nrjdalal commented Jun 2, 2025

Caution

DO NOT MERGE.
This PR is for UI enhancements/migration-reference purpose only.

Repository - https://github.com/nrjdalal/tanstack.com/tree/revamp
Preview - https://tanstack-com.vercel.app

@KevinVandy
Copy link
Member

@KevinVandy - on sidenote, won't be able to make anymore changes for now as I did ran prettier and made many changes before and after, migrating from v3 to v4 also broke so many things that had to be fixed...

Ok. This seemed close. Just want to make sure there's no unintentional regressions.

@nrjdalal
Copy link
Author

nrjdalal commented Jun 3, 2025

not any that I've noticed so far

can make listed changes for sure, like a compiled and noticed list, but yeah

all of it works I guess, just a minor patch here and there is going to be required, but nothing is breaking as such

@SeanCassiere
Copy link
Member

I'm closing this PR as requested by @nrjdalal.

Screenshot_2025-06-04-11-25-28-48_572064f74bd5f9fa804b05334aa4f912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants