-
-
Notifications
You must be signed in to change notification settings - Fork 247
feat: migrate from tailwind v3 to v4 and UI enhancements #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 989227b |
|
|
@KevinVandy 1920? what's your viewport? |
Although, it may be the case that your tastack-com preview hasn't updated with any of the new commits? |
|
try now, what was really extra was the space, just left to the red part if we mark the same spot here, it's is kinda intentional to keep docs centered to reader viewing area preview faster here - https://tanstack-com.vercel.app |
|
@KevinVandy #422 (comment) should I align em' to left? |
As @SeanCassiere said, I think this PR would ideally just upgrade to Tailwind v4 without large style differences. Fixing bugs or style inconsistencies along the way is fine, but it's easier to respect Tanner's original style choices, and then tweak those independently in subsequent proposals. |
sure, no worries... |
|
@KevinVandy - on sidenote, won't be able to make anymore changes for now as I did ran prettier and made many changes before and after, migrating from v3 to v4 also broke so many things that had to be fixed... keep the PR as draft, when I or somebody gets time to make em' changes, they can refer to this |
|
Caution DO NOT MERGE. Repository - https://github.com/nrjdalal/tanstack.com/tree/revamp |
Ok. This seemed close. Just want to make sure there's no unintentional regressions. |
|
not any that I've noticed so far can make listed changes for sure, like a compiled and noticed list, but yeah all of it works I guess, just a minor patch here and there is going to be required, but nothing is breaking as such |
|
I'm closing this PR as requested by @nrjdalal. |






Uh oh!
There was an error while loading. Please reload this page.