fix(deps): bump @tanstack/dom-vite to 0.1.0-alpha.8#850
Merged
tannerlinsley merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
Picks up fix(react-dom): reverse-iterate placeChildrenInOrder — fixes the Analyze / "I'm feeling lucky" swap on the application starter and the library dropdown reorder on the npm stats page. Forward iteration of placeChildrenInOrder cascaded moves into the wrong final order when the starting DOM diverged from the target. Reverse iteration places each node before its already-final successor, so the cascade can't happen.
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the dev dependency Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up TanStack/react@fb904fa —
fix(react-dom): reverse-iterate placeChildrenInOrder.Fixes these user-reported reorder bugs:
Root cause was the shim's forward iteration over the placement loop. When the starting DOM diverged from the target, each `insertBefore(doms[i], doms[i+1])` pulled doms[i] forward past nodes that should move behind it, cascading into the wrong final order.
Test plan
Summary by CodeRabbit