fix: stabilize lane assignments in masonry layout #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ee9f57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seob717
force-pushed
the
fix/stable-masonry-lanes
branch
from
8f3e82f to
8fcdd95
Compare
Added lane assignment caching to prevent items from jumping between lanes when viewport is resized. Previously, items could shift to different lanes during resize due to recalculating "shortest lane" with slightly different heights. Changes: - Added `laneAssignments` cache (Map<index, lane>) to persist lane assignments - Lane cache is cleared when `lanes` option changes or `measure()` is called - Lane cache is cleaned up when `count` decreases (removes stale entries) - Lane cache is cleared when virtualizer is disabled
seob717
force-pushed
the
fix/stable-masonry-lanes
branch
from
8fcdd95 to
8f360f5
Compare
Use laneLastIndex array to track last item per lane instead of iterating through all measurements
seob717
force-pushed
the
fix/stable-masonry-lanes
branch
from
7d61a38 to
b6fc37a
Compare
|
View your CI Pipeline Execution ↗ for commit 2ee9f57
☁️ Nx Cloud last updated this comment at |
Collaborator
|
@seob717 Looks great overall, the lane caching + settling logic makes the masonry layout much more stable on resize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added lane assignment caching to prevent items from jumping between lanes when viewport is resized. Previously, items could shift to different lanes during resize due to recalculating "shortest lane" with slightly different heights.
Changes:
laneAssignmentscache (Map<index, lane>) to persist lane assignmentslanesoption changes ormeasure()is calledcountdecreases (removes stale entries)🤖 Generated with Claude Code
🎯 Changes
✅ Checklist