Skip to content

feat: display secrets in pipeline run view#1772

Merged
maxy-shpfy merged 1 commit intomasterfrom
02-09-feat_display_secrets_in_pipeline_run_view
Feb 19, 2026
Merged

feat: display secrets in pipeline run view#1772
maxy-shpfy merged 1 commit intomasterfrom
02-09-feat_display_secrets_in_pipeline_run_view

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 9, 2026

Description

Added support for displaying secret arguments in task argument values. When a task argument is a secret, it will now be displayed as "🔒 [secret name]" instead of being undefined.

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Screen Recording 2026-02-17 at 5.29.30 PM.mov (uploaded via Graphite)

  1. Create a task with a secret argument
  2. Verify that the secret is displayed with a lock icon and the secret name

@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 22b3cc3 to f427f0b Compare February 9, 2026 21:04
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from c74c1a4 to 569e86c Compare February 9, 2026 21:04
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from f427f0b to 8bfc272 Compare February 9, 2026 21:07
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch 2 times, most recently from cd647b8 to b3b5c86 Compare February 9, 2026 21:28
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch 2 times, most recently from 038bbb0 to 4c10b14 Compare February 9, 2026 21:32
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from b3b5c86 to 0889f6e Compare February 9, 2026 21:32
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 4c10b14 to 7fe083d Compare February 9, 2026 22:03
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 0889f6e to 7c9edf4 Compare February 9, 2026 22:03
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 7c9edf4 to 1534ee0 Compare February 18, 2026 01:30
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 7fe083d to 9548f61 Compare February 18, 2026 01:30
@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 18, 2026 01:33
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 18, 2026 01:33
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 9548f61 to 65b9fdc Compare February 18, 2026 19:11
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 1534ee0 to 1a51515 Compare February 18, 2026 19:11
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 65b9fdc to 516b447 Compare February 18, 2026 19:36
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch 2 times, most recently from 6cd67a9 to 3530186 Compare February 18, 2026 19:46
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 516b447 to 4da2463 Compare February 18, 2026 19:46
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 3530186 to d783374 Compare February 18, 2026 20:21
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 4da2463 to f22f4f9 Compare February 18, 2026 20:21
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from d783374 to 23d41ad Compare February 18, 2026 20:27
Copy link
Copy Markdown
Collaborator

Is it worth updating the input list as well in the task panel?

image.png

Instead of blank it could be the lock + secret name

@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 7718112 to cf6c466 Compare February 18, 2026 20:59
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 7ee8e8b to d65e341 Compare February 18, 2026 21:02
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from cf6c466 to c2a05c4 Compare February 18, 2026 21:02
Copy link
Copy Markdown
Collaborator

Is there any feasible way to give the user feedback if a component is failing due to an invalid secret input?

Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ would be nice to include the above items but can also probably be a follow-up

Copy link
Copy Markdown
Collaborator Author

>Is it worth updating the input list as well in the task panel?

It might be tricky - server does not return it in Artifacts response. So we need to dance to match arguments against the inputs which may lead to complications in IOInputs / IOCell etc components. I would investigate that as a separate PR since the change can grow big

Copy link
Copy Markdown
Collaborator Author

>Is there any feasible way to give the user feedback if a component is failing due to an invalid secret input?

It will be displayed as a System Error: Error resolving a secret argument for input_name='API_KEY': User developer@localhost does not have secret API_KEY.. Unless server returns some special code, I'm not sure how to determine that for UX-friendly representation that in generic and feasible way.

We can include validation step to match used secrets against available secrets - that's something to consider, but may not be available in every use-case.

@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from d65e341 to 3af39ce Compare February 19, 2026 01:56
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from c2a05c4 to 1e8d99c Compare February 19, 2026 01:56
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 3af39ce to fa1feb3 Compare February 19, 2026 02:50
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 1e8d99c to 1b135f8 Compare February 19, 2026 02:50
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from fa1feb3 to c5b514b Compare February 19, 2026 02:54
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 1b135f8 to 559c17e Compare February 19, 2026 02:54
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from c5b514b to 238f88a Compare February 19, 2026 03:11
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 559c17e to 7c01808 Compare February 19, 2026 03:12
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 238f88a to 5eb34e0 Compare February 19, 2026 03:39
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 7c01808 to 7fe796d Compare February 19, 2026 03:39
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch 2 times, most recently from fca7f91 to 2e2f9b6 Compare February 19, 2026 03:52
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 7fe796d to f7b6539 Compare February 19, 2026 03:52
@maxy-shpfy maxy-shpfy changed the base branch from 02-09-feat_use_api_as_secrets_storage to graphite-base/1772 February 19, 2026 03:55
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from f7b6539 to 71d9b08 Compare February 19, 2026 03:56
@graphite-app graphite-app Bot changed the base branch from graphite-base/1772 to master February 19, 2026 03:56
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_display_secrets_in_pipeline_run_view branch from 71d9b08 to e6194e8 Compare February 19, 2026 03:56
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented Feb 19, 2026

Merge activity

  • Feb 19, 5:34 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 19, 5:34 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit df5e50b into master Feb 19, 2026
7 of 8 checks passed
@maxy-shpfy maxy-shpfy deleted the 02-09-feat_display_secrets_in_pipeline_run_view branch February 19, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants